Re: [PR] [CELEBORN-1743] [FOLLOWUP] Delay the application metrics in metrics queue when the capacity is reached [celeborn]

["zaynt4606 (via GitHub)" <gi...@apache.org>]

zaynt4606 commented on code in PR #2964:
URL: https://github.com/apache/celeborn/pull/2964#discussion_r1868694157


##########
common/src/main/scala/org/apache/celeborn/common/metrics/source/AbstractSource.scala:
##########
@@ -457,12 +483,19 @@ abstract class AbstractSource(conf: CelebornConf, role: String)
   override def getMetrics(): String = {
     var leftMetricsNum = metricsCapacity
     val sb = new mutable.StringBuilder
-    leftMetricsNum = fillInnerMetricsSnapshot(getAndClearTimerMetrics(), leftMetricsNum, sb)
-    leftMetricsNum = fillInnerMetricsSnapshot(timers(), leftMetricsNum, sb)
-    leftMetricsNum = fillInnerMetricsSnapshot(histograms(), leftMetricsNum, sb)
-    leftMetricsNum = fillInnerMetricsSnapshot(meters(), leftMetricsNum, sb)
-    leftMetricsNum = fillInnerMetricsSnapshot(gauges(), leftMetricsNum, sb)
-    leftMetricsNum = fillInnerMetricsSnapshot(counters(), leftMetricsNum, sb)
+    val appMetricsSnapshot = ArrayBuffer[String]()
+    leftMetricsNum =
+      fillInnerMetricsSnapshot(getAndClearTimerMetrics(), leftMetricsNum, sb, appMetricsSnapshot)
+    leftMetricsNum = fillInnerMetricsSnapshot(timers(), leftMetricsNum, sb, appMetricsSnapshot)
+    leftMetricsNum = fillInnerMetricsSnapshot(histograms(), leftMetricsNum, sb, appMetricsSnapshot)
+    leftMetricsNum = fillInnerMetricsSnapshot(meters(), leftMetricsNum, sb, appMetricsSnapshot)
+    leftMetricsNum = fillInnerMetricsSnapshot(gauges(), leftMetricsNum, sb, appMetricsSnapshot)
+    leftMetricsNum = fillInnerMetricsSnapshot(counters(), leftMetricsNum, sb, appMetricsSnapshot)
+    if (leftMetricsNum > 0 && metricsAppEnabled) {
+      appMetricsSnapshot.toList.take(leftMetricsNum).foreach { appMetrics =>

Review Comment:
   Only Non-AppMetrics are full will logWarn.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org