You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by Alexander Pivovarov <ap...@gmail.com> on 2015/03/18 02:47:56 UTC
Review Request 32189: HIVE-9859 Create bitwise left/right shift UDFs
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32189/
-----------------------------------------------------------
Review request for hive and Jason Dere.
Bugs: HIVE-9859
https://issues.apache.org/jira/browse/HIVE-9859
Repository: hive-git
Description
-------
HIVE-9859 Create bitwise left/right shift UDFs
Diffs
-----
ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java fdbfab9e1c4f098766f58e2d07653a44f45d3350
ql/src/java/org/apache/hadoop/hive/ql/parse/HiveLexer.g e7de6c86a3c7a674b54f3678b00f34f2dd903dc8
ql/src/java/org/apache/hadoop/hive/ql/parse/HiveParser.g d2d998972b64a19bde28cf176b3f948c00ba492a
ql/src/java/org/apache/hadoop/hive/ql/parse/IdentifiersParser.g 0a05cebf1f71bd32c8023cdb10c8393a0d871cc2
ql/src/java/org/apache/hadoop/hive/ql/udf/UDFOPBitLeftShift.java PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/udf/UDFOPBitRightShift.java PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/udf/UDFOPBitUnsignedRightShift.java PRE-CREATION
ql/src/test/queries/clientpositive/udf_bitwise_left_shift.q PRE-CREATION
ql/src/test/queries/clientpositive/udf_bitwise_right_shift.q PRE-CREATION
ql/src/test/queries/clientpositive/udf_bitwise_unsigned_right_shift.q PRE-CREATION
ql/src/test/results/clientpositive/show_functions.q.out 81abeb9be4fd47724be544c7bc8da8b25fcd6e75
ql/src/test/results/clientpositive/udf_bitwise_left_shift.q.out PRE-CREATION
ql/src/test/results/clientpositive/udf_bitwise_right_shift.q.out PRE-CREATION
ql/src/test/results/clientpositive/udf_bitwise_unsigned_right_shift.q.out PRE-CREATION
Diff: https://reviews.apache.org/r/32189/diff/
Testing
-------
Thanks,
Alexander Pivovarov
Re: Review Request 32189: HIVE-9859 Create bitwise left/right shift
UDFs
Posted by Alexander Pivovarov <ap...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32189/
-----------------------------------------------------------
(Updated March 24, 2015, 4:44 a.m.)
Review request for hive and Jason Dere.
Changes
-------
fixed FunctionRegistry
Bugs: HIVE-9859
https://issues.apache.org/jira/browse/HIVE-9859
Repository: hive-git
Description
-------
HIVE-9859 Create bitwise left/right shift UDFs
Diffs (updated)
-----
ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java 2ba7adf2e6fc8a184c9d1619619dff2f0870528b
ql/src/java/org/apache/hadoop/hive/ql/udf/UDFOPBitShiftLeft.java PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/udf/UDFOPBitShiftRight.java PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/udf/UDFOPBitShiftRightUnsigned.java PRE-CREATION
ql/src/test/queries/clientpositive/udf_bitwise_shiftleft.q PRE-CREATION
ql/src/test/queries/clientpositive/udf_bitwise_shiftright.q PRE-CREATION
ql/src/test/queries/clientpositive/udf_bitwise_shiftrightunsigned.q PRE-CREATION
ql/src/test/results/clientpositive/show_functions.q.out 81abeb9be4fd47724be544c7bc8da8b25fcd6e75
ql/src/test/results/clientpositive/udf_bitwise_shiftleft.q.out PRE-CREATION
ql/src/test/results/clientpositive/udf_bitwise_shiftright.q.out PRE-CREATION
ql/src/test/results/clientpositive/udf_bitwise_shiftrightunsigned.q.out PRE-CREATION
Diff: https://reviews.apache.org/r/32189/diff/
Testing
-------
Thanks,
Alexander Pivovarov
Re: Review Request 32189: HIVE-9859 Create bitwise left/right shift
UDFs
Posted by Alexander Pivovarov <ap...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32189/
-----------------------------------------------------------
(Updated March 24, 2015, 4:42 a.m.)
Review request for hive and Jason Dere.
Changes
-------
renamed functions to shiftleft, shiftright, shiftrightunsigned
Bugs: HIVE-9859
https://issues.apache.org/jira/browse/HIVE-9859
Repository: hive-git
Description
-------
HIVE-9859 Create bitwise left/right shift UDFs
Diffs (updated)
-----
ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java 2ba7adf2e6fc8a184c9d1619619dff2f0870528b
ql/src/java/org/apache/hadoop/hive/ql/udf/UDFOPBitShiftLeft.java PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/udf/UDFOPBitShiftRight.java PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/udf/UDFOPBitShiftRightUnsigned.java PRE-CREATION
ql/src/test/queries/clientpositive/udf_bitwise_shiftleft.q PRE-CREATION
ql/src/test/queries/clientpositive/udf_bitwise_shiftright.q PRE-CREATION
ql/src/test/queries/clientpositive/udf_bitwise_shiftrightunsigned.q PRE-CREATION
ql/src/test/results/clientpositive/show_functions.q.out 81abeb9be4fd47724be544c7bc8da8b25fcd6e75
ql/src/test/results/clientpositive/udf_bitwise_shiftleft.q.out PRE-CREATION
ql/src/test/results/clientpositive/udf_bitwise_shiftright.q.out PRE-CREATION
ql/src/test/results/clientpositive/udf_bitwise_shiftrightunsigned.q.out PRE-CREATION
Diff: https://reviews.apache.org/r/32189/diff/
Testing
-------
Thanks,
Alexander Pivovarov
Re: Review Request 32189: HIVE-9859 Create bitwise left/right shift
UDFs
Posted by Alexander Pivovarov <ap...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32189/
-----------------------------------------------------------
(Updated March 20, 2015, 5:10 p.m.)
Review request for hive and Jason Dere.
Changes
-------
fixed show_functions.q.out
Bugs: HIVE-9859
https://issues.apache.org/jira/browse/HIVE-9859
Repository: hive-git
Description
-------
HIVE-9859 Create bitwise left/right shift UDFs
Diffs (updated)
-----
ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java fdbfab9e1c4f098766f58e2d07653a44f45d3350
ql/src/java/org/apache/hadoop/hive/ql/parse/HiveLexer.g e7de6c86a3c7a674b54f3678b00f34f2dd903dc8
ql/src/java/org/apache/hadoop/hive/ql/parse/HiveParser.g d2d998972b64a19bde28cf176b3f948c00ba492a
ql/src/java/org/apache/hadoop/hive/ql/parse/IdentifiersParser.g 0a05cebf1f71bd32c8023cdb10c8393a0d871cc2
ql/src/java/org/apache/hadoop/hive/ql/udf/UDFOPBitLeftShift.java PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/udf/UDFOPBitRightShift.java PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/udf/UDFOPBitUnsignedRightShift.java PRE-CREATION
ql/src/test/queries/clientpositive/udf_bitwise_left_shift.q PRE-CREATION
ql/src/test/queries/clientpositive/udf_bitwise_right_shift.q PRE-CREATION
ql/src/test/queries/clientpositive/udf_bitwise_unsigned_right_shift.q PRE-CREATION
ql/src/test/results/clientpositive/show_functions.q.out 81abeb9be4fd47724be544c7bc8da8b25fcd6e75
ql/src/test/results/clientpositive/udf_bitwise_left_shift.q.out PRE-CREATION
ql/src/test/results/clientpositive/udf_bitwise_right_shift.q.out PRE-CREATION
ql/src/test/results/clientpositive/udf_bitwise_unsigned_right_shift.q.out PRE-CREATION
Diff: https://reviews.apache.org/r/32189/diff/
Testing
-------
Thanks,
Alexander Pivovarov
Re: Review Request 32189: HIVE-9859 Create bitwise left/right shift
UDFs
Posted by Alexander Pivovarov <ap...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32189/
-----------------------------------------------------------
(Updated March 20, 2015, 5:24 a.m.)
Review request for hive and Jason Dere.
Changes
-------
I changed bitwise shift operators to <<-, ->>, ->>> because >> conflicts with nested complex type declaration, e.g. ARRAY<MAP<STRING,STRING>>
I found that HiveParser.g has the following declaration for array type.
: KW_ARRAY LESSTHAN type GREATERTHAN -> ^(TOK_LIST type)
I think it uses LESSTHAN and GREATERTHAN in array type declaration to avoid conflicts with < > operators
I did not find a way how to do this trick with << >>
Bugs: HIVE-9859
https://issues.apache.org/jira/browse/HIVE-9859
Repository: hive-git
Description
-------
HIVE-9859 Create bitwise left/right shift UDFs
Diffs (updated)
-----
ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java fdbfab9e1c4f098766f58e2d07653a44f45d3350
ql/src/java/org/apache/hadoop/hive/ql/parse/HiveLexer.g e7de6c86a3c7a674b54f3678b00f34f2dd903dc8
ql/src/java/org/apache/hadoop/hive/ql/parse/HiveParser.g d2d998972b64a19bde28cf176b3f948c00ba492a
ql/src/java/org/apache/hadoop/hive/ql/parse/IdentifiersParser.g 0a05cebf1f71bd32c8023cdb10c8393a0d871cc2
ql/src/java/org/apache/hadoop/hive/ql/udf/UDFOPBitLeftShift.java PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/udf/UDFOPBitRightShift.java PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/udf/UDFOPBitUnsignedRightShift.java PRE-CREATION
ql/src/test/queries/clientpositive/udf_bitwise_left_shift.q PRE-CREATION
ql/src/test/queries/clientpositive/udf_bitwise_right_shift.q PRE-CREATION
ql/src/test/queries/clientpositive/udf_bitwise_unsigned_right_shift.q PRE-CREATION
ql/src/test/results/clientpositive/show_functions.q.out 81abeb9be4fd47724be544c7bc8da8b25fcd6e75
ql/src/test/results/clientpositive/udf_bitwise_left_shift.q.out PRE-CREATION
ql/src/test/results/clientpositive/udf_bitwise_right_shift.q.out PRE-CREATION
ql/src/test/results/clientpositive/udf_bitwise_unsigned_right_shift.q.out PRE-CREATION
Diff: https://reviews.apache.org/r/32189/diff/
Testing
-------
Thanks,
Alexander Pivovarov