You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2021/10/07 10:11:31 UTC
[GitHub] [flink] Aitozi opened a new pull request #17426: [FLINK-24167][Runtime]Add default HeartbeatReceiver and HeartbeatSend…
Aitozi opened a new pull request #17426:
URL: https://github.com/apache/flink/pull/17426
…er to simplify the usage of HeartbeatTarget
## What is the purpose of the change
Add default HeartbeatReceiver and HeartbeatSender to simplify the usage of HeartbeatTarget
## Brief change log
Let most heartbeat listeners extend from `HeartbeatReceiver` or `HeartbeatSender` instead using `HeartbeatTarget` directly
## Verifying this change
This change is already covered by existing tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17426: [FLINK-24167][Runtime]Add default HeartbeatReceiver and HeartbeatSend…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17426:
URL: https://github.com/apache/flink/pull/17426#issuecomment-938516939
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17426: [FLINK-24167][Runtime]Add default HeartbeatReceiver and HeartbeatSend…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17426:
URL: https://github.com/apache/flink/pull/17426#issuecomment-938516939
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "75c4348dc82fbebe4d064076f63d2f5a9054d1a7",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24843",
"triggerID" : "75c4348dc82fbebe4d064076f63d2f5a9054d1a7",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 75c4348dc82fbebe4d064076f63d2f5a9054d1a7 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24843)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #17426: [FLINK-24167][Runtime]Add default HeartbeatReceiver and HeartbeatSend…
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #17426:
URL: https://github.com/apache/flink/pull/17426#issuecomment-938516939
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "75c4348dc82fbebe4d064076f63d2f5a9054d1a7",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "75c4348dc82fbebe4d064076f63d2f5a9054d1a7",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 75c4348dc82fbebe4d064076f63d2f5a9054d1a7 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #17426: [FLINK-24167][Runtime]Add default HeartbeatReceiver and HeartbeatSend…
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #17426:
URL: https://github.com/apache/flink/pull/17426#issuecomment-937651834
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 75c4348dc82fbebe4d064076f63d2f5a9054d1a7 (Thu Oct 07 10:14:03 UTC 2021)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
* **This pull request references an unassigned [Jira ticket](https://issues.apache.org/jira/browse/FLINK-24167).** According to the [code contribution guide](https://flink.apache.org/contributing/contribute-code.html), tickets need to be assigned before starting with the implementation work.
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17426: [FLINK-24167][Runtime]Add default HeartbeatReceiver and HeartbeatSend…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17426:
URL: https://github.com/apache/flink/pull/17426#issuecomment-938516939
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "75c4348dc82fbebe4d064076f63d2f5a9054d1a7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24843",
"triggerID" : "75c4348dc82fbebe4d064076f63d2f5a9054d1a7",
"triggerType" : "PUSH"
}, {
"hash" : "b3f889f3c75ca26e6e54e45694d207e529d9dd43",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "939230211",
"triggerType" : "MANUAL"
}, {
"hash" : "",
"status" : "CANCELED",
"url" : "TBD",
"triggerID" : "939230211",
"triggerType" : "MANUAL"
}, {
"hash" : "b3f889f3c75ca26e6e54e45694d207e529d9dd43",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "b3f889f3c75ca26e6e54e45694d207e529d9dd43",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* Unknown: [CANCELED](TBD)
* b3f889f3c75ca26e6e54e45694d207e529d9dd43 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] tillrohrmann closed pull request #17426: [FLINK-24167][Runtime]Add default HeartbeatReceiver and HeartbeatSend…
Posted by GitBox <gi...@apache.org>.
tillrohrmann closed pull request #17426:
URL: https://github.com/apache/flink/pull/17426
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] Aitozi commented on pull request #17426: [FLINK-24167][Runtime]Add default HeartbeatReceiver and HeartbeatSend…
Posted by GitBox <gi...@apache.org>.
Aitozi commented on pull request #17426:
URL: https://github.com/apache/flink/pull/17426#issuecomment-949307873
@tillrohrmann Please help review this PR when you are free
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] tillrohrmann commented on a change in pull request #17426: [FLINK-24167][Runtime]Add default HeartbeatReceiver and HeartbeatSend…
Posted by GitBox <gi...@apache.org>.
tillrohrmann commented on a change in pull request #17426:
URL: https://github.com/apache/flink/pull/17426#discussion_r740964619
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/heartbeat/HeartbeatReceiver.java
##########
@@ -0,0 +1,40 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.runtime.heartbeat;
+
+import org.apache.flink.runtime.clusterframework.types.ResourceID;
+import org.apache.flink.util.concurrent.FutureUtils;
+
+import java.util.concurrent.CompletableFuture;
+
+/**
+ * The receiver implementation of {@link HeartbeatTarget}, which mute the {@link
Review comment:
```suggestion
* The receiver implementation of {@link HeartbeatTarget}, which mutes the {@link
```
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/heartbeat/HeartbeatReceiver.java
##########
@@ -0,0 +1,40 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.runtime.heartbeat;
+
+import org.apache.flink.runtime.clusterframework.types.ResourceID;
+import org.apache.flink.util.concurrent.FutureUtils;
+
+import java.util.concurrent.CompletableFuture;
+
+/**
+ * The receiver implementation of {@link HeartbeatTarget}, which mute the {@link
+ * HeartbeatTarget#requestHeartbeat(ResourceID, I)}. The extender only have to care about the
Review comment:
```suggestion
* HeartbeatTarget#requestHeartbeat(ResourceID, I)}. The extender only has to care about the
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #17426: [FLINK-24167][Runtime]Add default HeartbeatReceiver and HeartbeatSend…
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #17426:
URL: https://github.com/apache/flink/pull/17426#issuecomment-937651834
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 75c4348dc82fbebe4d064076f63d2f5a9054d1a7 (Thu Oct 07 10:14:03 UTC 2021)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
* **This pull request references an unassigned [Jira ticket](https://issues.apache.org/jira/browse/FLINK-24167).** According to the [code contribution guide](https://flink.apache.org/contributing/contribute-code.html), tickets need to be assigned before starting with the implementation work.
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17426: [FLINK-24167][Runtime]Add default HeartbeatReceiver and HeartbeatSend…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17426:
URL: https://github.com/apache/flink/pull/17426#issuecomment-938516939
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "75c4348dc82fbebe4d064076f63d2f5a9054d1a7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24843",
"triggerID" : "75c4348dc82fbebe4d064076f63d2f5a9054d1a7",
"triggerType" : "PUSH"
}, {
"hash" : "b3f889f3c75ca26e6e54e45694d207e529d9dd43",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24889",
"triggerID" : "939230211",
"triggerType" : "MANUAL"
}, {
"hash" : "b3f889f3c75ca26e6e54e45694d207e529d9dd43",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24889",
"triggerID" : "b3f889f3c75ca26e6e54e45694d207e529d9dd43",
"triggerType" : "PUSH"
}, {
"hash" : "",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "939230211",
"triggerType" : "MANUAL"
}, {
"hash" : "d6145cd6809c58eadcf62a35d7661f8de92f3a78",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "d6145cd6809c58eadcf62a35d7661f8de92f3a78",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* b3f889f3c75ca26e6e54e45694d207e529d9dd43 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24889)
* d6145cd6809c58eadcf62a35d7661f8de92f3a78 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] tillrohrmann closed pull request #17426: [FLINK-24167][Runtime]Add default HeartbeatReceiver and HeartbeatSend…
Posted by GitBox <gi...@apache.org>.
tillrohrmann closed pull request #17426:
URL: https://github.com/apache/flink/pull/17426
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17426: [FLINK-24167][Runtime]Add default HeartbeatReceiver and HeartbeatSend…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17426:
URL: https://github.com/apache/flink/pull/17426#issuecomment-938516939
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "75c4348dc82fbebe4d064076f63d2f5a9054d1a7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24843",
"triggerID" : "75c4348dc82fbebe4d064076f63d2f5a9054d1a7",
"triggerType" : "PUSH"
}, {
"hash" : "b3f889f3c75ca26e6e54e45694d207e529d9dd43",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24889",
"triggerID" : "939230211",
"triggerType" : "MANUAL"
}, {
"hash" : "b3f889f3c75ca26e6e54e45694d207e529d9dd43",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24889",
"triggerID" : "b3f889f3c75ca26e6e54e45694d207e529d9dd43",
"triggerType" : "PUSH"
}, {
"hash" : "",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "939230211",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* b3f889f3c75ca26e6e54e45694d207e529d9dd43 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24889)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17426: [FLINK-24167][Runtime]Add default HeartbeatReceiver and HeartbeatSend…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17426:
URL: https://github.com/apache/flink/pull/17426#issuecomment-938516939
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "75c4348dc82fbebe4d064076f63d2f5a9054d1a7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24843",
"triggerID" : "75c4348dc82fbebe4d064076f63d2f5a9054d1a7",
"triggerType" : "PUSH"
}, {
"hash" : "b3f889f3c75ca26e6e54e45694d207e529d9dd43",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24889",
"triggerID" : "939230211",
"triggerType" : "MANUAL"
}, {
"hash" : "b3f889f3c75ca26e6e54e45694d207e529d9dd43",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24889",
"triggerID" : "b3f889f3c75ca26e6e54e45694d207e529d9dd43",
"triggerType" : "PUSH"
}, {
"hash" : "",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "939230211",
"triggerType" : "MANUAL"
}, {
"hash" : "d6145cd6809c58eadcf62a35d7661f8de92f3a78",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25796",
"triggerID" : "d6145cd6809c58eadcf62a35d7661f8de92f3a78",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* b3f889f3c75ca26e6e54e45694d207e529d9dd43 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24889)
* d6145cd6809c58eadcf62a35d7661f8de92f3a78 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25796)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] tillrohrmann commented on a change in pull request #17426: [FLINK-24167][Runtime]Add default HeartbeatReceiver and HeartbeatSend…
Posted by GitBox <gi...@apache.org>.
tillrohrmann commented on a change in pull request #17426:
URL: https://github.com/apache/flink/pull/17426#discussion_r740964619
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/heartbeat/HeartbeatReceiver.java
##########
@@ -0,0 +1,40 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.runtime.heartbeat;
+
+import org.apache.flink.runtime.clusterframework.types.ResourceID;
+import org.apache.flink.util.concurrent.FutureUtils;
+
+import java.util.concurrent.CompletableFuture;
+
+/**
+ * The receiver implementation of {@link HeartbeatTarget}, which mute the {@link
Review comment:
```suggestion
* The receiver implementation of {@link HeartbeatTarget}, which mutes the {@link
```
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/heartbeat/HeartbeatReceiver.java
##########
@@ -0,0 +1,40 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.runtime.heartbeat;
+
+import org.apache.flink.runtime.clusterframework.types.ResourceID;
+import org.apache.flink.util.concurrent.FutureUtils;
+
+import java.util.concurrent.CompletableFuture;
+
+/**
+ * The receiver implementation of {@link HeartbeatTarget}, which mute the {@link
+ * HeartbeatTarget#requestHeartbeat(ResourceID, I)}. The extender only have to care about the
Review comment:
```suggestion
* HeartbeatTarget#requestHeartbeat(ResourceID, I)}. The extender only has to care about the
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] Aitozi commented on pull request #17426: [FLINK-24167][Runtime]Add default HeartbeatReceiver and HeartbeatSend…
Posted by GitBox <gi...@apache.org>.
Aitozi commented on pull request #17426:
URL: https://github.com/apache/flink/pull/17426#issuecomment-939230175
The failure case is related to [FLINK-24472](https://issues.apache.org/jira/browse/FLINK-24472) , rebase and run again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] Aitozi commented on pull request #17426: [FLINK-24167][Runtime]Add default HeartbeatReceiver and HeartbeatSend…
Posted by GitBox <gi...@apache.org>.
Aitozi commented on pull request #17426:
URL: https://github.com/apache/flink/pull/17426#issuecomment-939230211
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] tillrohrmann commented on a change in pull request #17426: [FLINK-24167][Runtime]Add default HeartbeatReceiver and HeartbeatSend…
Posted by GitBox <gi...@apache.org>.
tillrohrmann commented on a change in pull request #17426:
URL: https://github.com/apache/flink/pull/17426#discussion_r740964619
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/heartbeat/HeartbeatReceiver.java
##########
@@ -0,0 +1,40 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.runtime.heartbeat;
+
+import org.apache.flink.runtime.clusterframework.types.ResourceID;
+import org.apache.flink.util.concurrent.FutureUtils;
+
+import java.util.concurrent.CompletableFuture;
+
+/**
+ * The receiver implementation of {@link HeartbeatTarget}, which mute the {@link
Review comment:
```suggestion
* The receiver implementation of {@link HeartbeatTarget}, which mutes the {@link
```
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/heartbeat/HeartbeatReceiver.java
##########
@@ -0,0 +1,40 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.runtime.heartbeat;
+
+import org.apache.flink.runtime.clusterframework.types.ResourceID;
+import org.apache.flink.util.concurrent.FutureUtils;
+
+import java.util.concurrent.CompletableFuture;
+
+/**
+ * The receiver implementation of {@link HeartbeatTarget}, which mute the {@link
+ * HeartbeatTarget#requestHeartbeat(ResourceID, I)}. The extender only have to care about the
Review comment:
```suggestion
* HeartbeatTarget#requestHeartbeat(ResourceID, I)}. The extender only has to care about the
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] tillrohrmann closed pull request #17426: [FLINK-24167][Runtime]Add default HeartbeatReceiver and HeartbeatSend…
Posted by GitBox <gi...@apache.org>.
tillrohrmann closed pull request #17426:
URL: https://github.com/apache/flink/pull/17426
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17426: [FLINK-24167][Runtime]Add default HeartbeatReceiver and HeartbeatSend…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17426:
URL: https://github.com/apache/flink/pull/17426#issuecomment-938516939
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "75c4348dc82fbebe4d064076f63d2f5a9054d1a7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24843",
"triggerID" : "75c4348dc82fbebe4d064076f63d2f5a9054d1a7",
"triggerType" : "PUSH"
}, {
"hash" : "",
"status" : "CANCELED",
"url" : "TBD",
"triggerID" : "939230211",
"triggerType" : "MANUAL"
}, {
"hash" : "b3f889f3c75ca26e6e54e45694d207e529d9dd43",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24889",
"triggerID" : "939230211",
"triggerType" : "MANUAL"
}, {
"hash" : "b3f889f3c75ca26e6e54e45694d207e529d9dd43",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24889",
"triggerID" : "b3f889f3c75ca26e6e54e45694d207e529d9dd43",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* Unknown: [CANCELED](TBD)
* b3f889f3c75ca26e6e54e45694d207e529d9dd43 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24889)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17426: [FLINK-24167][Runtime]Add default HeartbeatReceiver and HeartbeatSend…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17426:
URL: https://github.com/apache/flink/pull/17426#issuecomment-938516939
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "75c4348dc82fbebe4d064076f63d2f5a9054d1a7",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24843",
"triggerID" : "75c4348dc82fbebe4d064076f63d2f5a9054d1a7",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 75c4348dc82fbebe4d064076f63d2f5a9054d1a7 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24843)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17426: [FLINK-24167][Runtime]Add default HeartbeatReceiver and HeartbeatSend…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17426:
URL: https://github.com/apache/flink/pull/17426#issuecomment-938516939
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org