You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@maven.apache.org by Brett Porter <br...@apache.org> on 2010/08/07 13:26:43 UTC
Re: guice & memory usage was: (3.0 beta 2/3/4 roadmap was Re: Merging in our Aether and Guice changes to Maven 3.x)
On 07/08/2010, at 12:44 AM, Arnaud Héritier wrote:
> The advantage is to do what I did this morning in few minutes.
> I found a OOME on Aether/Guice branch (reported to benjamin but not in MNG because it's not yet integrated) and then I validated it wasn't here in current trunk.
> The problem is that I had to rebuild both of them hat users won't do.
> Without the beta2 release, each time you'll have to check if the problem reported comes from Guice/Aether or from changes done for now in beta2.
> It is more for you who'll work on it to easily ask a comparison.
I ran this over one of my builds out of curiosity. Not sure if this is helpful, but maybe some datapoints.
3.0-benjamin => 73m / 252m
3.0-beta-1 => 63m / 159m
2.2.1 => 129m / 252m
Then I checked just the following:
3.0-beta-2-SNAPSHOT + guice patch => 70m/218m
3.0-beta-2-SNAPSHOT => 74m/252m
The numbers are quite consistent, so it looks like the problem might have been on trunk here, not the guice++ branch. Arnaud, is that also what you see with trunk?
I quickly ran the first two with Yourkit and saw that in Benjamin's branch, the memory grows faster at a consistent rate, but is still released at the end. The retained memory is only the classrealms and JDK ZIP cache, which basically is the same for beta-1. So more usage, but not a leak. No OOME, but perhaps the project is not big enough to exhibit it.
Nothing to particularly note on the garbage collection front. The non-heap memory looks to be identical. Basically the same results running with a clean repository to do more artifact operations. Scanning the allocations, there's quite deep trees of allocations for Guice & the shim - but given the results for the other snapshots I'm not sure that's an issue itself.
That's all I had time for, but I'll hold onto the snapshots in case they help.
- Brett
--
Brett Porter
brett@apache.org
http://brettporter.wordpress.com/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: guice & memory usage was: (3.0 beta 2/3/4 roadmap was Re: Merging in our Aether and Guice changes to Maven 3.x)
Posted by Hervé BOUTEMY <he...@free.fr>.
Le jeudi 19 août 2010, Jochen Wiedmann a écrit :
> On Wed, Aug 18, 2010 at 11:18 PM, Hervé BOUTEMY <he...@free.fr>
wrote:
> > I have only one concern with current maven-3 code in GitHub: it's not
> > compatible with maven-site-plugin 3.0-beta-1
>
> I think, that's a blocker for a new beta release, but not for a merge,
> isn't it?
it's not a blocker neither for a merge nor a new beta release
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: guice & memory usage was: (3.0 beta 2/3/4 roadmap was Re: Merging in our Aether and Guice changes to Maven 3.x)
Posted by Hervé BOUTEMY <he...@free.fr>.
Le mercredi 18 août 2010, Olivier Lamy a écrit :
> 2010/8/18 Benjamin Bentmann <be...@udo.edu>:
> > Olivier Lamy wrote:
> >> So maybe having a compatibility even if we are in a beta release
> >> process (benjamin ?)
> >
> > I don't feel motivated to maintain yet another layer of compat/bridge
> > code for the sake of single beta plugin.
>
> ok np for me.
ok for me, since this is really a layer and not only a few deprecated methods
:/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: guice & memory usage was: (3.0 beta 2/3/4 roadmap was Re: Merging
in our Aether and Guice changes to Maven 3.x)
Posted by Olivier Lamy <ol...@apache.org>.
2010/8/18 Benjamin Bentmann <be...@udo.edu>:
> Olivier Lamy wrote:
>
>> So maybe having a compatibility even if we are in a beta release
>> process (benjamin ?)
>
> I don't feel motivated to maintain yet another layer of compat/bridge code
> for the sake of single beta plugin.
ok np for me.
>
>
> Benjamin
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
>
>
--
Olivier
http://twitter.com/olamy
http://fr.linkedin.com/in/olamy
http://www.viadeo.com/fr/profile/olivier.lamy7
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: guice & memory usage was: (3.0 beta 2/3/4 roadmap was Re: Merging
in our Aether and Guice changes to Maven 3.x)
Posted by Benjamin Bentmann <be...@udo.edu>.
Olivier Lamy wrote:
> So maybe having a compatibility even if we are in a beta release
> process (benjamin ?)
I don't feel motivated to maintain yet another layer of compat/bridge
code for the sake of single beta plugin.
Benjamin
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: guice & memory usage was: (3.0 beta 2/3/4 roadmap was Re: Merging
in our Aether and Guice changes to Maven 3.x)
Posted by Olivier Lamy <ol...@apache.org>.
2010/8/18 Hervé BOUTEMY <he...@free.fr>:
> Le mercredi 18 août 2010, Olivier Lamy a écrit :
>> Herve : regarding site plugin there is a patch here (
>> https://issues.sonatype.org/secure/attachment/23615/site-plugin-guice-eathe
>> r.patch ).
> yes, I know the patch (I studied it since our last discussion), but that
> doesn't make the future maven 3.0-beta-3 with maven-site-plugin 3.0-beta-1:
> we'll have to release maven-site-plugin 3.0-beta-2, and every pom.xml using
> site plugin will have to be modified.
Sure (btw we need a new release of site plugin for issue with webdav
deployment).
So maybe having a compatibility even if we are in a beta release
process (benjamin ?)
> That's why I am annoyed.
> But you're right, with this patch, this isn't a blocker
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
>
>
--
Olivier
http://twitter.com/olamy
http://fr.linkedin.com/in/olamy
http://www.viadeo.com/fr/profile/olivier.lamy7
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: guice & memory usage was: (3.0 beta 2/3/4 roadmap was Re: Merging in our Aether and Guice changes to Maven 3.x)
Posted by Hervé BOUTEMY <he...@free.fr>.
Le mercredi 18 août 2010, Olivier Lamy a écrit :
> Herve : regarding site plugin there is a patch here (
> https://issues.sonatype.org/secure/attachment/23615/site-plugin-guice-eathe
> r.patch ).
yes, I know the patch (I studied it since our last discussion), but that
doesn't make the future maven 3.0-beta-3 with maven-site-plugin 3.0-beta-1:
we'll have to release maven-site-plugin 3.0-beta-2, and every pom.xml using
site plugin will have to be modified.
That's why I am annoyed.
But you're right, with this patch, this isn't a blocker
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: guice & memory usage was: (3.0 beta 2/3/4 roadmap was Re:
Merging in our Aether and Guice changes to Maven 3.x)
Posted by Manfred Moser <ma...@mosabuam.com>.
Well.. can we get that patch applied and a new release of the maven 3 site
plugin as well then.
manfred
PS: beta 2 works on all my projects..
> Hi,
> Let's go for merge ! (with last spice version 1.3.3-SNAPSHOT or
> released version to have a fix for SPICE-34).
>
> Herve : regarding site plugin there is a patch here (
> https://issues.sonatype.org/secure/attachment/23615/site-plugin-guice-eather.patch
> ).
>
>
> 2010/8/18 Hervé BOUTEMY <he...@free.fr>:
>> Le mercredi 18 août 2010, Jason van Zyl a écrit :
>>> On Aug 18, 2010, at 1:43 PM, Arnaud Héritier wrote:
>>> > Hi,
>>> >
>>> > I just rebuilt aether and maven3 and I have now : 14M/125M
>>> > We are really near of 9M/125M we have in beta2
>>> > Perfect !!!
>>> >
>>> > Let's go for a merge in trunk ??
>>>
>>> Yup, let's merge it all in and move forward.
>>
>> I have only one concern with current maven-3 code in GitHub: it's not
>> compatible with maven-site-plugin 3.0-beta-1
>> I'm trying to find a way to make it compatible, without success for the
>> moment
>> :(
>> I know it's only betas, used only by people who know what they are
>> doing, but
>> it is annoying...
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
>> For additional commands, e-mail: dev-help@maven.apache.org
>>
>>
>
>
>
> --
> Olivier
> http://twitter.com/olamy
> http://fr.linkedin.com/in/olamy
> http://www.viadeo.com/fr/profile/olivier.lamy7
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: guice & memory usage was: (3.0 beta 2/3/4 roadmap was Re: Merging
in our Aether and Guice changes to Maven 3.x)
Posted by Olivier Lamy <ol...@apache.org>.
Hi,
Let's go for merge ! (with last spice version 1.3.3-SNAPSHOT or
released version to have a fix for SPICE-34).
Herve : regarding site plugin there is a patch here (
https://issues.sonatype.org/secure/attachment/23615/site-plugin-guice-eather.patch
).
2010/8/18 Hervé BOUTEMY <he...@free.fr>:
> Le mercredi 18 août 2010, Jason van Zyl a écrit :
>> On Aug 18, 2010, at 1:43 PM, Arnaud Héritier wrote:
>> > Hi,
>> >
>> > I just rebuilt aether and maven3 and I have now : 14M/125M
>> > We are really near of 9M/125M we have in beta2
>> > Perfect !!!
>> >
>> > Let's go for a merge in trunk ??
>>
>> Yup, let's merge it all in and move forward.
>
> I have only one concern with current maven-3 code in GitHub: it's not
> compatible with maven-site-plugin 3.0-beta-1
> I'm trying to find a way to make it compatible, without success for the moment
> :(
> I know it's only betas, used only by people who know what they are doing, but
> it is annoying...
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
>
>
--
Olivier
http://twitter.com/olamy
http://fr.linkedin.com/in/olamy
http://www.viadeo.com/fr/profile/olivier.lamy7
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: guice & memory usage was: (3.0 beta 2/3/4 roadmap was Re: Merging
in our Aether and Guice changes to Maven 3.x)
Posted by Jochen Wiedmann <jo...@gmail.com>.
On Wed, Aug 18, 2010 at 11:18 PM, Hervé BOUTEMY <he...@free.fr> wrote:
> I have only one concern with current maven-3 code in GitHub: it's not
> compatible with maven-site-plugin 3.0-beta-1
I think, that's a blocker for a new beta release, but not for a merge, isn't it?
Jochen
--
I Am What I Am And That's All What I Yam (Popeye)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: guice & memory usage was: (3.0 beta 2/3/4 roadmap was Re: Merging in our Aether and Guice changes to Maven 3.x)
Posted by Hervé BOUTEMY <he...@free.fr>.
Le mercredi 18 août 2010, Jason van Zyl a écrit :
> On Aug 18, 2010, at 1:43 PM, Arnaud Héritier wrote:
> > Hi,
> >
> > I just rebuilt aether and maven3 and I have now : 14M/125M
> > We are really near of 9M/125M we have in beta2
> > Perfect !!!
> >
> > Let's go for a merge in trunk ??
>
> Yup, let's merge it all in and move forward.
I have only one concern with current maven-3 code in GitHub: it's not
compatible with maven-site-plugin 3.0-beta-1
I'm trying to find a way to make it compatible, without success for the moment
:(
I know it's only betas, used only by people who know what they are doing, but
it is annoying...
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: guice & memory usage was: (3.0 beta 2/3/4 roadmap was Re: Merging
in our Aether and Guice changes to Maven 3.x)
Posted by Stephen Connolly <st...@gmail.com>.
+10000
On 18 August 2010 22:02, Jason van Zyl <ja...@sonatype.com> wrote:
>
> On Aug 18, 2010, at 1:43 PM, Arnaud Héritier wrote:
>
>> Hi,
>>
>> I just rebuilt aether and maven3 and I have now : 14M/125M
>> We are really near of 9M/125M we have in beta2
>> Perfect !!!
>>
>> Let's go for a merge in trunk ??
>>
>
> Yup, let's merge it all in and move forward.
>
>> Arnaud
>>
>> On Aug 7, 2010, at 2:37 PM, Arnaud Héritier wrote:
>>
>>> Results I had yesterday were :
>>>
>>> 3.0-benjamin (built yesterday) : 14M/2488M in 5:23.389s (It probably swapped a lot)
>>> 3.0-beta-2 (downloaded few minutes ago) : 9M/125M built in 23.723s
>>> 2.2.1 : 67M/136M built in 30s
>>>
>>> I only built one module : http://svn.exoplatform.org/projects/ecms/trunk/packaging/wcm/ear
>>> Its dependencies tree is horrible !
>>>
>>> I used : MAVEN_OPTS = -Xshare:auto -Xms128M -Xmx4G -XX:MaxPermSize=256M
>>> (In theory Xmx = 1G but I increased it to 4G to fix the OOME)
>>>
>>> To build it and reproduce the issue you need this repo : http://repository.exoplatform.org/public/ (releases & snapshots)
>>>
>>> I will try to open the debugger this WE if I find few minutes.
>>>
>>> On Aug 7, 2010, at 1:26 PM, Brett Porter wrote:
>>>
>>>>
>>>> On 07/08/2010, at 12:44 AM, Arnaud Héritier wrote:
>>>>
>>>>> The advantage is to do what I did this morning in few minutes.
>>>>> I found a OOME on Aether/Guice branch (reported to benjamin but not in MNG because it's not yet integrated) and then I validated it wasn't here in current trunk.
>>>>> The problem is that I had to rebuild both of them hat users won't do.
>>>>> Without the beta2 release, each time you'll have to check if the problem reported comes from Guice/Aether or from changes done for now in beta2.
>>>>> It is more for you who'll work on it to easily ask a comparison.
>>>>
>>>> I ran this over one of my builds out of curiosity. Not sure if this is helpful, but maybe some datapoints.
>>>>
>>>> 3.0-benjamin => 73m / 252m
>>>> 3.0-beta-1 => 63m / 159m
>>>> 2.2.1 => 129m / 252m
>>>>
>>>> Then I checked just the following:
>>>> 3.0-beta-2-SNAPSHOT + guice patch => 70m/218m
>>>> 3.0-beta-2-SNAPSHOT => 74m/252m
>>>>
>>>> The numbers are quite consistent, so it looks like the problem might have been on trunk here, not the guice++ branch. Arnaud, is that also what you see with trunk?
>>>>
>>>> I quickly ran the first two with Yourkit and saw that in Benjamin's branch, the memory grows faster at a consistent rate, but is still released at the end. The retained memory is only the classrealms and JDK ZIP cache, which basically is the same for beta-1. So more usage, but not a leak. No OOME, but perhaps the project is not big enough to exhibit it.
>>>>
>>>> Nothing to particularly note on the garbage collection front. The non-heap memory looks to be identical. Basically the same results running with a clean repository to do more artifact operations. Scanning the allocations, there's quite deep trees of allocations for Guice & the shim - but given the results for the other snapshots I'm not sure that's an issue itself.
>>>>
>>>> That's all I had time for, but I'll hold onto the snapshots in case they help.
>>>>
>>>> - Brett
>>>>
>>>> --
>>>> Brett Porter
>>>> brett@apache.org
>>>> http://brettporter.wordpress.com/
>>>>
>>>>
>>>>
>>>>
>>>>
>>>> ---------------------------------------------------------------------
>>>> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
>>>> For additional commands, e-mail: dev-help@maven.apache.org
>>>>
>>>
>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
>> For additional commands, e-mail: dev-help@maven.apache.org
>>
>
> Thanks,
>
> Jason
>
> ----------------------------------------------------------
> Jason van Zyl
> Founder, Apache Maven
> http://twitter.com/jvanzyl
> ---------------------------------------------------------
>
> Selfish deeds are the shortest path to self destruction.
>
> -- The Seven Samuari, Akira Kurosawa
>
>
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: guice & memory usage was: (3.0 beta 2/3/4 roadmap was Re: Merging in our Aether and Guice changes to Maven 3.x)
Posted by Jason van Zyl <ja...@sonatype.com>.
On Aug 18, 2010, at 1:43 PM, Arnaud Héritier wrote:
> Hi,
>
> I just rebuilt aether and maven3 and I have now : 14M/125M
> We are really near of 9M/125M we have in beta2
> Perfect !!!
>
> Let's go for a merge in trunk ??
>
Yup, let's merge it all in and move forward.
> Arnaud
>
> On Aug 7, 2010, at 2:37 PM, Arnaud Héritier wrote:
>
>> Results I had yesterday were :
>>
>> 3.0-benjamin (built yesterday) : 14M/2488M in 5:23.389s (It probably swapped a lot)
>> 3.0-beta-2 (downloaded few minutes ago) : 9M/125M built in 23.723s
>> 2.2.1 : 67M/136M built in 30s
>>
>> I only built one module : http://svn.exoplatform.org/projects/ecms/trunk/packaging/wcm/ear
>> Its dependencies tree is horrible !
>>
>> I used : MAVEN_OPTS = -Xshare:auto -Xms128M -Xmx4G -XX:MaxPermSize=256M
>> (In theory Xmx = 1G but I increased it to 4G to fix the OOME)
>>
>> To build it and reproduce the issue you need this repo : http://repository.exoplatform.org/public/ (releases & snapshots)
>>
>> I will try to open the debugger this WE if I find few minutes.
>>
>> On Aug 7, 2010, at 1:26 PM, Brett Porter wrote:
>>
>>>
>>> On 07/08/2010, at 12:44 AM, Arnaud Héritier wrote:
>>>
>>>> The advantage is to do what I did this morning in few minutes.
>>>> I found a OOME on Aether/Guice branch (reported to benjamin but not in MNG because it's not yet integrated) and then I validated it wasn't here in current trunk.
>>>> The problem is that I had to rebuild both of them hat users won't do.
>>>> Without the beta2 release, each time you'll have to check if the problem reported comes from Guice/Aether or from changes done for now in beta2.
>>>> It is more for you who'll work on it to easily ask a comparison.
>>>
>>> I ran this over one of my builds out of curiosity. Not sure if this is helpful, but maybe some datapoints.
>>>
>>> 3.0-benjamin => 73m / 252m
>>> 3.0-beta-1 => 63m / 159m
>>> 2.2.1 => 129m / 252m
>>>
>>> Then I checked just the following:
>>> 3.0-beta-2-SNAPSHOT + guice patch => 70m/218m
>>> 3.0-beta-2-SNAPSHOT => 74m/252m
>>>
>>> The numbers are quite consistent, so it looks like the problem might have been on trunk here, not the guice++ branch. Arnaud, is that also what you see with trunk?
>>>
>>> I quickly ran the first two with Yourkit and saw that in Benjamin's branch, the memory grows faster at a consistent rate, but is still released at the end. The retained memory is only the classrealms and JDK ZIP cache, which basically is the same for beta-1. So more usage, but not a leak. No OOME, but perhaps the project is not big enough to exhibit it.
>>>
>>> Nothing to particularly note on the garbage collection front. The non-heap memory looks to be identical. Basically the same results running with a clean repository to do more artifact operations. Scanning the allocations, there's quite deep trees of allocations for Guice & the shim - but given the results for the other snapshots I'm not sure that's an issue itself.
>>>
>>> That's all I had time for, but I'll hold onto the snapshots in case they help.
>>>
>>> - Brett
>>>
>>> --
>>> Brett Porter
>>> brett@apache.org
>>> http://brettporter.wordpress.com/
>>>
>>>
>>>
>>>
>>>
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
>>> For additional commands, e-mail: dev-help@maven.apache.org
>>>
>>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
>
Thanks,
Jason
----------------------------------------------------------
Jason van Zyl
Founder, Apache Maven
http://twitter.com/jvanzyl
---------------------------------------------------------
Selfish deeds are the shortest path to self destruction.
-- The Seven Samuari, Akira Kurosawa
Re: guice & memory usage was: (3.0 beta 2/3/4 roadmap was Re: Merging in our Aether and Guice changes to Maven 3.x)
Posted by Jason van Zyl <ja...@sonatype.com>.
So the plan is that we're going to do a release of spice-inject as fast as we can and then do the merge. So that will likely happen early next week. Until then folks can pick things up from Benjamin's branch:
http://github.com/bentmann/maven-3
On Aug 19, 2010, at 4:20 AM, Tamás Cservenák wrote:
> Cool!
>
> +1 for merges!
>
>
> Thanks,
> ~t~
>
> 2010/8/18 Arnaud Héritier <ah...@gmail.com>
>
>> Hi,
>>
>> I just rebuilt aether and maven3 and I have now : 14M/125M
>> We are really near of 9M/125M we have in beta2
>> Perfect !!!
>>
>> Let's go for a merge in trunk ??
>>
>> Arnaud
>>
>>
Thanks,
Jason
----------------------------------------------------------
Jason van Zyl
Founder, Apache Maven
http://twitter.com/jvanzyl
---------------------------------------------------------
the course of true love never did run smooth ...
-- Shakespeare
Re: guice & memory usage was: (3.0 beta 2/3/4 roadmap was Re: Merging
in our Aether and Guice changes to Maven 3.x)
Posted by Tamás Cservenák <ta...@cservenak.net>.
Cool!
+1 for merges!
Thanks,
~t~
2010/8/18 Arnaud Héritier <ah...@gmail.com>
> Hi,
>
> I just rebuilt aether and maven3 and I have now : 14M/125M
> We are really near of 9M/125M we have in beta2
> Perfect !!!
>
> Let's go for a merge in trunk ??
>
> Arnaud
>
>
Re: guice & memory usage was: (3.0 beta 2/3/4 roadmap was Re: Merging in our Aether and Guice changes to Maven 3.x)
Posted by Arnaud Héritier <ah...@gmail.com>.
Hi,
I just rebuilt aether and maven3 and I have now : 14M/125M
We are really near of 9M/125M we have in beta2
Perfect !!!
Let's go for a merge in trunk ??
Arnaud
On Aug 7, 2010, at 2:37 PM, Arnaud Héritier wrote:
> Results I had yesterday were :
>
> 3.0-benjamin (built yesterday) : 14M/2488M in 5:23.389s (It probably swapped a lot)
> 3.0-beta-2 (downloaded few minutes ago) : 9M/125M built in 23.723s
> 2.2.1 : 67M/136M built in 30s
>
> I only built one module : http://svn.exoplatform.org/projects/ecms/trunk/packaging/wcm/ear
> Its dependencies tree is horrible !
>
> I used : MAVEN_OPTS = -Xshare:auto -Xms128M -Xmx4G -XX:MaxPermSize=256M
> (In theory Xmx = 1G but I increased it to 4G to fix the OOME)
>
> To build it and reproduce the issue you need this repo : http://repository.exoplatform.org/public/ (releases & snapshots)
>
> I will try to open the debugger this WE if I find few minutes.
>
> On Aug 7, 2010, at 1:26 PM, Brett Porter wrote:
>
>>
>> On 07/08/2010, at 12:44 AM, Arnaud Héritier wrote:
>>
>>> The advantage is to do what I did this morning in few minutes.
>>> I found a OOME on Aether/Guice branch (reported to benjamin but not in MNG because it's not yet integrated) and then I validated it wasn't here in current trunk.
>>> The problem is that I had to rebuild both of them hat users won't do.
>>> Without the beta2 release, each time you'll have to check if the problem reported comes from Guice/Aether or from changes done for now in beta2.
>>> It is more for you who'll work on it to easily ask a comparison.
>>
>> I ran this over one of my builds out of curiosity. Not sure if this is helpful, but maybe some datapoints.
>>
>> 3.0-benjamin => 73m / 252m
>> 3.0-beta-1 => 63m / 159m
>> 2.2.1 => 129m / 252m
>>
>> Then I checked just the following:
>> 3.0-beta-2-SNAPSHOT + guice patch => 70m/218m
>> 3.0-beta-2-SNAPSHOT => 74m/252m
>>
>> The numbers are quite consistent, so it looks like the problem might have been on trunk here, not the guice++ branch. Arnaud, is that also what you see with trunk?
>>
>> I quickly ran the first two with Yourkit and saw that in Benjamin's branch, the memory grows faster at a consistent rate, but is still released at the end. The retained memory is only the classrealms and JDK ZIP cache, which basically is the same for beta-1. So more usage, but not a leak. No OOME, but perhaps the project is not big enough to exhibit it.
>>
>> Nothing to particularly note on the garbage collection front. The non-heap memory looks to be identical. Basically the same results running with a clean repository to do more artifact operations. Scanning the allocations, there's quite deep trees of allocations for Guice & the shim - but given the results for the other snapshots I'm not sure that's an issue itself.
>>
>> That's all I had time for, but I'll hold onto the snapshots in case they help.
>>
>> - Brett
>>
>> --
>> Brett Porter
>> brett@apache.org
>> http://brettporter.wordpress.com/
>>
>>
>>
>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
>> For additional commands, e-mail: dev-help@maven.apache.org
>>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
RE: guice & memory usage was: (3.0 beta 2/3/4 roadmap was Re:
Merging in our Aether and Guice changes to Maven 3.x)
Posted by "Nord, James" <JN...@nds.com>.
>>
>> There's been little to no feedback on beta-2 so I honestly don't think it
>> matters.
> feedback from Maven developers was good: since people complain only when it
> does not work, I suppose no feedback = it works as good as for Maven
> developers.
>
I agree, I consider also the no feedback as good feedback because when it doesn't work we quickly have bad feedbacks.
[JN] An alternate reason is most people are on holiday in the northern hemisphere (at least it is a quiet time in Europe!)
**************************************************************************************
This message is confidential and intended only for the addressee. If you have received this message in error, please immediately notify the postmaster@nds.com and delete it from your system as well as any copies. The content of e-mails as well as traffic data may be monitored by NDS for employment and security purposes. To protect the environment please do not print this e-mail unless necessary.
NDS Limited. Registered Office: One London Road, Staines, Middlesex, TW18 4EX, United Kingdom. A company registered in England and Wales. Registered no. 3080780. VAT no. GB 603 8808 40-00
**************************************************************************************
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: guice & memory usage was: (3.0 beta 2/3/4 roadmap was Re: Merging in our Aether and Guice changes to Maven 3.x)
Posted by Arnaud Héritier <ah...@gmail.com>.
On Aug 18, 2010, at 10:47 PM, Hervé BOUTEMY wrote:
> Le mercredi 18 août 2010, Jason van Zyl a écrit :
>> On Aug 18, 2010, at 12:59 PM, Hervé BOUTEMY wrote:
>>> Le mercredi 18 août 2010, Arnaud Héritier a écrit :
>>>> It's always in GitHub or the merge started in trunk ?
>>>
>>> BTW, we have 3.0-beta-2 released without Guice nor Aether and GitHub with
>>> both Guice and Aether.
>>> What about merging Guice in svn trunk, so we can test the 3 major steps:
>>> 3.0- beta-2, +Guice, +Aether?
>>
>> There's been little to no feedback on beta-2 so I honestly don't think it
>> matters.
> feedback from Maven developers was good: since people complain only when it
> does not work, I suppose no feedback = it works as good as for Maven
> developers.
>
I agree, I consider also the no feedback as good feedback because when it doesn't work we quickly have bad feedbacks.
>> Put everything in that we plan ship and release it. If you want
>> an incremental build that is separate that's probably fine to make
>> comparisons easier,
> yes, that's the idea.
>
>> but the world at large doesn't care.
> it's august, a lot of people are on vacation.
> I suppose there will can be more feedback in september.
I'm now enough confident in benjamin's branch to merge 2 patchs quickly in trunk and push out a beta 3
>
>>
>> Let's merge it all in, try and get 3.0 out the door.
> we're all impatient
YEAHHHH
>
> Regards,
>
> Hervé
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: guice & memory usage was: (3.0 beta 2/3/4 roadmap was Re: Merging in our Aether and Guice changes to Maven 3.x)
Posted by Hervé BOUTEMY <he...@free.fr>.
Le mercredi 18 août 2010, Jason van Zyl a écrit :
> On Aug 18, 2010, at 12:59 PM, Hervé BOUTEMY wrote:
> > Le mercredi 18 août 2010, Arnaud Héritier a écrit :
> >> It's always in GitHub or the merge started in trunk ?
> >
> > BTW, we have 3.0-beta-2 released without Guice nor Aether and GitHub with
> > both Guice and Aether.
> > What about merging Guice in svn trunk, so we can test the 3 major steps:
> > 3.0- beta-2, +Guice, +Aether?
>
> There's been little to no feedback on beta-2 so I honestly don't think it
> matters.
feedback from Maven developers was good: since people complain only when it
does not work, I suppose no feedback = it works as good as for Maven
developers.
> Put everything in that we plan ship and release it. If you want
> an incremental build that is separate that's probably fine to make
> comparisons easier,
yes, that's the idea.
> but the world at large doesn't care.
it's august, a lot of people are on vacation.
I suppose there will can be more feedback in september.
>
> Let's merge it all in, try and get 3.0 out the door.
we're all impatient
Regards,
Hervé
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: guice & memory usage was: (3.0 beta 2/3/4 roadmap was Re: Merging
in our Aether and Guice changes to Maven 3.x)
Posted by Jochen Wiedmann <jo...@gmail.com>.
On Wed, Aug 18, 2010 at 10:10 PM, Jason van Zyl <ja...@sonatype.com> wrote:
> There's been little to no feedback on beta-2 so I honestly don't think it matters.
That's good news, isn't it? :-)
--
I Am What I Am And That's All What I Yam (Popeye)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: guice & memory usage was: (3.0 beta 2/3/4 roadmap was Re: Merging
in our Aether and Guice changes to Maven 3.x)
Posted by Mark Derricutt <ma...@talios.com>.
I'd love to offer more feedback on beta-2, but since it totally breaks our
builds it's a non-starter. Without reworking our entire build setup ( which
we're going to do anyway when we move to git ) M3 is effectively unusable
for my main $work project.
Which is a shame as all the new things look great.
--
Pull me down under...
On Thu, Aug 19, 2010 at 8:10 AM, Jason van Zyl <ja...@sonatype.com> wrote:
> There's been little to no feedback on beta-2 so I honestly don't think it
> matters. Put everything in that we plan ship and release it. If you want an
> incremental build that is separate that's probably fine to make comparisons
> easier, but the world at large doesn't care.
Re: guice & memory usage was: (3.0 beta 2/3/4 roadmap was Re: Merging in our Aether and Guice changes to Maven 3.x)
Posted by Jason van Zyl <ja...@sonatype.com>.
On Aug 18, 2010, at 12:59 PM, Hervé BOUTEMY wrote:
> Le mercredi 18 août 2010, Arnaud Héritier a écrit :
>> It's always in GitHub or the merge started in trunk ?
> BTW, we have 3.0-beta-2 released without Guice nor Aether and GitHub with both
> Guice and Aether.
> What about merging Guice in svn trunk, so we can test the 3 major steps: 3.0-
> beta-2, +Guice, +Aether?
>
There's been little to no feedback on beta-2 so I honestly don't think it matters. Put everything in that we plan ship and release it. If you want an incremental build that is separate that's probably fine to make comparisons easier, but the world at large doesn't care.
Let's merge it all in, try and get 3.0 out the door.
> Regards,
>
> Hervé
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
>
Thanks,
Jason
----------------------------------------------------------
Jason van Zyl
Founder, Apache Maven
http://twitter.com/jvanzyl
---------------------------------------------------------
People develop abstractions by generalizing from concrete examples.
Every attempt to determine the correct abstraction on paper without
actually developing a running system is doomed to failure. No one
is that smart. A framework is a resuable design, so you develop it by
looking at the things it is supposed to be a design of. The more examples
you look at, the more general your framework will be.
-- Ralph Johnson & Don Roberts, Patterns for Evolving Frameworks
Re: guice & memory usage was: (3.0 beta 2/3/4 roadmap was Re: Merging in our Aether and Guice changes to Maven 3.x)
Posted by Hervé BOUTEMY <he...@free.fr>.
Le mercredi 18 août 2010, Arnaud Héritier a écrit :
> It's always in GitHub or the merge started in trunk ?
BTW, we have 3.0-beta-2 released without Guice nor Aether and GitHub with both
Guice and Aether.
What about merging Guice in svn trunk, so we can test the 3 major steps: 3.0-
beta-2, +Guice, +Aether?
Regards,
Hervé
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: guice & memory usage was: (3.0 beta 2/3/4 roadmap was Re: Merging
in our Aether and Guice changes to Maven 3.x)
Posted by Benjamin Bentmann <be...@udo.edu>.
Arnaud Héritier wrote:
> It's always in GitHub or the merge started in trunk ?
It's still in github.
> I'll try to build and test it this evening.
Cool, thanks!
Benjamin
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: guice & memory usage was: (3.0 beta 2/3/4 roadmap was Re: Merging in our Aether and Guice changes to Maven 3.x)
Posted by Arnaud Héritier <ah...@gmail.com>.
It's always in GitHub or the merge started in trunk ?
I'll try to build and test it this evening.
Thx
On Aug 18, 2010, at 1:59 PM, Benjamin Bentmann wrote:
> Arnaud Héritier wrote:
>
>> 3.0-benjamin (built yesterday) : 14M/2488M in 5:23.389s (It probably swapped a lot)
>
> Should be fixed now, would be cool if you could double-check when time allows.
>
>
> Benjamin
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: guice & memory usage was: (3.0 beta 2/3/4 roadmap was Re: Merging
in our Aether and Guice changes to Maven 3.x)
Posted by Benjamin Bentmann <be...@udo.edu>.
Arnaud Héritier wrote:
> 3.0-benjamin (built yesterday) : 14M/2488M in 5:23.389s (It probably swapped a lot)
Should be fixed now, would be cool if you could double-check when time
allows.
Benjamin
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: guice & memory usage was: (3.0 beta 2/3/4 roadmap was Re: Merging in our Aether and Guice changes to Maven 3.x)
Posted by Arnaud Héritier <ah...@gmail.com>.
Results I had yesterday were :
3.0-benjamin (built yesterday) : 14M/2488M in 5:23.389s (It probably swapped a lot)
3.0-beta-2 (downloaded few minutes ago) : 9M/125M built in 23.723s
2.2.1 : 67M/136M built in 30s
I only built one module : http://svn.exoplatform.org/projects/ecms/trunk/packaging/wcm/ear
Its dependencies tree is horrible !
I used : MAVEN_OPTS = -Xshare:auto -Xms128M -Xmx4G -XX:MaxPermSize=256M
(In theory Xmx = 1G but I increased it to 4G to fix the OOME)
To build it and reproduce the issue you need this repo : http://repository.exoplatform.org/public/ (releases & snapshots)
I will try to open the debugger this WE if I find few minutes.
On Aug 7, 2010, at 1:26 PM, Brett Porter wrote:
>
> On 07/08/2010, at 12:44 AM, Arnaud Héritier wrote:
>
>> The advantage is to do what I did this morning in few minutes.
>> I found a OOME on Aether/Guice branch (reported to benjamin but not in MNG because it's not yet integrated) and then I validated it wasn't here in current trunk.
>> The problem is that I had to rebuild both of them hat users won't do.
>> Without the beta2 release, each time you'll have to check if the problem reported comes from Guice/Aether or from changes done for now in beta2.
>> It is more for you who'll work on it to easily ask a comparison.
>
> I ran this over one of my builds out of curiosity. Not sure if this is helpful, but maybe some datapoints.
>
> 3.0-benjamin => 73m / 252m
> 3.0-beta-1 => 63m / 159m
> 2.2.1 => 129m / 252m
>
> Then I checked just the following:
> 3.0-beta-2-SNAPSHOT + guice patch => 70m/218m
> 3.0-beta-2-SNAPSHOT => 74m/252m
>
> The numbers are quite consistent, so it looks like the problem might have been on trunk here, not the guice++ branch. Arnaud, is that also what you see with trunk?
>
> I quickly ran the first two with Yourkit and saw that in Benjamin's branch, the memory grows faster at a consistent rate, but is still released at the end. The retained memory is only the classrealms and JDK ZIP cache, which basically is the same for beta-1. So more usage, but not a leak. No OOME, but perhaps the project is not big enough to exhibit it.
>
> Nothing to particularly note on the garbage collection front. The non-heap memory looks to be identical. Basically the same results running with a clean repository to do more artifact operations. Scanning the allocations, there's quite deep trees of allocations for Guice & the shim - but given the results for the other snapshots I'm not sure that's an issue itself.
>
> That's all I had time for, but I'll hold onto the snapshots in case they help.
>
> - Brett
>
> --
> Brett Porter
> brett@apache.org
> http://brettporter.wordpress.com/
>
>
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: guice & memory usage was: (3.0 beta 2/3/4 roadmap was Re: Merging in our Aether and Guice changes to Maven 3.x)
Posted by Jason van Zyl <ja...@sonatype.com>.
On Aug 7, 2010, at 7:26 AM, Brett Porter wrote:
>
> On 07/08/2010, at 12:44 AM, Arnaud Héritier wrote:
>
>> The advantage is to do what I did this morning in few minutes.
>> I found a OOME on Aether/Guice branch (reported to benjamin but not in MNG because it's not yet integrated) and then I validated it wasn't here in current trunk.
>> The problem is that I had to rebuild both of them hat users won't do.
>> Without the beta2 release, each time you'll have to check if the problem reported comes from Guice/Aether or from changes done for now in beta2.
>> It is more for you who'll work on it to easily ask a comparison.
>
> I ran this over one of my builds out of curiosity. Not sure if this is helpful, but maybe some datapoints.
>
> 3.0-benjamin => 73m / 252m
> 3.0-beta-1 => 63m / 159m
> 2.2.1 => 129m / 252m
>
> Then I checked just the following:
> 3.0-beta-2-SNAPSHOT + guice patch => 70m/218m
> 3.0-beta-2-SNAPSHOT => 74m/252m
>
> The numbers are quite consistent, so it looks like the problem might have been on trunk here, not the guice++ branch. Arnaud, is that also what you see with trunk?
>
> I quickly ran the first two with Yourkit and saw that in Benjamin's branch, the memory grows faster at a consistent rate, but is still released at the end. The retained memory is only the classrealms and JDK ZIP cache, which basically is the same for beta-1. So more usage, but not a leak. No OOME, but perhaps the project is not big enough to exhibit it.
>
> Nothing to particularly note on the garbage collection front. The non-heap memory looks to be identical. Basically the same results running with a clean repository to do more artifact operations. Scanning the allocations, there's quite deep trees of allocations for Guice & the shim - but given the results for the other snapshots I'm not sure that's an issue itself.
>
Yes, we believe there are no GC or leakage issues with the Aether it is the dirty tree which is memory intensive and it's that structure we are trying to compact. The performance framework found the intense memory use instantly. It was reduced and now we're thinking of trying to use a graph structure for the dirty tree. We're not sure if this will work or not yet.
> That's all I had time for, but I'll hold onto the snapshots in case they help.
>
> - Brett
>
> --
> Brett Porter
> brett@apache.org
> http://brettporter.wordpress.com/
>
>
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
>
Thanks,
Jason
----------------------------------------------------------
Jason van Zyl
Founder, Apache Maven
http://twitter.com/jvanzyl
---------------------------------------------------------
Three people can keep a secret provided two of them are dead.
-- Unknown