You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2022/07/26 20:02:56 UTC
[GitHub] [beam-starter-kotlin] davidcavazos opened a new pull request, #1: Initial commit
davidcavazos opened a new pull request, #1:
URL: https://github.com/apache/beam-starter-kotlin/pull/1
Initial commit for the Beam Kotlin starter project.
R: @aaltay can you help us find reviewers for Kotlin? Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam-starter-kotlin] brucearctor commented on pull request #1: Initial commit
Posted by GitBox <gi...@apache.org>.
brucearctor commented on PR #1:
URL: https://github.com/apache/beam-starter-kotlin/pull/1#issuecomment-1195982824
Potentially check for the authors of: https://github.com/apache/beam/tree/master/learning/katas/kotlin
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam-starter-kotlin] tosun-si commented on pull request #1: Initial commit
Posted by GitBox <gi...@apache.org>.
tosun-si commented on PR #1:
URL: https://github.com/apache/beam-starter-kotlin/pull/1#issuecomment-1210979014
@brucearctor OK I understand, I was wrong in my analysis, only the Maven Archetype generates a project with a Maven pom.xml file :
```shell
mvn archetype:generate \
-DarchetypeGroupId=org.apache.beam \
-DarchetypeArtifactId=beam-sdks-java-maven-archetypes-examples \
-DarchetypeVersion=2.40.0 \
-DgroupId=org.example \
-DartifactId=word-count-beam \
-Dversion="0.1" \
-Dpackage=org.apache.beam.examples \
-DinteractiveMode=false
```
In this case, Gradle is the good choice :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam-starter-kotlin] brucearctor commented on pull request #1: Initial commit
Posted by GitBox <gi...@apache.org>.
brucearctor commented on PR #1:
URL: https://github.com/apache/beam-starter-kotlin/pull/1#issuecomment-1195983385
and, @tosun-si was talking much about kotlin at BeamSummit so he might be able to review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam-starter-kotlin] tosun-si commented on a diff in pull request #1: Initial commit
Posted by GitBox <gi...@apache.org>.
tosun-si commented on code in PR #1:
URL: https://github.com/apache/beam-starter-kotlin/pull/1#discussion_r930485511
##########
app/src/test/kotlin/beam/starter/AppTest.kt:
##########
@@ -0,0 +1,28 @@
+// Copyright 2022 Google LLC
+//
+// Licensed under the Apache License, Version 2.0 <LICENSE-APACHE or
+// https://www.apache.org/licenses/LICENSE-2.0> or the MIT license
+// <LICENSE-MIT or https://opensource.org/licenses/MIT>, at your
+// option. This file may not be copied, modified, or distributed
+// except according to those terms.
+
+package beam.starter
+
+import org.apache.beam.sdk.testing.PAssert
+import org.apache.beam.sdk.testing.TestPipeline
+import org.junit.Rule
Review Comment:
For my example presented in Beam Summit, I also used `TestPipeline` with a Junit 4 `@Rule` :
https://github.com/tosun-si/teams-league-kotlin-dlq-asgarde-beam-summit/blob/main/src/test/kotlin/fr/groupbees/domain_ptransform/TeamStatsTransformTest.kt
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam-starter-kotlin] kennknowles commented on a diff in pull request #1: Initial commit
Posted by GitBox <gi...@apache.org>.
kennknowles commented on code in PR #1:
URL: https://github.com/apache/beam-starter-kotlin/pull/1#discussion_r930419089
##########
app/src/test/kotlin/beam/starter/AppTest.kt:
##########
@@ -0,0 +1,28 @@
+// Copyright 2022 Google LLC
+//
+// Licensed under the Apache License, Version 2.0 <LICENSE-APACHE or
+// https://www.apache.org/licenses/LICENSE-2.0> or the MIT license
+// <LICENSE-MIT or https://opensource.org/licenses/MIT>, at your
+// option. This file may not be copied, modified, or distributed
+// except according to those terms.
+
+package beam.starter
+
+import org.apache.beam.sdk.testing.PAssert
+import org.apache.beam.sdk.testing.TestPipeline
+import org.junit.Rule
Review Comment:
Is junit idiomatic for Kotlin?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam-starter-kotlin] davidcavazos commented on pull request #1: Initial commit
Posted by GitBox <gi...@apache.org>.
davidcavazos commented on PR #1:
URL: https://github.com/apache/beam-starter-kotlin/pull/1#issuecomment-1209625576
Hi @tosun-si, I made the test pipeline transient like in your example. Other than that, please let me know if there are any other changes you recommend. Do the Gradle build files look good?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam-starter-kotlin] tosun-si commented on pull request #1: Initial commit
Posted by GitBox <gi...@apache.org>.
tosun-si commented on PR #1:
URL: https://github.com/apache/beam-starter-kotlin/pull/1#issuecomment-1210958720
Hi @davidcavazos, thanks.
I have a little question, why Gradle was chosen instead of Maven for this starter. Gradle is good but I more thought about Maven to be homogeneous with the Beam Java starter. What do you think about that ?
If you prefer to keep Gradle, it's ok for me too :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam-starter-kotlin] tosun-si commented on pull request #1: Initial commit
Posted by GitBox <gi...@apache.org>.
tosun-si commented on PR #1:
URL: https://github.com/apache/beam-starter-kotlin/pull/1#issuecomment-1196061439
Ok I am going to review the code tomorrow 👍🏻
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam-starter-kotlin] tosun-si commented on pull request #1: Initial commit
Posted by GitBox <gi...@apache.org>.
tosun-si commented on PR #1:
URL: https://github.com/apache/beam-starter-kotlin/pull/1#issuecomment-1210995803
Everything is good for me.
Maybe in the future we can add more examples, but for a first version it's ok and very good.
Thanks @brucearctor
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam-starter-kotlin] brucearctor commented on pull request #1: Initial commit
Posted by GitBox <gi...@apache.org>.
brucearctor commented on PR #1:
URL: https://github.com/apache/beam-starter-kotlin/pull/1#issuecomment-1210987199
for most, they should be interchangeable :-)
Specifically we are considering you ( @tosun-si ) to be the Kotlin expert on this thread, and this is a Kotlin example. Anything else stand out as suggested/needing to change?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam-starter-kotlin] brucearctor commented on pull request #1: Initial commit
Posted by GitBox <gi...@apache.org>.
brucearctor commented on PR #1:
URL: https://github.com/apache/beam-starter-kotlin/pull/1#issuecomment-1210968001
Beam https://github.com/apache/beam relies on Gradle
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam-starter-kotlin] brucearctor merged pull request #1: Initial commit
Posted by GitBox <gi...@apache.org>.
brucearctor merged PR #1:
URL: https://github.com/apache/beam-starter-kotlin/pull/1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam-starter-kotlin] tosun-si commented on a diff in pull request #1: Initial commit
Posted by GitBox <gi...@apache.org>.
tosun-si commented on code in PR #1:
URL: https://github.com/apache/beam-starter-kotlin/pull/1#discussion_r930497318
##########
app/build.gradle.kts:
##########
@@ -0,0 +1,48 @@
+/*
+ * This file was generated by the Gradle 'init' task.
+ *
+ * This generated file contains a sample Kotlin application project to get you started.
+ * For more details take a look at the 'Building Java & JVM projects' chapter in the Gradle
+ * User Manual available at https://docs.gradle.org/7.2/userguide/building_java_projects.html
+ */
+
+plugins {
Review Comment:
I have a little question, why Gradle was chosen instead of Maven for this starter. Gradle is good but I more thought about Maven to be homogeneous with the Beam Java starter. What do you think about that ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam-starter-kotlin] aaltay commented on pull request #1: Initial commit
Posted by GitBox <gi...@apache.org>.
aaltay commented on PR #1:
URL: https://github.com/apache/beam-starter-kotlin/pull/1#issuecomment-1195980789
I do not know who would be a good kotlin reviewer. Could you email the team? (Or reach out to @kennknowles )
I can rubber stamp this if (i) you verified it AND (ii) we cannot find any Kotlin reviewers. Let me know.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam-starter-kotlin] davidcavazos commented on a diff in pull request #1: Initial commit
Posted by GitBox <gi...@apache.org>.
davidcavazos commented on code in PR #1:
URL: https://github.com/apache/beam-starter-kotlin/pull/1#discussion_r930444621
##########
app/src/test/kotlin/beam/starter/AppTest.kt:
##########
@@ -0,0 +1,28 @@
+// Copyright 2022 Google LLC
+//
+// Licensed under the Apache License, Version 2.0 <LICENSE-APACHE or
+// https://www.apache.org/licenses/LICENSE-2.0> or the MIT license
+// <LICENSE-MIT or https://opensource.org/licenses/MIT>, at your
+// option. This file may not be copied, modified, or distributed
+// except according to those terms.
+
+package beam.starter
+
+import org.apache.beam.sdk.testing.PAssert
+import org.apache.beam.sdk.testing.TestPipeline
+import org.junit.Rule
Review Comment:
If we want to use `TestPipeline` it has to be a `@Rule` which is only supported on JUnit 4 (JUnit 5 is not supported). I guess we could use a "normal" pipeline and use Kotlin's tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org