You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@uniffle.apache.org by "zuston (via GitHub)" <gi...@apache.org> on 2025/06/24 07:05:46 UTC

[PR] [#2518] fix(client): Disable fast fail on any pushing failure if partition reassign is activated [uniffle]

zuston opened a new pull request, #2519:
URL: https://github.com/apache/uniffle/pull/2519

   ### What changes were proposed in this pull request?
   
   Disable fast fail on any pushing failure if partition reassign is activated
   
   ### Why are the changes needed?
   
   Before this PR, if multi-replica is disabled, the sending logic would fail fast upon any push failure.
   However, when partition reassignment is enabled, this behavior could cause some block futures to be canceled, leading to the loss of block sending events.
   As a result, the client might fail due to unsent remaining blocks.
   
   for #2518
   
   ### Does this PR introduce _any_ user-facing change?
   
   No.
   
   ### How was this patch tested?
   
   Needn't. This could be quickly validated by human.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org


Re: [PR] [#2518] fix(client): Disable fast fail on any pushing failure if partition reassign is activated [uniffle]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #2519:
URL: https://github.com/apache/uniffle/pull/2519#issuecomment-2999159255

   ## Test Results
    3 049 files  ±0   3 049 suites  ±0   6h 47m 58s ⏱️ -45s
    1 186 tests ±0   1 185 ✅ ±0   1 💤 ±0  0 ❌ ±0 
   15 042 runs  ±0  15 027 ✅ ±0  15 💤 ±0  0 ❌ ±0 
   
   Results for commit 61dca3c9. ± Comparison against base commit 907e6252.
   
   [test-results]:data:application/gzip;base64,H4sIAJ1UWmgC/03MTQ6DIBCG4asY1l3wNwi9TIOjJKQqDcKq6d2LFqnL75nJ+ybOz9NG7p2g0tw6smWfrnvM0SYf1iJcyl4XKve0fzCm1TkfW0b8Gfzt6V+7NXDWzwVogynGEKvEvB5VoJLX2apAed+sVuGES/XY1yiGZfGpDKLYiFagsU4DDkYwhQa0tQiCcxx0MdpLRsnnC0YnDE0UAQAA
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org


Re: [PR] [#2518] fix(client): Disable fast fail on any pushing failure if partition reassign is activated [uniffle]

Posted by "zuston (via GitHub)" <gi...@apache.org>.
zuston merged PR #2519:
URL: https://github.com/apache/uniffle/pull/2519


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org