[jira] [Created] (CRUNCH-183) Reservoir sampling functions don't take object reuse into account

["Gabriel Reid (JIRA)" <ji...@apache.org>]

Gabriel Reid created CRUNCH-183:
-----------------------------------

             Summary: Reservoir sampling functions don't take object reuse into account
                 Key: CRUNCH-183
                 URL: https://issues.apache.org/jira/browse/CRUNCH-183
             Project: Crunch
          Issue Type: Bug
            Reporter: Gabriel Reid


ReservoirSampleFn and WRSCombineFn in o.a.c.lib.SampleUtils both hold onto references of processed values, but don't make deep copies of them. For complex objects such as Avro objects, this leads to incorrect results, with the same value being returned for all samples.

This can be resolved by making use of PType#getDetachedValue before storing a reference to the object.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira