You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@flex.apache.org by Peter Ent <pe...@adobe.com> on 2017/03/21 21:49:02 UTC
[FlexJS] Container and Layout Progress
Hi,
I'm am making progress toward simplifying the JS output generated from the components. I should be making a commit either tomorrow or the next day. There will be some things not working 100% correctly, mostly because they need to be tuned to use the new layouts or are making assumptions about positioning which have changed.
I've made changes to Group (which as my most recent commit), Container, List, Panel, etc. because they depend on some base work. I've also changed some of the SWF-side algorithms for layout and greatly simplified the HTML/JS versions of those layouts.
I've tested some of the examples and have fixed components that needed tuning. For example, the DateChooser is now a Group with three main parts and it uses VerticalFlexLayout to size and position those parts. The button header and days-of-week list use HorizontalFlexLayout. Panel is now a Group and it, too, uses VerticalFlexLayout to position the title bar and Container content area. So it has been a bit of time using those components to expose some short-coming in the layout code. I also had to go back and re-think how all of these parts fit together and behave on the Flash and HTML platforms.
I want to produce a before-and-after snapshot of some HTML so show you the differences and I will produce that tomorrow. Then I have to merge my changes into the develop branch.
I have only touched Core and HTML framework projects, but some of the other projects (like Charts) depend on these and I want to assess them before going further.
Regards,
Peter
Re: [FlexJS] Container and Layout Progress
Posted by piotrz <pi...@gmail.com>.
Hi Peter,
+1 for commit, than fix Charts.
Piotr
-----
Apache Flex PMC
piotrzarzycki21@gmail.com
--
View this message in context: http://apache-flex-development.2333347.n4.nabble.com/FlexJS-Container-and-Layout-Progress-tp60658p60672.html
Sent from the Apache Flex Development mailing list archive at Nabble.com.
Re: [FlexJS] Container and Layout Progress
Posted by Peter Ent <pe...@adobe.com>.
Things should build now. Charts will not work yet, but MDL example (at
least one) now runs for me.
‹peter
On 3/24/17, 2:58 AM, "Christofer Dutz" <ch...@c-ware.de> wrote:
>Hi Guys,
>
>Well I am expecting to be able to build develop Š if there are changes
>that break things, these belong in a feature branch until they are sorted
>out and merged to develop as soon as things are finished. Now please fix
>the things that are broken in develop this time, but make sure to use
>feature-branches in the future Š would that be ok?
>
>I currently don¹t need this to build as I am full with other things, I¹m
>just keeping an eye on the build itself.
>
>Chris
>
>
>Am 23.03.17, 18:12 schrieb "piotrz" <pi...@gmail.com>:
>
> But it was expected. I can help with MDL if you will need. Just let
>me know.
>
> If fixes will be today, there is no point to revert anything.
>
> Piotr
>
>
>
> -----
> Apache Flex PMC
> piotrzarzycki21@gmail.com
> --
> View this message in context:
>https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fapache-fle
>x-development.2333347.n4.nabble.com%2FFlexJS-Container-and-Layout-Progress
>-tp60658p60701.html&data=02%7C01%7C%7Cec8aa6f03a6d4c49fa0608d472832f81%7Cf
>a7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636259355160234851&sdata=vK9jS2s
>SWjR4zHpvXqPnmWpvJgU%2FWOTB5A1o5S3QNSY%3D&reserved=0
> Sent from the Apache Flex Development mailing list archive at
>Nabble.com.
>
>
Re: [FlexJS] Container and Layout Progress
Posted by Christofer Dutz <ch...@c-ware.de>.
Hi Guys,
Well I am expecting to be able to build develop … if there are changes that break things, these belong in a feature branch until they are sorted out and merged to develop as soon as things are finished. Now please fix the things that are broken in develop this time, but make sure to use feature-branches in the future … would that be ok?
I currently don’t need this to build as I am full with other things, I’m just keeping an eye on the build itself.
Chris
Am 23.03.17, 18:12 schrieb "piotrz" <pi...@gmail.com>:
But it was expected. I can help with MDL if you will need. Just let me know.
If fixes will be today, there is no point to revert anything.
Piotr
-----
Apache Flex PMC
piotrzarzycki21@gmail.com
--
View this message in context: http://apache-flex-development.2333347.n4.nabble.com/FlexJS-Container-and-Layout-Progress-tp60658p60701.html
Sent from the Apache Flex Development mailing list archive at Nabble.com.
Re: [FlexJS] Container and Layout Progress
Posted by piotrz <pi...@gmail.com>.
But it was expected. I can help with MDL if you will need. Just let me know.
If fixes will be today, there is no point to revert anything.
Piotr
-----
Apache Flex PMC
piotrzarzycki21@gmail.com
--
View this message in context: http://apache-flex-development.2333347.n4.nabble.com/FlexJS-Container-and-Layout-Progress-tp60658p60701.html
Sent from the Apache Flex Development mailing list archive at Nabble.com.
Re: [FlexJS] Container and Layout Progress
Posted by Peter Ent <pe...@adobe.com>.
I should have committed a change to the build to exclude charts. Hmm.
Peter
> On Mar 23, 2017, at 12:57 PM, Christofer Dutz <ch...@c-ware.de> wrote:
>
> Well I guess things are broken now (
>
> I just updated and ran a new build and Charts is exploding at the moment …
>
> Chris
>
>
>
> Am 23.03.17, 17:02 schrieb "Peter Ent" <pe...@adobe.com>:
>
> Hi,
>
> I've committed the changes!! The build should skip, MDL, Charts, and Basic
> projects. I will get MDL and Charts running next. But before that, I will
> have an email out with a breakdown of the changes I've made. Look for that
> in the next couple of hours.
>
> Good luck! Please let me know what breaks. I will tell you that the
> biggest difference is the UIBase no longer sets position style so any
> elements you have that require positioning via x,y, will need to use a
> Group or Container that has the BasicLayout.
>
> Regards,
> Peter
>
>> On 3/22/17, 5:02 PM, "Peter Ent" <pe...@adobe.com> wrote:
>>
>> Update: I'm 99% ready to commit. I will do this tomorrow morning, my time.
>> I've spent today fixing some last issues in HTML package, while cosmetic,
>> just didn't make things look too good. There are a couple more but I'll do
>> them later.
>>
>> I did a local merge of the latest FlexJS code and my changes and rebuilt
>> flex-asjs. The Basic and Charts packages I expected to have issues. I'm
>> not sure if I should even bother with Basic, just let me know. I have
>> commented Charts from the build.xml so it will not cause the main build to
>> fail.
>>
>> The other project is MDL. I will also comment that from the build and will
>> work on that after I make the commit and push. The issue is that I changed
>> a couple of interfaces in Core and replaced one interface with another. I
>> just have to sync them up. Hopefully it will not take more than a day.
>>
>> If you prefer I do MDL before doing the commit, please let me know in the
>> next 12-14 hours.
>>
>> Thanks,
>> Peter
>>
>>> On 3/22/17, 10:56 AM, "Harbs" <ha...@gmail.com> wrote:
>>>
>>> Yes. Commit.
>>>
>>> Right now we need to use an earlier version because the current status is
>>> broken.
>>>
>>>> On Mar 22, 2017, at 4:37 PM, OK <po...@olafkrueger.net> wrote:
>>>>
>>>> In case if something is broken for somebody maybe one option is to just
>>>> check
>>>> out a previous revision by using the particular commit hash?
>>>>
>>>> Olaf
>>>>
>>>>
>>>>
>>>> --
>>>> View this message in context:
>>>> https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fapache-f
>>>> l
>>>> ex-development.2333347.n4.nabble.com%2FFlexJS-Container-and-Layout-Progr
>>>> e
>>>> ss-tp60658p60673.html&data=02%7C01%7C%7C82a3a0f402a943fbc3fa08d47133951f
>>>> %
>>>> 7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636257913736732760&sdata=hS
>>>> A
>>>> %2FIskqdzlbteHnTLr9pZwSE5Kk%2Fer9cb%2FUTJeMrZ8%3D&reserved=0
>>>> Sent from the Apache Flex Development mailing list archive at
>>>> Nabble.com.
>>>
>>
>
>
>
Re: [FlexJS] Container and Layout Progress
Posted by Christofer Dutz <ch...@c-ware.de>.
Well I guess things are broken now (
I just updated and ran a new build and Charts is exploding at the moment …
Chris
Am 23.03.17, 17:02 schrieb "Peter Ent" <pe...@adobe.com>:
Hi,
I've committed the changes!! The build should skip, MDL, Charts, and Basic
projects. I will get MDL and Charts running next. But before that, I will
have an email out with a breakdown of the changes I've made. Look for that
in the next couple of hours.
Good luck! Please let me know what breaks. I will tell you that the
biggest difference is the UIBase no longer sets position style so any
elements you have that require positioning via x,y, will need to use a
Group or Container that has the BasicLayout.
Regards,
Peter
On 3/22/17, 5:02 PM, "Peter Ent" <pe...@adobe.com> wrote:
>Update: I'm 99% ready to commit. I will do this tomorrow morning, my time.
>I've spent today fixing some last issues in HTML package, while cosmetic,
>just didn't make things look too good. There are a couple more but I'll do
>them later.
>
>I did a local merge of the latest FlexJS code and my changes and rebuilt
>flex-asjs. The Basic and Charts packages I expected to have issues. I'm
>not sure if I should even bother with Basic, just let me know. I have
>commented Charts from the build.xml so it will not cause the main build to
>fail.
>
>The other project is MDL. I will also comment that from the build and will
>work on that after I make the commit and push. The issue is that I changed
>a couple of interfaces in Core and replaced one interface with another. I
>just have to sync them up. Hopefully it will not take more than a day.
>
>If you prefer I do MDL before doing the commit, please let me know in the
>next 12-14 hours.
>
>Thanks,
>Peter
>
>On 3/22/17, 10:56 AM, "Harbs" <ha...@gmail.com> wrote:
>
>>Yes. Commit.
>>
>>Right now we need to use an earlier version because the current status is
>>broken.
>>
>>> On Mar 22, 2017, at 4:37 PM, OK <po...@olafkrueger.net> wrote:
>>>
>>> In case if something is broken for somebody maybe one option is to just
>>>check
>>> out a previous revision by using the particular commit hash?
>>>
>>> Olaf
>>>
>>>
>>>
>>> --
>>> View this message in context:
>>>https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fapache-f
>>>l
>>>ex-development.2333347.n4.nabble.com%2FFlexJS-Container-and-Layout-Progr
>>>e
>>>ss-tp60658p60673.html&data=02%7C01%7C%7C82a3a0f402a943fbc3fa08d47133951f
>>>%
>>>7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636257913736732760&sdata=hS
>>>A
>>>%2FIskqdzlbteHnTLr9pZwSE5Kk%2Fer9cb%2FUTJeMrZ8%3D&reserved=0
>>> Sent from the Apache Flex Development mailing list archive at
>>>Nabble.com.
>>
>
Re: [FlexJS] Container and Layout Progress
Posted by Peter Ent <pe...@adobe.com>.
Hi,
I've committed the changes!! The build should skip, MDL, Charts, and Basic
projects. I will get MDL and Charts running next. But before that, I will
have an email out with a breakdown of the changes I've made. Look for that
in the next couple of hours.
Good luck! Please let me know what breaks. I will tell you that the
biggest difference is the UIBase no longer sets position style so any
elements you have that require positioning via x,y, will need to use a
Group or Container that has the BasicLayout.
Regards,
Peter
On 3/22/17, 5:02 PM, "Peter Ent" <pe...@adobe.com> wrote:
>Update: I'm 99% ready to commit. I will do this tomorrow morning, my time.
>I've spent today fixing some last issues in HTML package, while cosmetic,
>just didn't make things look too good. There are a couple more but I'll do
>them later.
>
>I did a local merge of the latest FlexJS code and my changes and rebuilt
>flex-asjs. The Basic and Charts packages I expected to have issues. I'm
>not sure if I should even bother with Basic, just let me know. I have
>commented Charts from the build.xml so it will not cause the main build to
>fail.
>
>The other project is MDL. I will also comment that from the build and will
>work on that after I make the commit and push. The issue is that I changed
>a couple of interfaces in Core and replaced one interface with another. I
>just have to sync them up. Hopefully it will not take more than a day.
>
>If you prefer I do MDL before doing the commit, please let me know in the
>next 12-14 hours.
>
>Thanks,
>Peter
>
>On 3/22/17, 10:56 AM, "Harbs" <ha...@gmail.com> wrote:
>
>>Yes. Commit.
>>
>>Right now we need to use an earlier version because the current status is
>>broken.
>>
>>> On Mar 22, 2017, at 4:37 PM, OK <po...@olafkrueger.net> wrote:
>>>
>>> In case if something is broken for somebody maybe one option is to just
>>>check
>>> out a previous revision by using the particular commit hash?
>>>
>>> Olaf
>>>
>>>
>>>
>>> --
>>> View this message in context:
>>>https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fapache-f
>>>l
>>>ex-development.2333347.n4.nabble.com%2FFlexJS-Container-and-Layout-Progr
>>>e
>>>ss-tp60658p60673.html&data=02%7C01%7C%7C82a3a0f402a943fbc3fa08d47133951f
>>>%
>>>7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636257913736732760&sdata=hS
>>>A
>>>%2FIskqdzlbteHnTLr9pZwSE5Kk%2Fer9cb%2FUTJeMrZ8%3D&reserved=0
>>> Sent from the Apache Flex Development mailing list archive at
>>>Nabble.com.
>>
>
Re: [FlexJS] Container and Layout Progress
Posted by piotrz <pi...@gmail.com>.
Peter,
I think you should commit and try to fix at first MDL - If you have any
problems let me know I will help you.
As for the content of Basic - I think Alex know what changes will have place
in Basic due to "dual" branch.
Piotr
-----
Apache Flex PMC
piotrzarzycki21@gmail.com
--
View this message in context: http://apache-flex-development.2333347.n4.nabble.com/FlexJS-Container-and-Layout-Progress-tp60658p60686.html
Sent from the Apache Flex Development mailing list archive at Nabble.com.
Re: [FlexJS] Container and Layout Progress
Posted by Peter Ent <pe...@adobe.com>.
I guess I should have used a feature branch. I'm not sure how long Charts
will take. I wrote most of that code and it got pretty gnarly using List
as a basis. It probably is better to use a feature branch. Let me see if I
understand the rollback process and can get that going. Definitely a
lesson learned on that.
‹peter
On 3/23/17, 1:19 PM, "Josh Tynjala" <jo...@gmail.com> wrote:
>Peter warned the list that his changes would break some things
>temporarily,
>and he asked if he should proceed. Everyone who responded said that it was
>okay.
>
>- Josh
>
>On Thu, Mar 23, 2017 at 10:11 AM, Harbs <ha...@gmail.com> wrote:
>
>> Very good question.
>>
>> Peter, is there any chance to roll back containers and layouts and move
>> all the changes to a feature branch until things are stable?
>>
>> > On Mar 23, 2017, at 7:58 AM, Christofer Dutz
>><ch...@c-ware.de>
>> wrote:
>> >
>> > Why don't you guys use feature branches?
>>
>>
Re: [FlexJS] Container and Layout Progress
Posted by Peter Ent <pe...@adobe.com>.
I've committed and pushed changes to MDL that should make it compile. I
don't think it will work - I'll be doing that next but I wanted to get the
project to compile.
Basically, all of the List-like MDL classes now extends Group rather than
ContainerBase, which I should delete. Then I needed to make the classes
implement the updates to IItemRendererParent. The DataGroup isn't used any
longer so those classes have to act as ItemRendererParents now. Probably a
better way is to use a proxy and consolidate the code; I used this for
Panel.
But I will get MDL to work without major structural changes since it
JS-side only which makes it easier now.
—peter
On 3/23/17, 2:01 PM, "Peter Ent" <pe...@adobe.com> wrote:
>Yes, Chris does have a good point and from now on* I will definitely use
>feature branches. I thought I could squeeze this through.
>
>I checked in changes to Chart that should make it compile. I doubt it will
>run, but that is on the list. I will look into MDL now. That will take
>longer.
>
>I am leary about doing the rollback at this point. You should be able to
>remove MDL from the build temporarily. If you are relying on it, I will
>try to be as quick as possible and test against the MDL example before
>pushing my changes.
>
>* I will use feature branches once I get MDL working.
>
>Apologies,
>‹peter
>
>On 3/23/17, 1:31 PM, "Harbs" <ha...@gmail.com> wrote:
>
>>Sure. Including me.
>>
>>But Chris does have a point that we should be using feature branches more
>>than we are.
>>
>>The tone of my question might have not come across correctly. I meant to
>>ask how difficult it would be to move all changes to a feature branch and
>>push the feature branch. If it¹s too difficult, we can just continue to
>>fix the develop branch for now.
>>
>>> On Mar 23, 2017, at 7:19 PM, Josh Tynjala <jo...@gmail.com>
>>>wrote:
>>>
>>> Peter warned the list that his changes would break some things
>>>temporarily,
>>> and he asked if he should proceed. Everyone who responded said that it
>>>was
>>> okay.
>>>
>>> - Josh
>>>
>>> On Thu, Mar 23, 2017 at 10:11 AM, Harbs <ha...@gmail.com> wrote:
>>>
>>>> Very good question.
>>>>
>>>> Peter, is there any chance to roll back containers and layouts and
>>>>move
>>>> all the changes to a feature branch until things are stable?
>>>>
>>>>> On Mar 23, 2017, at 7:58 AM, Christofer Dutz
>>>>><ch...@c-ware.de>
>>>> wrote:
>>>>>
>>>>> Why don't you guys use feature branches?
>>>>
>>>>
>>
>
Re: [FlexJS] Container and Layout Progress
Posted by Peter Ent <pe...@adobe.com>.
Yes, Chris does have a good point and from now on* I will definitely use
feature branches. I thought I could squeeze this through.
I checked in changes to Chart that should make it compile. I doubt it will
run, but that is on the list. I will look into MDL now. That will take
longer.
I am leary about doing the rollback at this point. You should be able to
remove MDL from the build temporarily. If you are relying on it, I will
try to be as quick as possible and test against the MDL example before
pushing my changes.
* I will use feature branches once I get MDL working.
Apologies,
‹peter
On 3/23/17, 1:31 PM, "Harbs" <ha...@gmail.com> wrote:
>Sure. Including me.
>
>But Chris does have a point that we should be using feature branches more
>than we are.
>
>The tone of my question might have not come across correctly. I meant to
>ask how difficult it would be to move all changes to a feature branch and
>push the feature branch. If it¹s too difficult, we can just continue to
>fix the develop branch for now.
>
>> On Mar 23, 2017, at 7:19 PM, Josh Tynjala <jo...@gmail.com> wrote:
>>
>> Peter warned the list that his changes would break some things
>>temporarily,
>> and he asked if he should proceed. Everyone who responded said that it
>>was
>> okay.
>>
>> - Josh
>>
>> On Thu, Mar 23, 2017 at 10:11 AM, Harbs <ha...@gmail.com> wrote:
>>
>>> Very good question.
>>>
>>> Peter, is there any chance to roll back containers and layouts and move
>>> all the changes to a feature branch until things are stable?
>>>
>>>> On Mar 23, 2017, at 7:58 AM, Christofer Dutz
>>>><ch...@c-ware.de>
>>> wrote:
>>>>
>>>> Why don't you guys use feature branches?
>>>
>>>
>
Re: [FlexJS] Container and Layout Progress
Posted by Harbs <ha...@gmail.com>.
Sure. Including me.
But Chris does have a point that we should be using feature branches more than we are.
The tone of my question might have not come across correctly. I meant to ask how difficult it would be to move all changes to a feature branch and push the feature branch. If it’s too difficult, we can just continue to fix the develop branch for now.
> On Mar 23, 2017, at 7:19 PM, Josh Tynjala <jo...@gmail.com> wrote:
>
> Peter warned the list that his changes would break some things temporarily,
> and he asked if he should proceed. Everyone who responded said that it was
> okay.
>
> - Josh
>
> On Thu, Mar 23, 2017 at 10:11 AM, Harbs <ha...@gmail.com> wrote:
>
>> Very good question.
>>
>> Peter, is there any chance to roll back containers and layouts and move
>> all the changes to a feature branch until things are stable?
>>
>>> On Mar 23, 2017, at 7:58 AM, Christofer Dutz <ch...@c-ware.de>
>> wrote:
>>>
>>> Why don't you guys use feature branches?
>>
>>
Re: [FlexJS] Container and Layout Progress
Posted by Josh Tynjala <jo...@gmail.com>.
Peter warned the list that his changes would break some things temporarily,
and he asked if he should proceed. Everyone who responded said that it was
okay.
- Josh
On Thu, Mar 23, 2017 at 10:11 AM, Harbs <ha...@gmail.com> wrote:
> Very good question.
>
> Peter, is there any chance to roll back containers and layouts and move
> all the changes to a feature branch until things are stable?
>
> > On Mar 23, 2017, at 7:58 AM, Christofer Dutz <ch...@c-ware.de>
> wrote:
> >
> > Why don't you guys use feature branches?
>
>
Re: [FlexJS] Container and Layout Progress
Posted by Harbs <ha...@gmail.com>.
Very good question.
Peter, is there any chance to roll back containers and layouts and move all the changes to a feature branch until things are stable?
> On Mar 23, 2017, at 7:58 AM, Christofer Dutz <ch...@c-ware.de> wrote:
>
> Why don't you guys use feature branches?
AW: [FlexJS] Container and Layout Progress
Posted by Christofer Dutz <ch...@c-ware.de>.
Hi,
Why don't you guys use feature branches? I've made it so simple to use them :-(
If you create a branch on all three repos and babe it "feature/{something}" you even get automatic Jenkins builds for it.
Chris
Von meinem Samsung Galaxy Smartphone gesendet.
-------- Ursprüngliche Nachricht --------
Von: Peter Ent <pe...@adobe.com>
Datum: 22.03.17 22:02 (GMT+01:00)
An: dev@flex.apache.org
Betreff: Re: [FlexJS] Container and Layout Progress
Update: I'm 99% ready to commit. I will do this tomorrow morning, my time.
I've spent today fixing some last issues in HTML package, while cosmetic,
just didn't make things look too good. There are a couple more but I'll do
them later.
I did a local merge of the latest FlexJS code and my changes and rebuilt
flex-asjs. The Basic and Charts packages I expected to have issues. I'm
not sure if I should even bother with Basic, just let me know. I have
commented Charts from the build.xml so it will not cause the main build to
fail.
The other project is MDL. I will also comment that from the build and will
work on that after I make the commit and push. The issue is that I changed
a couple of interfaces in Core and replaced one interface with another. I
just have to sync them up. Hopefully it will not take more than a day.
If you prefer I do MDL before doing the commit, please let me know in the
next 12-14 hours.
Thanks,
Peter
On 3/22/17, 10:56 AM, "Harbs" <ha...@gmail.com> wrote:
>Yes. Commit.
>
>Right now we need to use an earlier version because the current status is
>broken.
>
>> On Mar 22, 2017, at 4:37 PM, OK <po...@olafkrueger.net> wrote:
>>
>> In case if something is broken for somebody maybe one option is to just
>>check
>> out a previous revision by using the particular commit hash?
>>
>> Olaf
>>
>>
>>
>> --
>> View this message in context:
>>https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fapache-fl
>>ex-development.2333347.n4.nabble.com%2FFlexJS-Container-and-Layout-Progre
>>ss-tp60658p60673.html&data=02%7C01%7C%7C82a3a0f402a943fbc3fa08d47133951f%
>>7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636257913736732760&sdata=hSA
>>%2FIskqdzlbteHnTLr9pZwSE5Kk%2Fer9cb%2FUTJeMrZ8%3D&reserved=0
>> Sent from the Apache Flex Development mailing list archive at
>>Nabble.com.
>
Re: [FlexJS] Container and Layout Progress
Posted by Peter Ent <pe...@adobe.com>.
Update: I'm 99% ready to commit. I will do this tomorrow morning, my time.
I've spent today fixing some last issues in HTML package, while cosmetic,
just didn't make things look too good. There are a couple more but I'll do
them later.
I did a local merge of the latest FlexJS code and my changes and rebuilt
flex-asjs. The Basic and Charts packages I expected to have issues. I'm
not sure if I should even bother with Basic, just let me know. I have
commented Charts from the build.xml so it will not cause the main build to
fail.
The other project is MDL. I will also comment that from the build and will
work on that after I make the commit and push. The issue is that I changed
a couple of interfaces in Core and replaced one interface with another. I
just have to sync them up. Hopefully it will not take more than a day.
If you prefer I do MDL before doing the commit, please let me know in the
next 12-14 hours.
Thanks,
Peter
On 3/22/17, 10:56 AM, "Harbs" <ha...@gmail.com> wrote:
>Yes. Commit.
>
>Right now we need to use an earlier version because the current status is
>broken.
>
>> On Mar 22, 2017, at 4:37 PM, OK <po...@olafkrueger.net> wrote:
>>
>> In case if something is broken for somebody maybe one option is to just
>>check
>> out a previous revision by using the particular commit hash?
>>
>> Olaf
>>
>>
>>
>> --
>> View this message in context:
>>https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fapache-fl
>>ex-development.2333347.n4.nabble.com%2FFlexJS-Container-and-Layout-Progre
>>ss-tp60658p60673.html&data=02%7C01%7C%7C82a3a0f402a943fbc3fa08d47133951f%
>>7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636257913736732760&sdata=hSA
>>%2FIskqdzlbteHnTLr9pZwSE5Kk%2Fer9cb%2FUTJeMrZ8%3D&reserved=0
>> Sent from the Apache Flex Development mailing list archive at
>>Nabble.com.
>
Re: [FlexJS] Container and Layout Progress
Posted by Harbs <ha...@gmail.com>.
Yes. Commit.
Right now we need to use an earlier version because the current status is broken.
> On Mar 22, 2017, at 4:37 PM, OK <po...@olafkrueger.net> wrote:
>
> In case if something is broken for somebody maybe one option is to just check
> out a previous revision by using the particular commit hash?
>
> Olaf
>
>
>
> --
> View this message in context: http://apache-flex-development.2333347.n4.nabble.com/FlexJS-Container-and-Layout-Progress-tp60658p60673.html
> Sent from the Apache Flex Development mailing list archive at Nabble.com.
Re: [FlexJS] Container and Layout Progress
Posted by OK <po...@olafkrueger.net>.
In case if something is broken for somebody maybe one option is to just check
out a previous revision by using the particular commit hash?
Olaf
--
View this message in context: http://apache-flex-development.2333347.n4.nabble.com/FlexJS-Container-and-Layout-Progress-tp60658p60673.html
Sent from the Apache Flex Development mailing list archive at Nabble.com.
Re: [FlexJS] Container and Layout Progress
Posted by Peter Ent <pe...@adobe.com>.
Hi,
One more thing: When I make this commit, I'm pretty sure Charts will be
broken until I address it. I can hold off the commit and address Charts
first, but I would prefer to commit Core and HTML and then fix Charts and
anything else.
Would that strategy (commit first, fix Charts etc after) impact you?
Should I try to get more projects working first before doing the commit?
‹peter
On 3/21/17, 6:00 PM, "piotrz" <pi...@gmail.com> wrote:
>Hi Peter,
>
>Thank you for a hard work.
>
>I'm concerning about one thing. Alex mentioned that he will merge soon
>dual
>branch to develop - It will be tons of conflicts - Maybe it would be good
>to
>look also into that problem.
>
>Piotr
>
>
>
>-----
>Apache Flex PMC
>piotrzarzycki21@gmail.com
>--
>View this message in context:
>https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fapache-fle
>x-development.2333347.n4.nabble.com%2FFlexJS-Container-and-Layout-Progress
>-tp60658p60659.html&data=02%7C01%7C%7C0c2dad00daa048aec35808d470a6ce38%7Cf
>a7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636257309108498545&sdata=L%2Br39
>imWqdtudyvD1HZYHTaBT61Byhqbfa%2BOHknNLR4%3D&reserved=0
>Sent from the Apache Flex Development mailing list archive at Nabble.com.
Re: [FlexJS] Container and Layout Progress
Posted by piotrz <pi...@gmail.com>.
Hi Peter,
Thank you for a hard work.
I'm concerning about one thing. Alex mentioned that he will merge soon dual
branch to develop - It will be tons of conflicts - Maybe it would be good to
look also into that problem.
Piotr
-----
Apache Flex PMC
piotrzarzycki21@gmail.com
--
View this message in context: http://apache-flex-development.2333347.n4.nabble.com/FlexJS-Container-and-Layout-Progress-tp60658p60659.html
Sent from the Apache Flex Development mailing list archive at Nabble.com.