You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by "xiaobaicai66695 (via GitHub)" <gi...@apache.org> on 2026/08/07 03:34:21 UTC
[PR] docs(protocol): unify protocol option comments ##3598 [dubbo-go]
xiaobaicai66695 opened a new pull request, #3610:
URL: https://github.com/apache/dubbo-go/pull/3610
### Description
Complete task 3: unify the protocol option style in `protocol/options.go`.
- Add grouping comments for protocol selection, server protocol configuration, and deprecated options.
- Unify the GoDoc style for `WithTriple`, `WithDubbo`, `WithJSONRPC`, and `WithREST`.
- Unify the comments for `WithID`, `WithIp`, `WithPort`, and `WithParams`.
- Correct the outdated `server.WithServer_ProtocolIDs` reference to `server.WithServerProtocolIDs`.
- No API signatures or runtime behavior are changed.
### Checklist
- [x] I confirm the target branch is `develop`
- [x] Code has passed local testing
- [x] No tests were added because this is a documentation-only change
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [PR] docs(protocol): unify protocol option comments #3598 [dubbo-go]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #3610:
URL: https://github.com/apache/dubbo-go/pull/3610#issuecomment-5212012891
## [Codecov](https://app.codecov.io/gh/apache/dubbo-go/pull/3610?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 53.86%. Comparing base ([`48d6e69`](https://app.codecov.io/gh/apache/dubbo-go/commit/48d6e696e755d46df2425bbf71c413bbd1887f3f?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`cd7d870`](https://app.codecov.io/gh/apache/dubbo-go/commit/cd7d87070f982ece4885d2aff23c702eacdae4d1?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 12 commits behind head on develop.
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## develop #3610 +/- ##
===========================================
- Coverage 54.57% 53.86% -0.71%
===========================================
Files 460 474 +14
Lines 35443 36388 +945
===========================================
+ Hits 19344 19602 +258
- Misses 14543 15211 +668
- Partials 1556 1575 +19
```
</details>
[:umbrella: View full report in Codecov by Harness](https://app.codecov.io/gh/apache/dubbo-go/pull/3610?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [PR] docs(protocol): unify protocol option comments #3598 [dubbo-go]
Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.
sonarqubecloud[bot] commented on PR #3610:
URL: https://github.com/apache/dubbo-go/pull/3610#issuecomment-5211975534
## [](https://sonarcloud.io/dashboard?id=apache_dubbo-go&pullRequest=3610) **Quality Gate passed**
Issues
 [0 New issues](https://sonarcloud.io/project/issues?id=apache_dubbo-go&pullRequest=3610&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_dubbo-go&pullRequest=3610&issueStatuses=ACCEPTED)
Measures
 [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo-go&pullRequest=3610&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_dubbo-go&pullRequest=3610&metric=new_coverage&view=list)
 [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_dubbo-go&pullRequest=3610&metric=new_duplicated_lines_density&view=list)
<!-- sqra-placement-anchor -->
[See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_dubbo-go&pullRequest=3610)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [PR] docs(protocol): unify protocol option comments #3598 [dubbo-go]
Posted by "xiaobaicai66695 (via GitHub)" <gi...@apache.org>.
xiaobaicai66695 commented on PR #3610:
URL: https://github.com/apache/dubbo-go/pull/3610#issuecomment-5212010791
@Alanxtl pls review it,thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [PR] docs(protocol): unify protocol option comments #3598 [dubbo-go]
Posted by "AlexStocks (via GitHub)" <gi...@apache.org>.
AlexStocks merged PR #3610:
URL: https://github.com/apache/dubbo-go/pull/3610
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org