You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues-all@impala.apache.org by "ASF subversion and git services (Jira)" <ji...@apache.org> on 2022/10/11 02:43:00 UTC
[jira] [Commented] (IMPALA-11504) Speed up Decimal16Value division by specializing DecimalUtil::GetScaleMultiplier()
[ https://issues.apache.org/jira/browse/IMPALA-11504?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17615423#comment-17615423 ]
ASF subversion and git services commented on IMPALA-11504:
----------------------------------------------------------
Commit 6e7cd605fdf3ce95a5993676a87a0209ae671973 in impala's branch refs/heads/master from yx91490
[ https://gitbox.apache.org/repos/asf?p=impala.git;h=6e7cd605f ]
IMPALA-11504: Specializing DecimalUtil::GetScaleMultiplier<int256_t>().
Currently decimal-util.h didn't specialize DecimalUtil
::GetScaleMultiplier<int256_t>(), causing more performance loss when
calculate Decimal16Value division.
This template specialisation results in 5600X speedup approximately.
Testing:
- Ran existing jobs.
- Add decimal-util-benchmark.
Change-Id: I969e2977d51313e738f72c8246db003ae43a3782
Reviewed-on: http://gerrit.cloudera.org:8080/18861
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
> Speed up Decimal16Value division by specializing DecimalUtil::GetScaleMultiplier<int256_t>()
> --------------------------------------------------------------------------------------------
>
> Key: IMPALA-11504
> URL: https://issues.apache.org/jira/browse/IMPALA-11504
> Project: IMPALA
> Issue Type: Improvement
> Reporter: yx91490
> Assignee: yx91490
> Priority: Major
>
> There exists a call chain:
> {code:java}
> DecimalValue<int128_t>::Divide() ->
> DecimalUtil::MultiplyByScale<int256_t>() ->
> DecimalUtil::GetScaleMultiplier(){code}
> but decimal-util.h didn't specialize DecimalUtil::GetScaleMultiplier<int256_t>(), causing more performance loss.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-all-unsubscribe@impala.apache.org
For additional commands, e-mail: issues-all-help@impala.apache.org