You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by ustcweizhou <gi...@git.apache.org> on 2017/02/03 16:57:25 UTC

[GitHub] cloudstack pull request #1929: CLOUDSTACK-9770: fix missing ip routes in VR

GitHub user ustcweizhou opened a pull request:

    https://github.com/apache/cloudstack/pull/1929

    CLOUDSTACK-9770: fix missing ip routes in VR

    In network VR, the routes to current subnets are missing in corresponding ip route Table.
    It is a typo in commit 6749785caba78a9379e94bf3aaf0c1fbc44c5445
    In VPC VR, it works fine.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/ustcweizhou/cloudstack VR-missing-route

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cloudstack/pull/1929.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1929
    
----
commit 8c69cb1c1fd7ba93e021dca7d6e08dbaa831ccfa
Author: Wei Zhou <w....@tech.leaseweb.com>
Date:   2017-02-03T09:04:10Z

    CLOUDSTACK-9770: fix missing ip routes in VR

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1929: CLOUDSTACK-9770: fix missing ip routes in VR

Posted by borisstoyanov <gi...@git.apache.org>.
Github user borisstoyanov commented on the issue:

    https://github.com/apache/cloudstack/pull/1929
  
    @blueorangutan package


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1929: CLOUDSTACK-9770: fix missing ip routes in VR

Posted by blueorangutan <gi...@git.apache.org>.
Github user blueorangutan commented on the issue:

    https://github.com/apache/cloudstack/pull/1929
  
    Packaging result: \u2714centos6 \u2714centos7 \u2714debian. JID-471


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #1929: [4.9] CLOUDSTACK-9770: fix missing ip routes ...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/cloudstack/pull/1929


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1929: CLOUDSTACK-9770: fix missing ip routes in VR

Posted by milamberspace <gi...@git.apache.org>.
Github user milamberspace commented on the issue:

    https://github.com/apache/cloudstack/pull/1929
  
    
    @DaanHoogland Yes I've already tested with success the patch. Please see Jira
    
    https://issues.apache.org/jira/browse/CLOUDSTACK-9770
    
    The PR by @ustcweizhou  is 
    https://github.com/apache/cloudstack/pull/1929


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1929: CLOUDSTACK-9770: fix missing ip routes in VR

Posted by milamberspace <gi...@git.apache.org>.
Github user milamberspace commented on the issue:

    https://github.com/apache/cloudstack/pull/1929
  
    @DaanHoogland Yes I've already tested with success the patch. Please see Jira



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1929: CLOUDSTACK-9770: fix missing ip routes in VR

Posted by murali-reddy <gi...@git.apache.org>.
Github user murali-reddy commented on the issue:

    https://github.com/apache/cloudstack/pull/1929
  
    LGTM. thanks @ustcweizhou 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1929: CLOUDSTACK-9770: fix missing ip routes in VR

Posted by blueorangutan <gi...@git.apache.org>.
Github user blueorangutan commented on the issue:

    https://github.com/apache/cloudstack/pull/1929
  
    @borisstoyanov a Trillian-Jenkins test job (centos7 mgmt + vmware-60u2) has been kicked to run smoke tests


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1929: CLOUDSTACK-9770: fix missing ip routes in VR

Posted by milamberspace <gi...@git.apache.org>.
Github user milamberspace commented on the issue:

    https://github.com/apache/cloudstack/pull/1929
  
    LGTM tested in real conditions with success


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1929: CLOUDSTACK-9770: fix missing ip routes in VR

Posted by borisstoyanov <gi...@git.apache.org>.
Github user borisstoyanov commented on the issue:

    https://github.com/apache/cloudstack/pull/1929
  
     @blueorangutan test centos7 vmware-60u2


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1929: CLOUDSTACK-9770: fix missing ip routes in VR

Posted by blueorangutan <gi...@git.apache.org>.
Github user blueorangutan commented on the issue:

    https://github.com/apache/cloudstack/pull/1929
  
    <b>Trillian test result (tid-802)</b>
    Environment: vmware-60u2 (x2), Advanced Networking with Mgmt server 7
    Total time taken: 43855 seconds
    Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr1929-t802-vmware-60u2.zip
    Intermitten failure detected: /marvin/tests/smoke/test_internal_lb.py
    Intermitten failure detected: /marvin/tests/smoke/test_privategw_acl.py
    Intermitten failure detected: /marvin/tests/smoke/test_routers_network_ops.py
    Intermitten failure detected: /marvin/tests/smoke/test_snapshots.py
    Intermitten failure detected: /marvin/tests/smoke/test_ssvm.py
    Intermitten failure detected: /marvin/tests/smoke/test_vpc_redundant.py
    Test completed. 45 look ok, 3 have error(s)
    
    
    Test | Result | Time (s) | Test File
    --- | --- | --- | ---
    test_04_rvpc_privategw_static_routes | `Failure` | 803.99 | test_privategw_acl.py
    test_04_rvpc_internallb_haproxy_stats_on_all_interfaces | `Failure` | 212.24 | test_internal_lb.py
    test_02_redundant_VPC_default_routes | `Error` | 191.97 | test_vpc_redundant.py
    test_01_vpc_site2site_vpn | Success | 315.91 | test_vpc_vpn.py
    test_01_vpc_remote_access_vpn | Success | 136.53 | test_vpc_vpn.py
    test_01_redundant_vpc_site2site_vpn | Success | 544.24 | test_vpc_vpn.py
    test_02_VPC_default_routes | Success | 299.21 | test_vpc_router_nics.py
    test_01_VPC_nics_after_destroy | Success | 673.92 | test_vpc_router_nics.py
    test_05_rvpc_multi_tiers | Success | 616.23 | test_vpc_redundant.py
    test_04_rvpc_network_garbage_collector_nics | Success | 1493.85 | test_vpc_redundant.py
    test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers | Success | 633.65 | test_vpc_redundant.py
    test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | Success | 1336.28 | test_vpc_redundant.py
    test_09_delete_detached_volume | Success | 20.76 | test_volumes.py
    test_06_download_detached_volume | Success | 50.50 | test_volumes.py
    test_05_detach_volume | Success | 100.27 | test_volumes.py
    test_04_delete_attached_volume | Success | 10.19 | test_volumes.py
    test_03_download_attached_volume | Success | 15.29 | test_volumes.py
    test_02_attach_volume | Success | 48.73 | test_volumes.py
    test_01_create_volume | Success | 515.18 | test_volumes.py
    test_03_delete_vm_snapshots | Success | 280.25 | test_vm_snapshots.py
    test_02_revert_vm_snapshots | Success | 219.37 | test_vm_snapshots.py
    test_01_test_vm_volume_snapshot | Success | 116.05 | test_vm_snapshots.py
    test_01_create_vm_snapshots | Success | 161.74 | test_vm_snapshots.py
    test_deploy_vm_multiple | Success | 202.86 | test_vm_life_cycle.py
    test_deploy_vm | Success | 0.03 | test_vm_life_cycle.py
    test_advZoneVirtualRouter | Success | 0.02 | test_vm_life_cycle.py
    test_10_attachAndDetach_iso | Success | 27.10 | test_vm_life_cycle.py
    test_09_expunge_vm | Success | 125.22 | test_vm_life_cycle.py
    test_08_migrate_vm | Success | 96.24 | test_vm_life_cycle.py
    test_07_restore_vm | Success | 0.10 | test_vm_life_cycle.py
    test_06_destroy_vm | Success | 10.15 | test_vm_life_cycle.py
    test_03_reboot_vm | Success | 5.14 | test_vm_life_cycle.py
    test_02_start_vm | Success | 15.20 | test_vm_life_cycle.py
    test_01_stop_vm | Success | 5.12 | test_vm_life_cycle.py
    test_CreateTemplateWithDuplicateName | Success | 206.36 | test_templates.py
    test_08_list_system_templates | Success | 0.03 | test_templates.py
    test_07_list_public_templates | Success | 0.04 | test_templates.py
    test_05_template_permissions | Success | 0.06 | test_templates.py
    test_04_extract_template | Success | 10.34 | test_templates.py
    test_03_delete_template | Success | 5.10 | test_templates.py
    test_02_edit_template | Success | 90.10 | test_templates.py
    test_01_create_template | Success | 105.76 | test_templates.py
    test_10_destroy_cpvm | Success | 237.03 | test_ssvm.py
    test_09_destroy_ssvm | Success | 268.93 | test_ssvm.py
    test_08_reboot_cpvm | Success | 156.53 | test_ssvm.py
    test_07_reboot_ssvm | Success | 158.34 | test_ssvm.py
    test_06_stop_cpvm | Success | 206.95 | test_ssvm.py
    test_05_stop_ssvm | Success | 178.62 | test_ssvm.py
    test_04_cpvm_internals | Success | 1.15 | test_ssvm.py
    test_03_ssvm_internals | Success | 2.76 | test_ssvm.py
    test_02_list_cpvm_vm | Success | 0.12 | test_ssvm.py
    test_01_list_sec_storage_vm | Success | 0.13 | test_ssvm.py
    test_01_snapshot_root_disk | Success | 21.14 | test_snapshots.py
    test_04_change_offering_small | Success | 116.83 | test_service_offerings.py
    test_03_delete_service_offering | Success | 0.04 | test_service_offerings.py
    test_02_edit_service_offering | Success | 0.05 | test_service_offerings.py
    test_01_create_service_offering | Success | 0.11 | test_service_offerings.py
    test_02_sys_template_ready | Success | 0.13 | test_secondary_storage.py
    test_01_sys_vm_start | Success | 0.17 | test_secondary_storage.py
    test_09_reboot_router | Success | 110.75 | test_routers.py
    test_08_start_router | Success | 100.69 | test_routers.py
    test_07_stop_router | Success | 25.24 | test_routers.py
    test_06_router_advanced | Success | 0.12 | test_routers.py
    test_05_router_basic | Success | 0.04 | test_routers.py
    test_04_restart_network_wo_cleanup | Success | 5.65 | test_routers.py
    test_03_restart_network_cleanup | Success | 120.97 | test_routers.py
    test_02_router_internal_adv | Success | 1.04 | test_routers.py
    test_01_router_internal_basic | Success | 0.53 | test_routers.py
    test_router_dns_guestipquery | Success | 76.68 | test_router_dns.py
    test_router_dns_externalipquery | Success | 0.07 | test_router_dns.py
    test_router_dhcphosts | Success | 173.98 | test_router_dhcphosts.py
    test_router_dhcp_opts | Success | 21.60 | test_router_dhcphosts.py
    test_01_updatevolumedetail | Success | 0.09 | test_resource_detail.py
    test_01_reset_vm_on_reboot | Success | 45.42 | test_reset_vm_on_reboot.py
    test_createRegion | Success | 0.04 | test_regions.py
    test_create_pvlan_network | Success | 5.21 | test_pvlan.py
    test_dedicatePublicIpRange | Success | 0.41 | test_public_ip_range.py
    test_03_vpc_privategw_restart_vpc_cleanup | Success | 932.49 | test_privategw_acl.py
    test_02_vpc_privategw_static_routes | Success | 606.67 | test_privategw_acl.py
    test_01_vpc_privategw_acl | Success | 177.82 | test_privategw_acl.py
    test_01_primary_storage_nfs | Success | 36.11 | test_primary_storage.py
    test_createPortablePublicIPRange | Success | 15.19 | test_portable_publicip.py
    test_createPortablePublicIPAcquire | Success | 15.47 | test_portable_publicip.py
    test_isolate_network_password_server | Success | 94.25 | test_password_server.py
    test_UpdateStorageOverProvisioningFactor | Success | 0.14 | test_over_provisioning.py
    test_oobm_zchange_password | Success | 30.88 | test_outofbandmanagement.py
    test_oobm_multiple_mgmt_server_ownership | Success | 16.31 | test_outofbandmanagement.py
    test_oobm_issue_power_status | Success | 10.25 | test_outofbandmanagement.py
    test_oobm_issue_power_soft | Success | 15.32 | test_outofbandmanagement.py
    test_oobm_issue_power_reset | Success | 15.31 | test_outofbandmanagement.py
    test_oobm_issue_power_on | Success | 15.34 | test_outofbandmanagement.py
    test_oobm_issue_power_off | Success | 15.31 | test_outofbandmanagement.py
    test_oobm_issue_power_cycle | Success | 15.37 | test_outofbandmanagement.py
    test_oobm_enabledisable_across_clusterzones | Success | 87.56 | test_outofbandmanagement.py
    test_oobm_enable_feature_valid | Success | 5.14 | test_outofbandmanagement.py
    test_oobm_enable_feature_invalid | Success | 0.09 | test_outofbandmanagement.py
    test_oobm_disable_feature_valid | Success | 5.18 | test_outofbandmanagement.py
    test_oobm_disable_feature_invalid | Success | 0.10 | test_outofbandmanagement.py
    test_oobm_configure_invalid_driver | Success | 0.08 | test_outofbandmanagement.py
    test_oobm_configure_default_driver | Success | 0.07 | test_outofbandmanagement.py
    test_oobm_background_powerstate_sync | Success | 23.40 | test_outofbandmanagement.py
    test_extendPhysicalNetworkVlan | Success | 15.48 | test_non_contigiousvlan.py
    test_01_nic | Success | 379.61 | test_nic.py
    test_releaseIP | Success | 232.74 | test_network.py
    test_reboot_router | Success | 524.25 | test_network.py
    test_public_ip_user_account | Success | 10.26 | test_network.py
    test_public_ip_admin_account | Success | 40.28 | test_network.py
    test_network_rules_acquired_public_ip_3_Load_Balancer_Rule | Success | 71.72 | test_network.py
    test_network_rules_acquired_public_ip_2_nat_rule | Success | 61.71 | test_network.py
    test_network_rules_acquired_public_ip_1_static_nat_rule | Success | 124.97 | test_network.py
    test_delete_account | Success | 252.62 | test_network.py
    test_02_port_fwd_on_non_src_nat | Success | 55.69 | test_network.py
    test_01_port_fwd_on_src_nat | Success | 111.81 | test_network.py
    test_nic_secondaryip_add_remove | Success | 222.68 | test_multipleips_per_nic.py
    login_test_saml_user | Success | 19.28 | test_login.py
    test_assign_and_removal_lb | Success | 143.29 | test_loadbalance.py
    test_02_create_lb_rule_non_nat | Success | 202.28 | test_loadbalance.py
    test_01_create_lb_rule_src_nat | Success | 218.01 | test_loadbalance.py
    test_03_list_snapshots | Success | 0.09 | test_list_ids_parameter.py
    test_02_list_templates | Success | 0.04 | test_list_ids_parameter.py
    test_01_list_volumes | Success | 0.03 | test_list_ids_parameter.py
    test_07_list_default_iso | Success | 0.06 | test_iso.py
    test_05_iso_permissions | Success | 0.06 | test_iso.py
    test_04_extract_Iso | Success | 5.17 | test_iso.py
    test_03_delete_iso | Success | 95.15 | test_iso.py
    test_02_edit_iso | Success | 0.10 | test_iso.py
    test_01_create_iso | Success | 21.04 | test_iso.py
    test_03_vpc_internallb_haproxy_stats_on_all_interfaces | Success | 364.16 | test_internal_lb.py
    test_02_internallb_roundrobin_1RVPC_3VM_HTTP_port80 | Success | 987.99 | test_internal_lb.py
    test_01_internallb_roundrobin_1VPC_3VM_HTTP_port80 | Success | 695.33 | test_internal_lb.py
    test_dedicateGuestVlanRange | Success | 10.27 | test_guest_vlan_range.py
    test_UpdateConfigParamWithScope | Success | 0.14 | test_global_settings.py
    test_rolepermission_lifecycle_update | Success | 6.17 | test_dynamicroles.py
    test_rolepermission_lifecycle_list | Success | 5.96 | test_dynamicroles.py
    test_rolepermission_lifecycle_delete | Success | 5.86 | test_dynamicroles.py
    test_rolepermission_lifecycle_create | Success | 5.98 | test_dynamicroles.py
    test_rolepermission_lifecycle_concurrent_updates | Success | 6.03 | test_dynamicroles.py
    test_role_lifecycle_update_role_inuse | Success | 6.33 | test_dynamicroles.py
    test_role_lifecycle_update | Success | 10.97 | test_dynamicroles.py
    test_role_lifecycle_list | Success | 5.88 | test_dynamicroles.py
    test_role_lifecycle_delete | Success | 10.96 | test_dynamicroles.py
    test_role_lifecycle_create | Success | 5.89 | test_dynamicroles.py
    test_role_inuse_deletion | Success | 5.93 | test_dynamicroles.py
    test_role_account_acls_multiple_mgmt_servers | Success | 8.08 | test_dynamicroles.py
    test_role_account_acls | Success | 8.12 | test_dynamicroles.py
    test_default_role_deletion | Success | 5.96 | test_dynamicroles.py
    test_04_create_fat_type_disk_offering | Success | 0.07 | test_disk_offerings.py
    test_03_delete_disk_offering | Success | 0.04 | test_disk_offerings.py
    test_02_edit_disk_offering | Success | 0.05 | test_disk_offerings.py
    test_02_create_sparse_type_disk_offering | Success | 0.07 | test_disk_offerings.py
    test_01_create_disk_offering | Success | 0.10 | test_disk_offerings.py
    test_deployvm_userdispersing | Success | 45.72 | test_deploy_vms_with_varied_deploymentplanners.py
    test_deployvm_userconcentrated | Success | 65.86 | test_deploy_vms_with_varied_deploymentplanners.py
    test_deployvm_firstfit | Success | 166.30 | test_deploy_vms_with_varied_deploymentplanners.py
    test_deployvm_userdata_post | Success | 20.48 | test_deploy_vm_with_userdata.py
    test_deployvm_userdata | Success | 141.26 | test_deploy_vm_with_userdata.py
    test_02_deploy_vm_root_resize | Success | 6.00 | test_deploy_vm_root_resize.py
    test_01_deploy_vm_root_resize | Success | 5.84 | test_deploy_vm_root_resize.py
    test_00_deploy_vm_root_resize | Success | 6.00 | test_deploy_vm_root_resize.py
    test_deploy_vm_from_iso | Success | 172.26 | test_deploy_vm_iso.py
    test_DeployVmAntiAffinityGroup | Success | 166.58 | test_affinity_groups.py
    test_08_resize_volume | Skipped | 5.30 | test_volumes.py
    test_07_resize_fail | Skipped | 10.30 | test_volumes.py
    test_06_copy_template | Skipped | 0.00 | test_templates.py
    test_static_role_account_acls | Skipped | 0.02 | test_staticroles.py
    test_01_scale_vm | Skipped | 64.27 | test_scale_vm.py
    test_01_primary_storage_iscsi | Skipped | 0.04 | test_primary_storage.py
    test_06_copy_iso | Skipped | 0.00 | test_iso.py
    test_deploy_vgpu_enabled_vm | Skipped | 0.00 | test_deploy_vgpu_enabled_vm.py



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1929: CLOUDSTACK-9770: fix missing ip routes in VR

Posted by DaanHoogland <gi...@git.apache.org>.
Github user DaanHoogland commented on the issue:

    https://github.com/apache/cloudstack/pull/1929
  
    @milamberspace could you try with this patch? I think @ustcweizhou solved your problem with the default route


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1929: CLOUDSTACK-9770: fix missing ip routes in VR

Posted by blueorangutan <gi...@git.apache.org>.
Github user blueorangutan commented on the issue:

    https://github.com/apache/cloudstack/pull/1929
  
    @borisstoyanov a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---