[GitHub] [incubator-celeborn] waitinfuture commented on a diff in pull request #1549: [CELEBORN-638] Migrate configurations celeborn.ha.master.* to celeborn.master.ha.*

["waitinfuture (via GitHub)" <gi...@apache.org>]

waitinfuture commented on code in PR #1549:
URL: https://github.com/apache/incubator-celeborn/pull/1549#discussion_r1228898657


##########
common/src/main/scala/org/apache/celeborn/common/CelebornConf.scala:
##########
@@ -534,32 +534,43 @@ class CelebornConf(loadDefaults: Boolean) extends Cloneable with Logging with Se
     }
 
     val nodeConfPrefix = extractPrefix(HA_MASTER_NODE_HOST.key, "<id>")
-    getAllWithPrefix(nodeConfPrefix)
+    val nodeIds = getAllWithPrefix(nodeConfPrefix)
       .map(_._1)
       .filterNot(_.equals("id"))
       .map(k => extractPrefix(k, "."))
       .distinct
+
+    val legacyNodeConfPrefix = extractPrefix(HA_MASTER_NODE_HOST.alternatives.head._1, "<id>")

Review Comment:
   Better to add a comment to explain a bit.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org