You are viewing a plain text version of this content. The canonical link for it is here.
Posted to server-dev@james.apache.org by "Jochen Wiedmann (JIRA)" <se...@james.apache.org> on 2007/07/11 22:39:05 UTC
[jira] Created: (MIME4J-19) Pull Parser
Pull Parser
-----------
Key: MIME4J-19
URL: https://issues.apache.org/jira/browse/MIME4J-19
Project: Mime4j
Issue Type: New Feature
Affects Versions: 0.3
Reporter: Jochen Wiedmann
Fix For: 0.4
The attached patch introduces a new class called MimeTokenStream, which is a "Pull Parser" for MIME documents. The class is basically a rewrite of the MimeStreamParser. The patch does also provide a rewrite of the MimeStreamParser itself, based on the MimeTokenStream.
Pull parsers are technically a little bit more difficult. However, from the users perspective, they are much more preferrable, because writing an application on top of a pull parser is much easier than based on an event handler.
I would like to rewrite the commons-fileupload component based on mime4j. However, as commons-fileupload provides a pull parser API, we depend on the presence of a similar API in mime4j. Not providing a pull parser API would mean, that we'd need to duplicate mime4j code into commons-fileupload, which is certainly not desirable.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org
Re: [jira] Updated: (MIME4J-19) Pull Parser
Posted by Norman Maurer <no...@apache.org>.
Maybe I will be able today to have a look at it.
bye
Norman
On Thu, 12 Jul 2007 20:39:52 +0100, "robert burrell donkin" <ro...@gmail.com> wrote:
> i think that having a pull parser at MIME4J would be cool :-)
>
> anyone more knowledgeable fancy taking a look at this patch?
>
> - robert
>
> On 7/11/07, Jochen Wiedmann (JIRA) <se...@james.apache.org> wrote:
>>
>> [
> https://issues.apache.org/jira/browse/MIME4J-19?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
> ]
>>
>> Jochen Wiedmann updated MIME4J-19:
>> ----------------------------------
>>
>> Attachment: mime4j-iterator.patch
>>
>> Suggested patch.
>>
>>
>> > Pull Parser
>> > -----------
>> >
>> > Key: MIME4J-19
>> > URL: https://issues.apache.org/jira/browse/MIME4J-19
>> > Project: Mime4j
>> > Issue Type: New Feature
>> > Affects Versions: 0.3
>> > Reporter: Jochen Wiedmann
>> > Fix For: 0.4
>> >
>> > Attachments: mime4j-iterator.patch
>> >
>> >
>> > The attached patch introduces a new class called MimeTokenStream,
> which is a "Pull Parser" for MIME documents. The class is basically a
> rewrite of the MimeStreamParser. The patch does also provide a rewrite of
> the MimeStreamParser itself, based on the MimeTokenStream.
>> > Pull parsers are technically a little bit more difficult. However,
> from the users perspective, they are much more preferrable, because
> writing an application on top of a pull parser is much easier than based
> on an event handler.
>> > I would like to rewrite the commons-fileupload component based on
> mime4j. However, as commons-fileupload provides a pull parser API, we
> depend on the presence of a similar API in mime4j. Not providing a pull
> parser API would mean, that we'd need to duplicate mime4j code into
> commons-fileupload, which is certainly not desirable.
>>
>> --
>> This message is automatically generated by JIRA.
>> -
>> You can reply to this email to add a comment to the issue online.
>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
>> For additional commands, e-mail: server-dev-help@james.apache.org
>>
>>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
> For additional commands, e-mail: server-dev-help@james.apache.org
>
>
> !DSPAM:1,469683ac240378290022044!
---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org
Re: [jira] Updated: (MIME4J-19) Pull Parser
Posted by robert burrell donkin <ro...@gmail.com>.
i think that having a pull parser at MIME4J would be cool :-)
anyone more knowledgeable fancy taking a look at this patch?
- robert
On 7/11/07, Jochen Wiedmann (JIRA) <se...@james.apache.org> wrote:
>
> [ https://issues.apache.org/jira/browse/MIME4J-19?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
>
> Jochen Wiedmann updated MIME4J-19:
> ----------------------------------
>
> Attachment: mime4j-iterator.patch
>
> Suggested patch.
>
>
> > Pull Parser
> > -----------
> >
> > Key: MIME4J-19
> > URL: https://issues.apache.org/jira/browse/MIME4J-19
> > Project: Mime4j
> > Issue Type: New Feature
> > Affects Versions: 0.3
> > Reporter: Jochen Wiedmann
> > Fix For: 0.4
> >
> > Attachments: mime4j-iterator.patch
> >
> >
> > The attached patch introduces a new class called MimeTokenStream, which is a "Pull Parser" for MIME documents. The class is basically a rewrite of the MimeStreamParser. The patch does also provide a rewrite of the MimeStreamParser itself, based on the MimeTokenStream.
> > Pull parsers are technically a little bit more difficult. However, from the users perspective, they are much more preferrable, because writing an application on top of a pull parser is much easier than based on an event handler.
> > I would like to rewrite the commons-fileupload component based on mime4j. However, as commons-fileupload provides a pull parser API, we depend on the presence of a similar API in mime4j. Not providing a pull parser API would mean, that we'd need to duplicate mime4j code into commons-fileupload, which is certainly not desirable.
>
> --
> This message is automatically generated by JIRA.
> -
> You can reply to this email to add a comment to the issue online.
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
> For additional commands, e-mail: server-dev-help@james.apache.org
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org
[jira] Updated: (MIME4J-19) Pull Parser
Posted by "Jochen Wiedmann (JIRA)" <se...@james.apache.org>.
[ https://issues.apache.org/jira/browse/MIME4J-19?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jochen Wiedmann updated MIME4J-19:
----------------------------------
Attachment: mime4j-iterator.patch
Suggested patch.
> Pull Parser
> -----------
>
> Key: MIME4J-19
> URL: https://issues.apache.org/jira/browse/MIME4J-19
> Project: Mime4j
> Issue Type: New Feature
> Affects Versions: 0.3
> Reporter: Jochen Wiedmann
> Fix For: 0.4
>
> Attachments: mime4j-iterator.patch
>
>
> The attached patch introduces a new class called MimeTokenStream, which is a "Pull Parser" for MIME documents. The class is basically a rewrite of the MimeStreamParser. The patch does also provide a rewrite of the MimeStreamParser itself, based on the MimeTokenStream.
> Pull parsers are technically a little bit more difficult. However, from the users perspective, they are much more preferrable, because writing an application on top of a pull parser is much easier than based on an event handler.
> I would like to rewrite the commons-fileupload component based on mime4j. However, as commons-fileupload provides a pull parser API, we depend on the presence of a similar API in mime4j. Not providing a pull parser API would mean, that we'd need to duplicate mime4j code into commons-fileupload, which is certainly not desirable.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org
[jira] Commented: (MIME4J-19) Pull Parser
Posted by "Robert Burrell Donkin (JIRA)" <se...@james.apache.org>.
[ https://issues.apache.org/jira/browse/MIME4J-19?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12514762 ]
Robert Burrell Donkin commented on MIME4J-19:
---------------------------------------------
Committed. Many thanks.
Unfortunately, I lack sufficient JIRA karma for Mime4J to close this issue.
Robert
> Pull Parser
> -----------
>
> Key: MIME4J-19
> URL: https://issues.apache.org/jira/browse/MIME4J-19
> Project: Mime4j
> Issue Type: New Feature
> Affects Versions: 0.3
> Reporter: Jochen Wiedmann
> Fix For: 0.4
>
> Attachments: cursored-pull.patch, mime4j-iterator.patch
>
>
> The attached patch introduces a new class called MimeTokenStream, which is a "Pull Parser" for MIME documents. The class is basically a rewrite of the MimeStreamParser. The patch does also provide a rewrite of the MimeStreamParser itself, based on the MimeTokenStream.
> Pull parsers are technically a little bit more difficult. However, from the users perspective, they are much more preferrable, because writing an application on top of a pull parser is much easier than based on an event handler.
> I would like to rewrite the commons-fileupload component based on mime4j. However, as commons-fileupload provides a pull parser API, we depend on the presence of a similar API in mime4j. Not providing a pull parser API would mean, that we'd need to duplicate mime4j code into commons-fileupload, which is certainly not desirable.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org
[jira] Commented: (MIME4J-19) Pull Parser
Posted by "Robert Burrell Donkin (JIRA)" <se...@james.apache.org>.
[ https://issues.apache.org/jira/browse/MIME4J-19?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12514756 ]
Robert Burrell Donkin commented on MIME4J-19:
---------------------------------------------
I'm very keen to see this included in the code base.
Is anyone likely to get to this in the next day or two?
Alternatively, would it be cool if I just dived in, tidied up and committed the patch?
Robert
> Pull Parser
> -----------
>
> Key: MIME4J-19
> URL: https://issues.apache.org/jira/browse/MIME4J-19
> Project: Mime4j
> Issue Type: New Feature
> Affects Versions: 0.3
> Reporter: Jochen Wiedmann
> Fix For: 0.4
>
> Attachments: cursored-pull.patch, mime4j-iterator.patch
>
>
> The attached patch introduces a new class called MimeTokenStream, which is a "Pull Parser" for MIME documents. The class is basically a rewrite of the MimeStreamParser. The patch does also provide a rewrite of the MimeStreamParser itself, based on the MimeTokenStream.
> Pull parsers are technically a little bit more difficult. However, from the users perspective, they are much more preferrable, because writing an application on top of a pull parser is much easier than based on an event handler.
> I would like to rewrite the commons-fileupload component based on mime4j. However, as commons-fileupload provides a pull parser API, we depend on the presence of a similar API in mime4j. Not providing a pull parser API would mean, that we'd need to duplicate mime4j code into commons-fileupload, which is certainly not desirable.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org
[jira] Commented: (MIME4J-19) Pull Parser
Posted by "Robert Burrell Donkin (JIRA)" <se...@james.apache.org>.
[ https://issues.apache.org/jira/browse/MIME4J-19?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12514758 ]
Robert Burrell Donkin commented on MIME4J-19:
---------------------------------------------
Apologies for the SPAM (missed an earlier email)
I'm preparing to commit this now.
Robert
> Pull Parser
> -----------
>
> Key: MIME4J-19
> URL: https://issues.apache.org/jira/browse/MIME4J-19
> Project: Mime4j
> Issue Type: New Feature
> Affects Versions: 0.3
> Reporter: Jochen Wiedmann
> Fix For: 0.4
>
> Attachments: cursored-pull.patch, mime4j-iterator.patch
>
>
> The attached patch introduces a new class called MimeTokenStream, which is a "Pull Parser" for MIME documents. The class is basically a rewrite of the MimeStreamParser. The patch does also provide a rewrite of the MimeStreamParser itself, based on the MimeTokenStream.
> Pull parsers are technically a little bit more difficult. However, from the users perspective, they are much more preferrable, because writing an application on top of a pull parser is much easier than based on an event handler.
> I would like to rewrite the commons-fileupload component based on mime4j. However, as commons-fileupload provides a pull parser API, we depend on the presence of a similar API in mime4j. Not providing a pull parser API would mean, that we'd need to duplicate mime4j code into commons-fileupload, which is certainly not desirable.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org
[jira] Commented: (MIME4J-19) Pull Parser
Posted by "Jochen Wiedmann (JIRA)" <se...@james.apache.org>.
[ https://issues.apache.org/jira/browse/MIME4J-19?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12514767 ]
Jochen Wiedmann commented on MIME4J-19:
---------------------------------------
Robert, as far as I can tell, you committed my original patch and not yours. Is that intentionally?
> Pull Parser
> -----------
>
> Key: MIME4J-19
> URL: https://issues.apache.org/jira/browse/MIME4J-19
> Project: Mime4j
> Issue Type: New Feature
> Affects Versions: 0.3
> Reporter: Jochen Wiedmann
> Fix For: 0.4
>
> Attachments: cursored-pull.patch, mime4j-iterator.patch
>
>
> The attached patch introduces a new class called MimeTokenStream, which is a "Pull Parser" for MIME documents. The class is basically a rewrite of the MimeStreamParser. The patch does also provide a rewrite of the MimeStreamParser itself, based on the MimeTokenStream.
> Pull parsers are technically a little bit more difficult. However, from the users perspective, they are much more preferrable, because writing an application on top of a pull parser is much easier than based on an event handler.
> I would like to rewrite the commons-fileupload component based on mime4j. However, as commons-fileupload provides a pull parser API, we depend on the presence of a similar API in mime4j. Not providing a pull parser API would mean, that we'd need to duplicate mime4j code into commons-fileupload, which is certainly not desirable.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org
Re: JIRA permissions UPDATED! (Was: [jira] Assigned: (MIME4J-19) Pull Parser)
Posted by Robert Burrell Donkin <ro...@gmail.com>.
On 7/24/07, norman <no...@apache.org> wrote:
> Thx to get rid of this :-)
+1
- robert
---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org
Re: JIRA permissions UPDATED! (Was: [jira] Assigned: (MIME4J-19)
Pull Parser)
Posted by norman <no...@apache.org>.
Thx to get rid of this :-)
bye
Norman
Am Dienstag, den 24.07.2007, 00:40 +0200 schrieb Stefano Bagnara:
> Jochen Wiedmann (JIRA) ha scritto:
> > [ https://issues.apache.org/jira/browse/MIME4J-19?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
> >
> > Jochen Wiedmann reassigned MIME4J-19:
> > -------------------------------------
> >
> > Assignee: Robert Burrell Donkin
> >
> > Robert, I gave you edit rights for mime4j. A question to the group: Wouldn't it be better, if the role "james-developers" had edit permissions?
>
> I had a look at this, and it was a real mess ;-)
>
> So I rewrote the whole schema permission for JAMES projects (JAMES,
> POSTAGE, JSIEVE, JSPF, MIME4J, MAILET)
>
> - created a new group names james-pmc including the james-pmc members.
>
> - updated the james-developers to include every member previously listed
> in a committer or contributor role for one of the above projects.
>
> - removed user-specific permissions for every project
>
> - added "JIRA administrator" and "JIRA pmc" roles to the james-pmc group.
>
> - added "JIRA committer" and "JIRA contributor" roles to the
> james-developers group.
>
> - left the permission scheme to the "Standard" ASF permission scheme.
>
>
> I hope this is simple enough to be better mantained in future.
>
> In summary the biggest change is that I gave much more power to our PMCs
> (administration rights on the JAMES projects seems the right thing to
> me). Previously only jira-administrators could have done substantial
> changes to JAMES projects.
>
> Here is the current list of james-developers members:
> ----
> bago
> brainlounge
> charles_#_benett1.demon.co.uk
> danny_#_apache.org
> hilmer_#_apache.org
> jefft
> joachimdraeger
> jw_#_inovem.com
> niklas_#_trillian.se
> noel
> norman
> robertburrelldonkin
> sbrewin_#_apache.org
> serge
> vincenzo
> -----
>
> Here is the current list of james-pmc members:
> ----
> bago
> brainlounge
> danny_#_apache.org
> hilmer_#_apache.org
> noel
> norman
> robertburrelldonkin
> sbrewin_#_apache.org
> serge
> vincenzo
> -----
>
> If something is wrong feel free to insult me, you'll be
> ignor^H^H^H^H^H^H^H^H I'll fix it ;-)
>
> Stefano
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
> For additional commands, e-mail: server-dev-help@james.apache.org
>
>
> !DSPAM:1,46a52ecc240371200712141!
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org
JIRA permissions UPDATED! (Was: [jira] Assigned: (MIME4J-19) Pull
Parser)
Posted by Stefano Bagnara <ap...@bago.org>.
Jochen Wiedmann (JIRA) ha scritto:
> [ https://issues.apache.org/jira/browse/MIME4J-19?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
>
> Jochen Wiedmann reassigned MIME4J-19:
> -------------------------------------
>
> Assignee: Robert Burrell Donkin
>
> Robert, I gave you edit rights for mime4j. A question to the group: Wouldn't it be better, if the role "james-developers" had edit permissions?
I had a look at this, and it was a real mess ;-)
So I rewrote the whole schema permission for JAMES projects (JAMES,
POSTAGE, JSIEVE, JSPF, MIME4J, MAILET)
- created a new group names james-pmc including the james-pmc members.
- updated the james-developers to include every member previously listed
in a committer or contributor role for one of the above projects.
- removed user-specific permissions for every project
- added "JIRA administrator" and "JIRA pmc" roles to the james-pmc group.
- added "JIRA committer" and "JIRA contributor" roles to the
james-developers group.
- left the permission scheme to the "Standard" ASF permission scheme.
I hope this is simple enough to be better mantained in future.
In summary the biggest change is that I gave much more power to our PMCs
(administration rights on the JAMES projects seems the right thing to
me). Previously only jira-administrators could have done substantial
changes to JAMES projects.
Here is the current list of james-developers members:
----
bago
brainlounge
charles_#_benett1.demon.co.uk
danny_#_apache.org
hilmer_#_apache.org
jefft
joachimdraeger
jw_#_inovem.com
niklas_#_trillian.se
noel
norman
robertburrelldonkin
sbrewin_#_apache.org
serge
vincenzo
-----
Here is the current list of james-pmc members:
----
bago
brainlounge
danny_#_apache.org
hilmer_#_apache.org
noel
norman
robertburrelldonkin
sbrewin_#_apache.org
serge
vincenzo
-----
If something is wrong feel free to insult me, you'll be
ignor^H^H^H^H^H^H^H^H I'll fix it ;-)
Stefano
---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org
[jira] Assigned: (MIME4J-19) Pull Parser
Posted by "Jochen Wiedmann (JIRA)" <se...@james.apache.org>.
[ https://issues.apache.org/jira/browse/MIME4J-19?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jochen Wiedmann reassigned MIME4J-19:
-------------------------------------
Assignee: Robert Burrell Donkin
Robert, I gave you edit rights for mime4j. A question to the group: Wouldn't it be better, if the role "james-developers" had edit permissions?
> Pull Parser
> -----------
>
> Key: MIME4J-19
> URL: https://issues.apache.org/jira/browse/MIME4J-19
> Project: Mime4j
> Issue Type: New Feature
> Affects Versions: 0.3
> Reporter: Jochen Wiedmann
> Assignee: Robert Burrell Donkin
> Fix For: 0.4
>
> Attachments: cursored-pull.patch, mime4j-iterator.patch
>
>
> The attached patch introduces a new class called MimeTokenStream, which is a "Pull Parser" for MIME documents. The class is basically a rewrite of the MimeStreamParser. The patch does also provide a rewrite of the MimeStreamParser itself, based on the MimeTokenStream.
> Pull parsers are technically a little bit more difficult. However, from the users perspective, they are much more preferrable, because writing an application on top of a pull parser is much easier than based on an event handler.
> I would like to rewrite the commons-fileupload component based on mime4j. However, as commons-fileupload provides a pull parser API, we depend on the presence of a similar API in mime4j. Not providing a pull parser API would mean, that we'd need to duplicate mime4j code into commons-fileupload, which is certainly not desirable.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org
[jira] Updated: (MIME4J-19) Pull Parser
Posted by "Robert Burrell Donkin (JIRA)" <se...@james.apache.org>.
[ https://issues.apache.org/jira/browse/MIME4J-19?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Robert Burrell Donkin updated MIME4J-19:
----------------------------------------
Attachment: cursored-pull.patch
A variation I've been working on: this factors most of the stream manipulation behind a Cursor instance. I want to be able to parse ByteBuffers as well as streams. This patch isn't finished (needs javadocs etc) and the cursor API will need some changes but it gives a reasonable idea of the general direction.
> Pull Parser
> -----------
>
> Key: MIME4J-19
> URL: https://issues.apache.org/jira/browse/MIME4J-19
> Project: Mime4j
> Issue Type: New Feature
> Affects Versions: 0.3
> Reporter: Jochen Wiedmann
> Fix For: 0.4
>
> Attachments: cursored-pull.patch, mime4j-iterator.patch
>
>
> The attached patch introduces a new class called MimeTokenStream, which is a "Pull Parser" for MIME documents. The class is basically a rewrite of the MimeStreamParser. The patch does also provide a rewrite of the MimeStreamParser itself, based on the MimeTokenStream.
> Pull parsers are technically a little bit more difficult. However, from the users perspective, they are much more preferrable, because writing an application on top of a pull parser is much easier than based on an event handler.
> I would like to rewrite the commons-fileupload component based on mime4j. However, as commons-fileupload provides a pull parser API, we depend on the presence of a similar API in mime4j. Not providing a pull parser API would mean, that we'd need to duplicate mime4j code into commons-fileupload, which is certainly not desirable.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org
[jira] Commented: (MIME4J-19) Pull Parser
Posted by "Robert Burrell Donkin (JIRA)" <se...@james.apache.org>.
[ https://issues.apache.org/jira/browse/MIME4J-19?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12515805 ]
Robert Burrell Donkin commented on MIME4J-19:
---------------------------------------------
We've been discussing whether to change Cursor into a minimal pull parser to simplify the API. The Cursor would read header fields and parts boundaries without processing them (with the exception of reading MIME boundary information). The Cursor would not descend into embedded mail messages.
> Pull Parser
> -----------
>
> Key: MIME4J-19
> URL: https://issues.apache.org/jira/browse/MIME4J-19
> Project: Mime4j
> Issue Type: New Feature
> Affects Versions: 0.3
> Reporter: Jochen Wiedmann
> Assignee: Robert Burrell Donkin
> Fix For: 0.4
>
> Attachments: cursored-pull.patch, mime4j-iterator.patch
>
>
> The attached patch introduces a new class called MimeTokenStream, which is a "Pull Parser" for MIME documents. The class is basically a rewrite of the MimeStreamParser. The patch does also provide a rewrite of the MimeStreamParser itself, based on the MimeTokenStream.
> Pull parsers are technically a little bit more difficult. However, from the users perspective, they are much more preferrable, because writing an application on top of a pull parser is much easier than based on an event handler.
> I would like to rewrite the commons-fileupload component based on mime4j. However, as commons-fileupload provides a pull parser API, we depend on the presence of a similar API in mime4j. Not providing a pull parser API would mean, that we'd need to duplicate mime4j code into commons-fileupload, which is certainly not desirable.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org
Re: [jira] Commented: (MIME4J-19) Pull Parser
Posted by Stefano Bagnara <ap...@bago.org>.
Robert Burrell Donkin (JIRA) ha scritto:
> [ https://issues.apache.org/jira/browse/MIME4J-19?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12513017 ]
>
> Robert Burrell Donkin commented on MIME4J-19:
> ---------------------------------------------
>
> I'm very, very keen to see this patch included in the code base.
>
> I'm working on factoring out a cursor so that the same state machine can be used for both byte buffers and input streams. This should allow me to use mime4j correctly parse the byte arrays used in the current IMAP implementation. This refactoring would also make it easier to add experimental new algorithms to parse large messages more efficiently.
+1 Sounds like the best plan.
Stefano
---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org
Re: [jira] Commented: (MIME4J-19) Pull Parser
Posted by Robert Burrell Donkin <ro...@gmail.com>.
On 7/19/07, norman <no...@apache.org> wrote:
> Am Mittwoch, den 18.07.2007, 22:51 +0100 schrieb robert burrell donkin:
> > On 7/18/07, Norman Maurer <no...@apache.org> wrote:
> > > Just go ahead and commit the patch if you want. My time is very limited at the moment.
> >
> > anything else i need to check? (other than that the tests run)
> >
> > what about those additional emails?
> >
> > - robert
>
>
> Well if the tests pass I think it worth to include it.
oops missed this email :-/
- robert
---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org
Re: [jira] Commented: (MIME4J-19) Pull Parser
Posted by norman <no...@apache.org>.
Am Mittwoch, den 18.07.2007, 22:51 +0100 schrieb robert burrell donkin:
> On 7/18/07, Norman Maurer <no...@apache.org> wrote:
> > Just go ahead and commit the patch if you want. My time is very limited at the moment.
>
> anything else i need to check? (other than that the tests run)
>
> what about those additional emails?
>
> - robert
Well if the tests pass I think it worth to include it.
bye
Norman
---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org
Re: [jira] Commented: (MIME4J-19) Pull Parser
Posted by robert burrell donkin <ro...@gmail.com>.
On 7/18/07, Norman Maurer <no...@apache.org> wrote:
> Just go ahead and commit the patch if you want. My time is very limited at the moment.
anything else i need to check? (other than that the tests run)
what about those additional emails?
- robert
---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org
Re: [jira] Commented: (MIME4J-19) Pull Parser
Posted by Norman Maurer <no...@apache.org>.
Just go ahead and commit the patch if you want. My time is very limited at the moment.
bye
Norman
On Mon, 16 Jul 2007 13:30:04 -0700 (PDT), "Robert Burrell Donkin (JIRA)" <se...@james.apache.org> wrote:
>
> [
> https://issues.apache.org/jira/browse/MIME4J-19?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12513017
> ]
>
> Robert Burrell Donkin commented on MIME4J-19:
> ---------------------------------------------
>
> I'm very, very keen to see this patch included in the code base.
>
> I'm working on factoring out a cursor so that the same state machine can
> be used for both byte buffers and input streams. This should allow me to
> use mime4j correctly parse the byte arrays used in the current IMAP
> implementation. This refactoring would also make it easier to add
> experimental new algorithms to parse large messages more efficiently.
>
> Robert
>
>> Pull Parser
>> -----------
>>
>> Key: MIME4J-19
>> URL: https://issues.apache.org/jira/browse/MIME4J-19
>> Project: Mime4j
>> Issue Type: New Feature
>> Affects Versions: 0.3
>> Reporter: Jochen Wiedmann
>> Fix For: 0.4
>>
>> Attachments: mime4j-iterator.patch
>>
>>
>> The attached patch introduces a new class called MimeTokenStream, which
> is a "Pull Parser" for MIME documents. The class is basically a rewrite of
> the MimeStreamParser. The patch does also provide a rewrite of the
> MimeStreamParser itself, based on the MimeTokenStream.
>> Pull parsers are technically a little bit more difficult. However, from
> the users perspective, they are much more preferrable, because writing an
> application on top of a pull parser is much easier than based on an event
> handler.
>> I would like to rewrite the commons-fileupload component based on
> mime4j. However, as commons-fileupload provides a pull parser API, we
> depend on the presence of a similar API in mime4j. Not providing a pull
> parser API would mean, that we'd need to duplicate mime4j code into
> commons-fileupload, which is certainly not desirable.
>
> --
> This message is automatically generated by JIRA.
> -
> You can reply to this email to add a comment to the issue online.
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
> For additional commands, e-mail: server-dev-help@james.apache.org
>
>
> !DSPAM:1,469bd570240375636457488!
---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org
[jira] Commented: (MIME4J-19) Pull Parser
Posted by "Robert Burrell Donkin (JIRA)" <se...@james.apache.org>.
[ https://issues.apache.org/jira/browse/MIME4J-19?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12513017 ]
Robert Burrell Donkin commented on MIME4J-19:
---------------------------------------------
I'm very, very keen to see this patch included in the code base.
I'm working on factoring out a cursor so that the same state machine can be used for both byte buffers and input streams. This should allow me to use mime4j correctly parse the byte arrays used in the current IMAP implementation. This refactoring would also make it easier to add experimental new algorithms to parse large messages more efficiently.
Robert
> Pull Parser
> -----------
>
> Key: MIME4J-19
> URL: https://issues.apache.org/jira/browse/MIME4J-19
> Project: Mime4j
> Issue Type: New Feature
> Affects Versions: 0.3
> Reporter: Jochen Wiedmann
> Fix For: 0.4
>
> Attachments: mime4j-iterator.patch
>
>
> The attached patch introduces a new class called MimeTokenStream, which is a "Pull Parser" for MIME documents. The class is basically a rewrite of the MimeStreamParser. The patch does also provide a rewrite of the MimeStreamParser itself, based on the MimeTokenStream.
> Pull parsers are technically a little bit more difficult. However, from the users perspective, they are much more preferrable, because writing an application on top of a pull parser is much easier than based on an event handler.
> I would like to rewrite the commons-fileupload component based on mime4j. However, as commons-fileupload provides a pull parser API, we depend on the presence of a similar API in mime4j. Not providing a pull parser API would mean, that we'd need to duplicate mime4j code into commons-fileupload, which is certainly not desirable.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org
[jira] Closed: (MIME4J-19) Pull Parser
Posted by "Robert Burrell Donkin (JIRA)" <se...@james.apache.org>.
[ https://issues.apache.org/jira/browse/MIME4J-19?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Robert Burrell Donkin closed MIME4J-19.
---------------------------------------
Resolution: Fixed
Think this is done with now
> Pull Parser
> -----------
>
> Key: MIME4J-19
> URL: https://issues.apache.org/jira/browse/MIME4J-19
> Project: Mime4j
> Issue Type: New Feature
> Affects Versions: 0.3
> Reporter: Jochen Wiedmann
> Assignee: Robert Burrell Donkin
> Fix For: 0.4
>
> Attachments: cursored-pull.patch, mime4j-iterator.patch
>
>
> The attached patch introduces a new class called MimeTokenStream, which is a "Pull Parser" for MIME documents. The class is basically a rewrite of the MimeStreamParser. The patch does also provide a rewrite of the MimeStreamParser itself, based on the MimeTokenStream.
> Pull parsers are technically a little bit more difficult. However, from the users perspective, they are much more preferrable, because writing an application on top of a pull parser is much easier than based on an event handler.
> I would like to rewrite the commons-fileupload component based on mime4j. However, as commons-fileupload provides a pull parser API, we depend on the presence of a similar API in mime4j. Not providing a pull parser API would mean, that we'd need to duplicate mime4j code into commons-fileupload, which is certainly not desirable.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org
[jira] Commented: (MIME4J-19) Pull Parser
Posted by "Robert Burrell Donkin (JIRA)" <se...@james.apache.org>.
[ https://issues.apache.org/jira/browse/MIME4J-19?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12515800 ]
Robert Burrell Donkin commented on MIME4J-19:
---------------------------------------------
I committed your patch first. I think committed changes similar to those outlined in my patch. This should make the audit trail clearer.
> Pull Parser
> -----------
>
> Key: MIME4J-19
> URL: https://issues.apache.org/jira/browse/MIME4J-19
> Project: Mime4j
> Issue Type: New Feature
> Affects Versions: 0.3
> Reporter: Jochen Wiedmann
> Assignee: Robert Burrell Donkin
> Fix For: 0.4
>
> Attachments: cursored-pull.patch, mime4j-iterator.patch
>
>
> The attached patch introduces a new class called MimeTokenStream, which is a "Pull Parser" for MIME documents. The class is basically a rewrite of the MimeStreamParser. The patch does also provide a rewrite of the MimeStreamParser itself, based on the MimeTokenStream.
> Pull parsers are technically a little bit more difficult. However, from the users perspective, they are much more preferrable, because writing an application on top of a pull parser is much easier than based on an event handler.
> I would like to rewrite the commons-fileupload component based on mime4j. However, as commons-fileupload provides a pull parser API, we depend on the presence of a similar API in mime4j. Not providing a pull parser API would mean, that we'd need to duplicate mime4j code into commons-fileupload, which is certainly not desirable.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org