You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2022/11/17 19:14:32 UTC
[GitHub] [hudi] zhuanshenbsj1 opened a new pull request, #7232: [HUDI-5235] clustering target size should larger than small file limit
zhuanshenbsj1 opened a new pull request, #7232:
URL: https://github.com/apache/hudi/pull/7232
### Change Logs
Related to [HUDI-5235](https://issues.apache.org/jira/browse/HUDI-5235)
1. Need to add a check between CLUSTERING_PLAN_STRATEGY_TARGET_FILE_MAX_BYTES and CLUSTERING_PLAN_STRATEGY_SMALL_FILE_LIMIT，otherwise, merged files will always fail to meet the clustering requirements
2. Clustering Plan has check the size by CLUSTERING_PLAN_STRATEGY_TARGET_FILE_MAX_BYTES already ,there is no need to check by PARQUET_MAX_FILE_SIZE again , Also this is a clustering operator not a stream writer operator. In addition，target_size is calculated by the file size on hdfs（compressed ）, while parquet_size calculates the size by streaming writes(uncompressed ). A clustering group often combines multiple files, it maybe causing some unknown bugs.
### Impact
_Describe any public API or user-facing feature change or any performance impact._
### Risk level (write none, low medium or high below)
_If medium or high, explain what verification was done to mitigate the risks._
### Documentation Update
_Describe any necessary documentation update if there is any new feature, config, or user-facing change_
- _The config description must be updated if new configs are added or the default value of the configs are changed_
- _Any new feature or user-facing change requires updating the Hudi website. Please create a Jira ticket, attach the
ticket number here and follow the [instruction](https://hudi.apache.org/contribute/developer-setup#website) to make
changes to the website._
### Contributor's checklist
- [ ] Read through [contributor's guide](https://hudi.apache.org/contribute/how-to-contribute)
- [ ] Change Logs and Impact were stated clearly
- [ ] Adequate tests were added if applicable
- [ ] CI passed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #7232: [HUDI-5235] clustering target size should larger than small file limit
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #7232:
URL: https://github.com/apache/hudi/pull/7232#issuecomment-1320061513
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "5cf7bc911e90600a0f7afba4a6e0b3cd6a5cbdc7",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=13087",
"triggerID" : "5cf7bc911e90600a0f7afba4a6e0b3cd6a5cbdc7",
"triggerType" : "PUSH"
}, {
"hash" : "df2799b68d31b6df961c21eba69992642f2cef48",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=13114",
"triggerID" : "df2799b68d31b6df961c21eba69992642f2cef48",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 5cf7bc911e90600a0f7afba4a6e0b3cd6a5cbdc7 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=13087)
* df2799b68d31b6df961c21eba69992642f2cef48 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=13114)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #7232: [HUDI-5235] clustering target size should larger than small file limit
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #7232:
URL: https://github.com/apache/hudi/pull/7232#issuecomment-1320051391
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "5cf7bc911e90600a0f7afba4a6e0b3cd6a5cbdc7",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=13087",
"triggerID" : "5cf7bc911e90600a0f7afba4a6e0b3cd6a5cbdc7",
"triggerType" : "PUSH"
}, {
"hash" : "df2799b68d31b6df961c21eba69992642f2cef48",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "df2799b68d31b6df961c21eba69992642f2cef48",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 5cf7bc911e90600a0f7afba4a6e0b3cd6a5cbdc7 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=13087)
* df2799b68d31b6df961c21eba69992642f2cef48 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #7232: [HUDI-5235] clustering target size should larger than small file limit
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #7232:
URL: https://github.com/apache/hudi/pull/7232#issuecomment-1398071029
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "5cf7bc911e90600a0f7afba4a6e0b3cd6a5cbdc7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=13087",
"triggerID" : "5cf7bc911e90600a0f7afba4a6e0b3cd6a5cbdc7",
"triggerType" : "PUSH"
}, {
"hash" : "df2799b68d31b6df961c21eba69992642f2cef48",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=13114",
"triggerID" : "df2799b68d31b6df961c21eba69992642f2cef48",
"triggerType" : "PUSH"
}, {
"hash" : "08239e5b8d4d49da4b5b3d814233251f81b3d0b0",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14397",
"triggerID" : "08239e5b8d4d49da4b5b3d814233251f81b3d0b0",
"triggerType" : "PUSH"
}, {
"hash" : "08239e5b8d4d49da4b5b3d814233251f81b3d0b0",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14451",
"triggerID" : "1396672512",
"triggerType" : "MANUAL"
}, {
"hash" : "08239e5b8d4d49da4b5b3d814233251f81b3d0b0",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14474",
"triggerID" : "1397856020",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* 08239e5b8d4d49da4b5b3d814233251f81b3d0b0 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14397) Azure: [CANCELED](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14451) Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14474)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] danny0405 commented on a diff in pull request #7232: [HUDI-5235] clustering target size should larger than small file limit
Posted by GitBox <gi...@apache.org>.
danny0405 commented on code in PR #7232:
URL: https://github.com/apache/hudi/pull/7232#discussion_r1025957414
##########
hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/sink/clustering/ClusteringOperator.java:
##########
@@ -136,7 +136,13 @@ public ClusteringOperator(Configuration conf, RowType rowType) {
// override max parquet file size in conf
this.conf.setLong(HoodieStorageConfig.PARQUET_MAX_FILE_SIZE.key(),
- this.conf.getLong(FlinkOptions.CLUSTERING_PLAN_STRATEGY_TARGET_FILE_MAX_BYTES));
+ Integer.MAX_VALUE);
+
+ // target size should larger than small file limit
+ this.conf.setLong(FlinkOptions.CLUSTERING_PLAN_STRATEGY_SMALL_FILE_LIMIT.key(),
+ this.conf.getLong(FlinkOptions.CLUSTERING_PLAN_STRATEGY_TARGET_FILE_MAX_BYTES) > this.conf.getLong(FlinkOptions.CLUSTERING_PLAN_STRATEGY_SMALL_FILE_LIMIT) ?
+ this.conf.getLong(FlinkOptions.CLUSTERING_PLAN_STRATEGY_SMALL_FILE_LIMIT) :
Review Comment:
Seems reasonable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #7232: [HUDI-5235] clustering target size should larger than small file limit
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #7232:
URL: https://github.com/apache/hudi/pull/7232#issuecomment-1319101891
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "5cf7bc911e90600a0f7afba4a6e0b3cd6a5cbdc7",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=13087",
"triggerID" : "5cf7bc911e90600a0f7afba4a6e0b3cd6a5cbdc7",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 5cf7bc911e90600a0f7afba4a6e0b3cd6a5cbdc7 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=13087)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #7232: [HUDI-5235] clustering target size should larger than small file limit
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #7232:
URL: https://github.com/apache/hudi/pull/7232#issuecomment-1387252457
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "5cf7bc911e90600a0f7afba4a6e0b3cd6a5cbdc7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=13087",
"triggerID" : "5cf7bc911e90600a0f7afba4a6e0b3cd6a5cbdc7",
"triggerType" : "PUSH"
}, {
"hash" : "df2799b68d31b6df961c21eba69992642f2cef48",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=13114",
"triggerID" : "df2799b68d31b6df961c21eba69992642f2cef48",
"triggerType" : "PUSH"
}, {
"hash" : "08239e5b8d4d49da4b5b3d814233251f81b3d0b0",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "08239e5b8d4d49da4b5b3d814233251f81b3d0b0",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* df2799b68d31b6df961c21eba69992642f2cef48 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=13114)
* 08239e5b8d4d49da4b5b3d814233251f81b3d0b0 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] zhuanshenbsj1 commented on pull request #7232: [HUDI-5235] clustering target size should larger than small file limit
Posted by GitBox <gi...@apache.org>.
zhuanshenbsj1 commented on PR #7232:
URL: https://github.com/apache/hudi/pull/7232#issuecomment-1396672512
@hudi-bot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #7232: [HUDI-5235] clustering target size should larger than small file limit
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #7232:
URL: https://github.com/apache/hudi/pull/7232#issuecomment-1387264362
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "5cf7bc911e90600a0f7afba4a6e0b3cd6a5cbdc7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=13087",
"triggerID" : "5cf7bc911e90600a0f7afba4a6e0b3cd6a5cbdc7",
"triggerType" : "PUSH"
}, {
"hash" : "df2799b68d31b6df961c21eba69992642f2cef48",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=13114",
"triggerID" : "df2799b68d31b6df961c21eba69992642f2cef48",
"triggerType" : "PUSH"
}, {
"hash" : "08239e5b8d4d49da4b5b3d814233251f81b3d0b0",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14397",
"triggerID" : "08239e5b8d4d49da4b5b3d814233251f81b3d0b0",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* df2799b68d31b6df961c21eba69992642f2cef48 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=13114)
* 08239e5b8d4d49da4b5b3d814233251f81b3d0b0 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14397)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #7232: [HUDI-5235] clustering target size should larger than small file limit
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #7232:
URL: https://github.com/apache/hudi/pull/7232#issuecomment-1396749385
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "5cf7bc911e90600a0f7afba4a6e0b3cd6a5cbdc7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=13087",
"triggerID" : "5cf7bc911e90600a0f7afba4a6e0b3cd6a5cbdc7",
"triggerType" : "PUSH"
}, {
"hash" : "df2799b68d31b6df961c21eba69992642f2cef48",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=13114",
"triggerID" : "df2799b68d31b6df961c21eba69992642f2cef48",
"triggerType" : "PUSH"
}, {
"hash" : "08239e5b8d4d49da4b5b3d814233251f81b3d0b0",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14397",
"triggerID" : "08239e5b8d4d49da4b5b3d814233251f81b3d0b0",
"triggerType" : "PUSH"
}, {
"hash" : "08239e5b8d4d49da4b5b3d814233251f81b3d0b0",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14451",
"triggerID" : "1396672512",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* 08239e5b8d4d49da4b5b3d814233251f81b3d0b0 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14397) Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14451)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #7232: [HUDI-5235] clustering target size should larger than small file limit
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #7232:
URL: https://github.com/apache/hudi/pull/7232#issuecomment-1397857797
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "5cf7bc911e90600a0f7afba4a6e0b3cd6a5cbdc7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=13087",
"triggerID" : "5cf7bc911e90600a0f7afba4a6e0b3cd6a5cbdc7",
"triggerType" : "PUSH"
}, {
"hash" : "df2799b68d31b6df961c21eba69992642f2cef48",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=13114",
"triggerID" : "df2799b68d31b6df961c21eba69992642f2cef48",
"triggerType" : "PUSH"
}, {
"hash" : "08239e5b8d4d49da4b5b3d814233251f81b3d0b0",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14397",
"triggerID" : "08239e5b8d4d49da4b5b3d814233251f81b3d0b0",
"triggerType" : "PUSH"
}, {
"hash" : "08239e5b8d4d49da4b5b3d814233251f81b3d0b0",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14451",
"triggerID" : "1396672512",
"triggerType" : "MANUAL"
}, {
"hash" : "08239e5b8d4d49da4b5b3d814233251f81b3d0b0",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14474",
"triggerID" : "1397856020",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* 08239e5b8d4d49da4b5b3d814233251f81b3d0b0 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14397) Azure: [CANCELED](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14451) Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14474)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] danny0405 commented on a diff in pull request #7232: [HUDI-5235] clustering target size should larger than small file limit
Posted by GitBox <gi...@apache.org>.
danny0405 commented on code in PR #7232:
URL: https://github.com/apache/hudi/pull/7232#discussion_r1025957285
##########
hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/sink/clustering/ClusteringOperator.java:
##########
@@ -136,7 +136,13 @@ public ClusteringOperator(Configuration conf, RowType rowType) {
// override max parquet file size in conf
this.conf.setLong(HoodieStorageConfig.PARQUET_MAX_FILE_SIZE.key(),
- this.conf.getLong(FlinkOptions.CLUSTERING_PLAN_STRATEGY_TARGET_FILE_MAX_BYTES));
+ Integer.MAX_VALUE);
Review Comment:
Don' think it is right yet.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] zhuanshenbsj1 commented on a diff in pull request #7232: [HUDI-5235] clustering target size should larger than small file limit
Posted by GitBox <gi...@apache.org>.
zhuanshenbsj1 commented on code in PR #7232:
URL: https://github.com/apache/hudi/pull/7232#discussion_r1026448125
##########
hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/sink/clustering/ClusteringOperator.java:
##########
@@ -136,7 +136,13 @@ public ClusteringOperator(Configuration conf, RowType rowType) {
// override max parquet file size in conf
this.conf.setLong(HoodieStorageConfig.PARQUET_MAX_FILE_SIZE.key(),
- this.conf.getLong(FlinkOptions.CLUSTERING_PLAN_STRATEGY_TARGET_FILE_MAX_BYTES));
+ Integer.MAX_VALUE);
Review Comment:
Revert to previous.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #7232: [HUDI-5235] clustering target size should larger than small file limit
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #7232:
URL: https://github.com/apache/hudi/pull/7232#issuecomment-1320365972
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "5cf7bc911e90600a0f7afba4a6e0b3cd6a5cbdc7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=13087",
"triggerID" : "5cf7bc911e90600a0f7afba4a6e0b3cd6a5cbdc7",
"triggerType" : "PUSH"
}, {
"hash" : "df2799b68d31b6df961c21eba69992642f2cef48",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=13114",
"triggerID" : "df2799b68d31b6df961c21eba69992642f2cef48",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* df2799b68d31b6df961c21eba69992642f2cef48 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=13114)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #7232: [HUDI-5235] clustering target size should larger than small file limit
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #7232:
URL: https://github.com/apache/hudi/pull/7232#issuecomment-1319095828
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "5cf7bc911e90600a0f7afba4a6e0b3cd6a5cbdc7",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "5cf7bc911e90600a0f7afba4a6e0b3cd6a5cbdc7",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 5cf7bc911e90600a0f7afba4a6e0b3cd6a5cbdc7 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] zhuanshenbsj1 commented on pull request #7232: [HUDI-5235] clustering target size should larger than small file limit
Posted by GitBox <gi...@apache.org>.
zhuanshenbsj1 commented on PR #7232:
URL: https://github.com/apache/hudi/pull/7232#issuecomment-1397856020
@hudi-bot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #7232: [HUDI-5235] clustering target size should larger than small file limit
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #7232:
URL: https://github.com/apache/hudi/pull/7232#issuecomment-1396093107
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "5cf7bc911e90600a0f7afba4a6e0b3cd6a5cbdc7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=13087",
"triggerID" : "5cf7bc911e90600a0f7afba4a6e0b3cd6a5cbdc7",
"triggerType" : "PUSH"
}, {
"hash" : "df2799b68d31b6df961c21eba69992642f2cef48",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=13114",
"triggerID" : "df2799b68d31b6df961c21eba69992642f2cef48",
"triggerType" : "PUSH"
}, {
"hash" : "08239e5b8d4d49da4b5b3d814233251f81b3d0b0",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14397",
"triggerID" : "08239e5b8d4d49da4b5b3d814233251f81b3d0b0",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 08239e5b8d4d49da4b5b3d814233251f81b3d0b0 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14397)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #7232: [HUDI-5235] clustering target size should larger than small file limit
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #7232:
URL: https://github.com/apache/hudi/pull/7232#issuecomment-1397596345
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "5cf7bc911e90600a0f7afba4a6e0b3cd6a5cbdc7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=13087",
"triggerID" : "5cf7bc911e90600a0f7afba4a6e0b3cd6a5cbdc7",
"triggerType" : "PUSH"
}, {
"hash" : "df2799b68d31b6df961c21eba69992642f2cef48",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=13114",
"triggerID" : "df2799b68d31b6df961c21eba69992642f2cef48",
"triggerType" : "PUSH"
}, {
"hash" : "08239e5b8d4d49da4b5b3d814233251f81b3d0b0",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14397",
"triggerID" : "08239e5b8d4d49da4b5b3d814233251f81b3d0b0",
"triggerType" : "PUSH"
}, {
"hash" : "08239e5b8d4d49da4b5b3d814233251f81b3d0b0",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14451",
"triggerID" : "1396672512",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* 08239e5b8d4d49da4b5b3d814233251f81b3d0b0 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14397) Azure: [CANCELED](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14451)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] danny0405 merged pull request #7232: [HUDI-5235] clustering target size should larger than small file limit
Posted by "danny0405 (via GitHub)" <gi...@apache.org>.
danny0405 merged PR #7232:
URL: https://github.com/apache/hudi/pull/7232
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #7232: [HUDI-5235] clustering target size should larger than small file limit
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #7232:
URL: https://github.com/apache/hudi/pull/7232#issuecomment-1319281826
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "5cf7bc911e90600a0f7afba4a6e0b3cd6a5cbdc7",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=13087",
"triggerID" : "5cf7bc911e90600a0f7afba4a6e0b3cd6a5cbdc7",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 5cf7bc911e90600a0f7afba4a6e0b3cd6a5cbdc7 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=13087)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org