You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Dan Burkert (Code Review)" <ge...@cloudera.org> on 2016/09/30 21:00:28 UTC
[kudu-CR] Retry on early TimedOut error in ExternalMiniCluster::WaitForCatalogManager
Hello Adar Dembo,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/4576
to review the following change.
Change subject: Retry on early TimedOut error in ExternalMiniCluster::WaitForCatalogManager
......................................................................
Retry on early TimedOut error in ExternalMiniCluster::WaitForCatalogManager
WaitForCatalogManager loops sending a GetTableLocations RPC to a master
waiting for it to be initialized. Previously, we would early return with
an error when the RPC resulted in a TimedOut response, despite the
method having its own time out limit. This was causing at least some of
the flakiness seen in alter_table-randomized-itest.
Change-Id: I04b3a58646249a0fd549c75dc130ca9b955f35de
---
M src/kudu/integration-tests/external_mini_cluster.cc
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/76/4576/1
--
To view, visit http://gerrit.cloudera.org:8080/4576
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I04b3a58646249a0fd549c75dc130ca9b955f35de
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert <da...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
[kudu-CR] Retry on early TimedOut error in ExternalMiniCluster::WaitForCatalogManager
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change.
Change subject: Retry on early TimedOut error in ExternalMiniCluster::WaitForCatalogManager
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/4576
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I04b3a58646249a0fd549c75dc130ca9b955f35de
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert <da...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: No
[kudu-CR] Retry on early TimedOut error in ExternalMiniCluster::WaitForCatalogManager
Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has submitted this change and it was merged.
Change subject: Retry on early TimedOut error in ExternalMiniCluster::WaitForCatalogManager
......................................................................
Retry on early TimedOut error in ExternalMiniCluster::WaitForCatalogManager
WaitForCatalogManager loops sending a GetTableLocations RPC to a master
waiting for it to be initialized. Previously, we would early return with
an error when the RPC resulted in a TimedOut response, despite the
method having its own time out limit. This was causing at least some of
the flakiness seen in alter_table-randomized-itest.
Change-Id: I04b3a58646249a0fd549c75dc130ca9b955f35de
Reviewed-on: http://gerrit.cloudera.org:8080/4576
Reviewed-by: Adar Dembo <ad...@cloudera.com>
Tested-by: Kudu Jenkins
---
M src/kudu/integration-tests/external_mini_cluster.cc
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Adar Dembo: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/4576
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I04b3a58646249a0fd549c75dc130ca9b955f35de
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert <da...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins