You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "ellisms (via GitHub)" <gi...@apache.org> on 2025/03/18 20:03:49 UTC
[PR] Updating EC2 Operators and Sensors with AWS Base classes [airflow]
ellisms opened a new pull request, #47931:
URL: https://github.com/apache/airflow/pull/47931
---
Updated EC2 Operators to inherit base AWS Operator, and updated Sensors to inherit Base AWS Sensor. I did not update the Trigger, as it wasn't using the standard waiter.
Partially address #35278
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Updating EC2 Operators and Sensors with AWS Base classes [airflow]
Posted by "eladkal (via GitHub)" <gi...@apache.org>.
eladkal merged PR #47931:
URL: https://github.com/apache/airflow/pull/47931
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Updating EC2 Operators and Sensors with AWS Base classes [airflow]
Posted by "o-nikolas (via GitHub)" <gi...@apache.org>.
o-nikolas commented on code in PR #47931:
URL: https://github.com/apache/airflow/pull/47931#discussion_r2004349465
##########
providers/amazon/src/airflow/providers/amazon/aws/operators/ec2.py:
##########
@@ -51,46 +52,42 @@ class EC2StartInstanceOperator(BaseOperator):
between each instance state checks until operation is completed
Review Comment:
The above includes docs for `aws_conn_id` and `region_name` but can you include `verify` as well? The block I grabbed from previous PRs for this initiative is this one below, you can add it to all the operators here so that they're consistent:
```
:param aws_conn_id: The Airflow connection used for AWS credentials.
If this is ``None`` or empty then the default boto3 behaviour is used. If
running Airflow in a distributed manner and aws_conn_id is None or
empty, then default boto3 configuration would be used (and must be
maintained on each worker node).
:param region_name: AWS region_name. If not specified then the default boto3 behaviour is used.
:param verify: Whether or not to verify SSL certificates. See:
https://boto3.amazonaws.com/v1/documentation/api/latest/reference/core/session.html
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org