You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/02/21 11:49:25 UTC

[GitHub] [incubator-nuttx] acassis commented on a change in pull request #5571: drivers: exclude BSD components from build

acassis commented on a change in pull request #5571:
URL: https://github.com/apache/incubator-nuttx/pull/5571#discussion_r811049464



##########
File path: drivers/analog/Kconfig
##########
@@ -17,6 +17,7 @@ if ANALOG
 config ADC
 	bool "Analog-to-Digital Conversion"
 	default n
+	depends on ALLOW_BSD_COMPONENTS

Review comment:
       @jerpelea I think those file with Copyright from other people that we didn't contact need to be reviewed. In the case of adc.c for example if you run "git blame" you see that "Li Zhuoyi" contributions to the file were removed, but his copyright still there. It is an error and need to be fixed. Just putting it as BSD component will make the already complex config even more complex. How on earth people will image that to use ADC on NuttX he needs to enable BSD license?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org