[jira] [Work logged] (ARTEMIS-2558) Add the commented out args to dump the java heap on OOME

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/ARTEMIS-2558?focusedWorklogId=359416&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-359416 ]

ASF GitHub Bot logged work on ARTEMIS-2558:
-------------------------------------------

                Author: ASF GitHub Bot
            Created on: 13/Dec/19 14:13
            Start Date: 13/Dec/19 14:13
    Worklog Time Spent: 10m 
      Work Description: clebertsuconic commented on pull request #2897: ARTEMIS-2558 Add the commented out args to dump the java heap on OOME
URL: https://github.com/apache/activemq-artemis/pull/2897#discussion_r357662839
 
 

 ##########
 File path: artemis-cli/src/main/resources/org/apache/activemq/artemis/cli/commands/etc/artemis.profile
 ##########
 @@ -41,6 +41,11 @@ JAVA_ARGS="${java-opts} -XX:+PrintClassHistogram -XX:+UseG1GC -Xms512M -Xmx2G -D
 # Replace "all_pauses.log" with the file name you want to log to.
 # JAVA_ARGS="$JAVA_ARGS -XX:+PrintSafepointStatistics -XX:PrintSafepointStatisticsCount=1 -XX:+PrintGCApplicationStoppedTime -XX:+PrintGCApplicationConcurrentTime -XX:+LogVMOutput -XX:LogFile=all_pauses.log"
 
+#
+# Enables the dumping of the java heap to the file oom_dump.hprof by using the heap profiler (HPROF)
+# when a java.lang.OutOfMemoryError exception is thrown.
+# JAVA_ARGS="$JAVA_ARGS -XX:+HeapDumpOnOutOfMemoryError -XX:HeapDumpPath=${ARTEMIS_INSTANCE}/log/oom_dump.hprof"
 
 Review comment:
   timestamp would be generated based on when the broker started on this case.. not when the dump happened... 
   
   I would keep it simple here.
   
   If you want a variable name.. fine.. but other than that... you start the broker now.. it dumps 5 months from now.. the timestamp is useless.
   
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 359416)
    Time Spent: 1h 40m  (was: 1.5h)

> Add the commented out args to dump the java heap on OOME
> --------------------------------------------------------
>
>                 Key: ARTEMIS-2558
>                 URL: https://issues.apache.org/jira/browse/ARTEMIS-2558
>             Project: ActiveMQ Artemis
>          Issue Type: Improvement
>            Reporter: Domenico Bruscino
>            Priority: Major
>          Time Spent: 1h 40m
>  Remaining Estimate: 0h
>
> Would it be possible to add -XX:+HeapDumpOnOutOfMemoryError -XX:HeapDumpPath=... to the broker jvm args (as commented out).
> When a broker hits an out of memory exception, the heap dump is required to investigate. It would be useful to have it generated on the first occurrence rather than setting the arg and waiting for a second occurrence.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)