[GitHub] [beam] ibzib commented on a change in pull request #13633: [BEAM-9541] Use a single source of truth for latest Flink version in Gradle tasks.

[GitBox <gi...@apache.org>]

ibzib commented on a change in pull request #13633:
URL: https://github.com/apache/beam/pull/13633#discussion_r552183778



##########
File path: runners/flink/flink_runner.gradle
##########
@@ -108,17 +108,14 @@ test {
   if (System.getProperty("beamSurefireArgline")) {
     jvmArgs System.getProperty("beamSurefireArgline")
   }
-  // TODO Running tests of all Flink versions in parallel can be too harsh on Jenkins memory
-  // Run them serially for now, to avoid "Exit code 137", i.e. Jenkins host killing the Gradle test process
-  if (project.path == ":runners:flink:1.9") {
-    mustRunAfter(":runners:flink:1.8:test")
-  } else if (project.path == ":runners:flink:1.10") {
-    mustRunAfter(":runners:flink:1.8:test")
-    mustRunAfter(":runners:flink:1.9:test")
-  } else if (project.path == ":runners:flink:1.11") {
-    mustRunAfter(":runners:flink:1.8:test")
-    mustRunAfter(":runners:flink:1.9:test")
-    mustRunAfter(":runners:flink:1.10:test")
+  // TODO(BEAM-6418) Running tests of all Flink versions in parallel can be too harsh on Jenkins memory.
+  // Run them serially for now, to avoid "Exit code 137", i.e. Jenkins host killing the Gradle test process.
+  def flink_minor_version = project.path.split(':').last()
+  for (version in project.ext.allFlinkVersions) {
+    if (version == flink_minor_version) {
+      break
+    }
+    mustRunAfter(":runners:flink:${version}:test")

Review comment:
       Wouldn't we end up with circular dependencies, like `(1.12 mustRunAfter 1.11) && (1.11 mustRunAfter 1.12)`?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org