You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/08/04 04:33:28 UTC

[GitHub] [spark] ScrapCodes commented on a change in pull request #29334: [RFC][SPARK-32495] Update jackson versions to a maintained release, to fix various security vulnerabilities.

ScrapCodes commented on a change in pull request #29334:
URL: https://github.com/apache/spark/pull/29334#discussion_r464793132



##########
File path: core/pom.xml
##########
@@ -224,6 +224,10 @@
       <groupId>org.scala-lang</groupId>
       <artifactId>scala-library</artifactId>
     </dependency>
+    <dependency>
+      <groupId>org.scala-lang</groupId>
+      <artifactId>scala-reflect</artifactId>

Review comment:
       This is required because, jackson-scala-module underwent this change: 
   
   https://github.com/FasterXML/jackson-module-scala/commit/d6071ac4597e582b1a59b5a492ac38009e17eeb6#diff-fdc3abdfd754eeb24090dbd90aeec2ce
   
   And Spark-core uses scala-reflect library at one place.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org