You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@myfaces.apache.org by Mike Kienenberger <mk...@gmail.com> on 2006/09/15 07:12:59 UTC
Release Announcement for MyFaces Core 1.1.4
On 9/15/06, Wendy Smoak <ws...@gmail.com> wrote:
> I've added a draft release announcement to the release plan wiki page.
> (link above) If you want me to send it out, please adjust as
> necessary! (It might need a statement about what version of Tomahawk
> is compatible, and I have no idea.)
Thanks for all the work, Wendy!
Martin, you mentioned before that you had to make changes to the
javascript generated in order to achieve compatibility with JSF RI,
and that this would make 1.1.4 and later releases incompatible with
1.1.3. Could you add whatever details are appropriate on that to the
Release announcement? Maybe it's just as simple as saying that
MyFaces Core 1.1.4 is not backwards-compatible with Tomahawk 1.1.3.
Re: Release Announcement for MyFaces Core 1.1.4
Posted by Wendy Smoak <ws...@gmail.com>.
> On 9/15/06, Mike Kienenberger <mk...@gmail.com> wrote:
> > Maybe it's just as simple as saying that
> > MyFaces Core 1.1.4 is not backwards-compatible with Tomahawk 1.1.3.
On 9/14/06, Martin Marinschek <ma...@gmail.com> wrote:
> I only have a minute on the net - but yes, your last sentence is correct.
We'll need to give a reason for this. Was it done for compatibility
with the RI, or ??
--
Wendy
Re: Release Announcement for MyFaces Core 1.1.4
Posted by Martin Marinschek <ma...@gmail.com>.
Hi Mike, Wendy,
I only have a minute on the net - but yes, your last sentence is correct.
regards,
Martin
On 9/15/06, Mike Kienenberger <mk...@gmail.com> wrote:
> On 9/15/06, Wendy Smoak <ws...@gmail.com> wrote:
> > I've added a draft release announcement to the release plan wiki page.
> > (link above) If you want me to send it out, please adjust as
> > necessary! (It might need a statement about what version of Tomahawk
> > is compatible, and I have no idea.)
>
> Thanks for all the work, Wendy!
>
> Martin, you mentioned before that you had to make changes to the
> javascript generated in order to achieve compatibility with JSF RI,
> and that this would make 1.1.4 and later releases incompatible with
> 1.1.3. Could you add whatever details are appropriate on that to the
> Release announcement? Maybe it's just as simple as saying that
> MyFaces Core 1.1.4 is not backwards-compatible with Tomahawk 1.1.3.
>
--
http://www.irian.at
Your JSF powerhouse -
JSF Consulting, Development and
Courses in English and German
Professional Support for Apache MyFaces
Re: Release Announcement for MyFaces Core 1.1.4
Posted by Martin Marinschek <ma...@gmail.com>.
I've answered on the other thread.
regards,
Martin
On 9/17/06, Wendy Smoak <ws...@gmail.com> wrote:
> On 9/17/06, Martin Marinschek <ma...@gmail.com> wrote:
>
> > When you told me that you reverted the getScrolling stuff, I
> > remembered that I also changed the name of the clear..._formName()
> > method. Now if old tomahawk 1.1.3 components expect to call this
> > clear-method, they'd have a java-script exception.
> >
> > So essentially - if you use an h:form and a t:commandLink, you should
> > see this exception, apart from that, you should be safe.
>
> I found the <h:form>...<t:commandLink> construct in a few of the
> 'simple' examples: forceId.jsp, dataTable.jsp, dataScroller.jsp,
> countryTableForm.jsp.
>
> Clicking around [1], I don't see any JavaScript errors [2]. Searching
> across the Tomahawk 1.1.3 'core' module for the word 'clear' doesn't
> turn up anything that looks suspicious to me.
>
> What can I do to provoke the exception?
>
> I'd like to be sure that Core 1.1.4 is really incompatible with
> Tomahawk 1.1.3 before we announce it that way. Maybe we can soften
> the statement to 'some components' or 'the xxx component' ?
>
> [1] the myfaces-example-simple app built with Core 1.1.4 and Tomahawk 1.1.3
>
> [2] I do see a PropertyNotFound exception:
> http://wiki.wsmoak.net/cgi-bin/wiki.pl?MyFacesCore114#propnotfound
>
> --
> Wendy
>
--
http://www.irian.at
Your JSF powerhouse -
JSF Consulting, Development and
Courses in English and German
Professional Support for Apache MyFaces
Re: Release Announcement for MyFaces Core 1.1.4
Posted by Wendy Smoak <ws...@gmail.com>.
On 9/17/06, Martin Marinschek <ma...@gmail.com> wrote:
> When you told me that you reverted the getScrolling stuff, I
> remembered that I also changed the name of the clear..._formName()
> method. Now if old tomahawk 1.1.3 components expect to call this
> clear-method, they'd have a java-script exception.
>
> So essentially - if you use an h:form and a t:commandLink, you should
> see this exception, apart from that, you should be safe.
I found the <h:form>...<t:commandLink> construct in a few of the
'simple' examples: forceId.jsp, dataTable.jsp, dataScroller.jsp,
countryTableForm.jsp.
Clicking around [1], I don't see any JavaScript errors [2]. Searching
across the Tomahawk 1.1.3 'core' module for the word 'clear' doesn't
turn up anything that looks suspicious to me.
What can I do to provoke the exception?
I'd like to be sure that Core 1.1.4 is really incompatible with
Tomahawk 1.1.3 before we announce it that way. Maybe we can soften
the statement to 'some components' or 'the xxx component' ?
[1] the myfaces-example-simple app built with Core 1.1.4 and Tomahawk 1.1.3
[2] I do see a PropertyNotFound exception:
http://wiki.wsmoak.net/cgi-bin/wiki.pl?MyFacesCore114#propnotfound
--
Wendy
Re: Release Announcement for MyFaces Core 1.1.4
Posted by Martin Marinschek <ma...@gmail.com>.
Hi Wendy, Mike, Matthias,
When you told me that you reverted the getScrolling stuff, I
remembered that I also changed the name of the clear..._formName()
method. Now if old tomahawk 1.1.3 components expect to call this
clear-method, they'd have a java-script exception.
So essentially - if you use an h:form and a t:commandLink, you should
see this exception, apart from that, you should be safe.
regards,
Martin
On 9/16/06, Wendy Smoak <ws...@gmail.com> wrote:
> On 9/16/06, Wendy Smoak <ws...@gmail.com> wrote:
>
> > What is the issue and/or commit that you think broke compatibility
> > with Tomahawk 1.1.3?
>
> I checked out the Tomahawk 1.1.3 tag, modified the pom for the example
> apps to use MyFaces 1.1.4, and built myfaces-example-simple.
>
> WEB-INF/lib contains myfaces-api-1.1.4.jar, myfaces-impl-1.1.4.jar,
> and tomahawk-1.1.3.jar.
>
> You can download it here: http://people.apache.org/~wsmoak/myfaces/tomahawk/
>
> If this is an incompatible combination, what can I expect to _not_
> work in myfaces-example-simple?
>
> Thanks,
> --
> Wendy
>
--
http://www.irian.at
Your JSF powerhouse -
JSF Consulting, Development and
Courses in English and German
Professional Support for Apache MyFaces
Re: Release Announcement for MyFaces Core 1.1.4
Posted by Wendy Smoak <ws...@gmail.com>.
On 9/16/06, Wendy Smoak <ws...@gmail.com> wrote:
> What is the issue and/or commit that you think broke compatibility
> with Tomahawk 1.1.3?
I checked out the Tomahawk 1.1.3 tag, modified the pom for the example
apps to use MyFaces 1.1.4, and built myfaces-example-simple.
WEB-INF/lib contains myfaces-api-1.1.4.jar, myfaces-impl-1.1.4.jar,
and tomahawk-1.1.3.jar.
You can download it here: http://people.apache.org/~wsmoak/myfaces/tomahawk/
If this is an incompatible combination, what can I expect to _not_
work in myfaces-example-simple?
Thanks,
--
Wendy
Re: Release Announcement for MyFaces Core 1.1.4
Posted by Wendy Smoak <ws...@gmail.com>.
> On 9/15/06, Mike Kienenberger <mk...@gmail.com> wrote:
> > I think we were talking about getScrolling back then. That was a
> > non-essential change that we could revert. I noticed this change
> > when reading the commit messages, not by actual testing against 1.1.3.
> >
> > It sounds like there was another change that we didn't catch that was
> > required to provide JSF RI compatibility, but also had to break 1.1.3
> > compatibility.
On 9/16/06, Matthias Wessendorf <ma...@apache.org> wrote:
> the commit I did was a revert to ensure the backward comp.
> Sean opend a bug that there were issues with Tomahawk 113.
> I tested and figured out and did the revert
> > From: Martin Marinschek <ma...@gmail.com>
> > I saw that you guys renamed the getScrolling again. I wonder about the
> > clear...xx method that I renamed as well, to comply with the RI's
> > method. Thinking about this now, I believe this will mean we can't use
> > implementation version 1.1.5 with tomahawk 1.1.3.
This is the getScrolling issue:
http://issues.apache.org/jira/browse/MYFACES-1376
What is the issue and/or commit that you think broke compatibility
with Tomahawk 1.1.3?
(Martin, did you mean Core 1.1.4 or does this really only affect Core 1.1.5? )
--
Wendy
Re: Release Announcement for MyFaces Core 1.1.4
Posted by Matthias Wessendorf <ma...@apache.org>.
the commit I did was a revert to ensure the backward comp.
Sean opend a bug that there were issues with Tomahawk 113.
I tested and figured out and did the revert
-Matthias
On 9/15/06, Mike Kienenberger <mk...@gmail.com> wrote:
> On 9/15/06, Matthias Wessendorf <ma...@apache.org> wrote:
> > there was something I changed to the branch in june/july to be able
> > to have 114 working with tomahawk 113.
> > Sean, you and I were discussing that.
> >
> > Now you say it's not working w/ core 114.
> > Why ?
>
> I think we were talking about getScrolling back then. That was a
> non-essential change that we could revert. I noticed this change
> when reading the commit messages, not by actual testing against 1.1.3.
>
> It sounds like there was another change that we didn't catch that was
> required to provide JSF RI compatibility, but also had to break 1.1.3
> compatibility.
>
> ---------- Forwarded message ----------
> From: Martin Marinschek <ma...@gmail.com>
> Date: Sep 11, 2006 12:32 PM
> Subject: Re: Release MyFaces Core 1.1.4 -- bug with datatable showing
> wrong # of lines
> To: MyFaces Development <de...@myfaces.apache.org>
>
> [...]
>
> I saw that you guys renamed the getScrolling again. I wonder about the
> clear...xx method that I renamed as well, to comply with the RI's
> method. Thinking about this now, I believe this will mean we can't use
> implementation version 1.1.5 with tomahawk 1.1.3. This whole
> javascript thing is a problem - the interdependency between
> implementations and different components in the component libraries
> shows here clearly!
>
--
Matthias Wessendorf
further stuff:
blog: http://jroller.com/page/mwessendorf
mail: mwessendorf-at-gmail-dot-com
Re: Release Announcement for MyFaces Core 1.1.4
Posted by Mike Kienenberger <mk...@gmail.com>.
On 9/15/06, Matthias Wessendorf <ma...@apache.org> wrote:
> there was something I changed to the branch in june/july to be able
> to have 114 working with tomahawk 113.
> Sean, you and I were discussing that.
>
> Now you say it's not working w/ core 114.
> Why ?
I think we were talking about getScrolling back then. That was a
non-essential change that we could revert. I noticed this change
when reading the commit messages, not by actual testing against 1.1.3.
It sounds like there was another change that we didn't catch that was
required to provide JSF RI compatibility, but also had to break 1.1.3
compatibility.
---------- Forwarded message ----------
From: Martin Marinschek <ma...@gmail.com>
Date: Sep 11, 2006 12:32 PM
Subject: Re: Release MyFaces Core 1.1.4 -- bug with datatable showing
wrong # of lines
To: MyFaces Development <de...@myfaces.apache.org>
[...]
I saw that you guys renamed the getScrolling again. I wonder about the
clear...xx method that I renamed as well, to comply with the RI's
method. Thinking about this now, I believe this will mean we can't use
implementation version 1.1.5 with tomahawk 1.1.3. This whole
javascript thing is a problem - the interdependency between
implementations and different components in the component libraries
shows here clearly!