You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2018/08/30 21:10:55 UTC

[GitHub] williaster commented on issue #5772: [SIP-4][superset-client] add `SupersetClient`, refactor app

williaster commented on issue #5772: [SIP-4][superset-client] add `SupersetClient`, refactor app
URL: https://github.com/apache/incubator-superset/pull/5772#issuecomment-417468417
 
 
   Okay so there are some concerns that this PR is too large and so we're considering the following:
   
   1) abandon this PR
   2) create a PR in the superset-ui repo with just the `SupersetClient` package
   3) merge then publish the package
   4) create a series of smaller PRs for the ajax refactors, possibly adding integration tests to them as we go.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org