[GitHub] [spark] viirya commented on a change in pull request #29831: [SPARK-32351][SQL] pushdown partition filter in FileSourceStrategy and HiveTableScans

[GitBox <gi...@apache.org>]

viirya commented on a change in pull request #29831:
URL: https://github.com/apache/spark/pull/29831#discussion_r492497787



##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/FileSourceStrategy.scala
##########
@@ -158,6 +158,7 @@ object FileSourceStrategy extends Strategy with PredicateHelper with Logging {
         ExpressionSet(Nil)
       } else {
         val predicates = ExpressionSet(normalizedFilters
+          .flatMap(extractPredicatesWithinOutputSet(_, partitionSet))
           .filter(_.references.subsetOf(partitionSet)))

Review comment:
       After `extractPredicatesWithinOutputSet`, do we still need `.filter(_.references.subsetOf(partitionSet)))`?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org