You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2020/09/09 01:29:33 UTC

[GitHub] [druid] clintropolis commented on pull request #10355: consolidate ValueType and ExprType

clintropolis commented on pull request #10355:
URL: https://github.com/apache/druid/pull/10355#issuecomment-689241906


   >Because the expression system doesn't support all of the normal Druid ValueTypes, it might actually be better to keep them separate, since it makes things more type-safe. (We know that if we have an ExprType, then that represents a ValueType that the expression system can handle.)
   
   Yeah, I think long term we definitely do want to consolidate these, but maybe I am jumping ahead a bit and we should wait until `Expr` can handle all `ValueType`. I will close this PR for now.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org