You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2022/09/23 01:09:14 UTC

[GitHub] [iotdb] qiaojialin commented on a diff in pull request #7403: [IOTDB-4080] Change the port name of show cluster, show regions, show confignodes, show datandoes; make running result of `Remove-datanode.sh` clear

qiaojialin commented on code in PR #7403:
URL: https://github.com/apache/iotdb/pull/7403#discussion_r978195221


##########
confignode/src/main/java/org/apache/iotdb/confignode/procedure/env/DataNodeRemoveHandler.java:
##########
@@ -507,7 +507,7 @@ private TSStatus checkRegionReplication(RemoveDataNodePlan removeDataNodePlan) {
     if (allDataNodeSize - removedDataNodeSize < NodeInfo.getMinimumDataNode()) {
       status.setCode(TSStatusCode.LACK_REPLICATION.getStatusCode());
       status.setMessage(
-          "lack replication, allow most removed Data Node size : "
+          "due to the limit of replication factor, max allowed removed Data Node size is: "

Review Comment:
   Print the replication factor



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org