You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sling.apache.org by Robert Munteanu <ro...@apache.org> on 2020/01/08 15:41:47 UTC
Re: [tools] docker committer tools failed
On Wed, 2019-10-02 at 14:49 +0200, Carsten Ziegeler wrote:
> Hmm, so the name in the pom.xml needs to be the same as the prefix
> used
> for the jira version?
Yes, for the moment this is how we match them. I don't think it's
perfect, but I don't have a better idea.
I filed https://issues.apache.org/jira/browse/SLING-8972 to make this
message clearer, but if anyone has ideas for other approaches I'm all
ears.
Thanks,
Robert
>
> In any case here is the stacktrace:
> java.lang.IllegalArgumentException: No version found with name
> Default
> POST Servlets 2.3.34
> at
> org.apache.sling.cli.impl.jira.VersionClient.lambda$find$1(VersionCli
> ent.java:84)
> at java.base/java.util.Optional.orElseThrow(Unknown Source)
> at
> org.apache.sling.cli.impl.jira.VersionClient.find(VersionClient.java:
> 84)
> at
> org.apache.sling.cli.impl.release.PrepareVoteEmailCommand.lambda$run$
> 0(PrepareVoteEmailCommand.java:116)
> at
> java.base/java.util.stream.ReferencePipeline$3$1.accept(Unknown
> Source)
> at java.base/java.util.Iterator.forEachRemaining(Unknown
> Source)
> at
> java.base/java.util.Spliterators$IteratorSpliterator.forEachRemaining
> (Unknown
> Source)
> at
> java.base/java.util.stream.AbstractPipeline.copyInto(Unknown
> Source)
> at
> java.base/java.util.stream.AbstractPipeline.wrapAndCopyInto(Unknown
> Source)
> at
> java.base/java.util.stream.ReduceOps$ReduceOp.evaluateSequential(Unkn
> own
> Source)
> at
> java.base/java.util.stream.AbstractPipeline.evaluate(Unknown
> Source)
> at
> java.base/java.util.stream.ReferencePipeline.collect(Unknown
> Source)
> at
> org.apache.sling.cli.impl.release.PrepareVoteEmailCommand.run(Prepare
> VoteEmailCommand.java:117)
> at
> picocli.CommandLine.executeUserObject(CommandLine.java:1687)
> at picocli.CommandLine.access$900(CommandLine.java:146)
> at picocli.CommandLine$RunLast.handle(CommandLine.java:2059)
> at picocli.CommandLine$RunLast.handle(CommandLine.java:2026)
> at
> picocli.CommandLine$AbstractParseResultHandler.execute(CommandLine.ja
> va:1893)
> at picocli.CommandLine.execute(CommandLine.java:1822)
> at
> org.apache.sling.cli.impl.CommandProcessor.runCommand(CommandProcesso
> r.java:110)
> at
> org.apache.sling.cli.impl.ExecutionTrigger.lambda$activate$0(Executio
> nTrigger.java:33)
> at java.base/java.lang.Thread.run(Unknown Source)
>
> Carsten
>
> Am 02.10.2019 um 11:57 schrieb Robert Munteanu:
> > Hi Carsten,
> >
> > On Wed, 2019-10-02 at 07:52 +0200, Carsten Ziegeler wrote:
> > > Hi
> > >
> > > I tried the new docker based committer tools for the servlets
> > > post
> > > release, but didn't get very far.
> > > The error I got is :
> > > java.lang.IllegalArgumentException: No version found with name
> > > Default
> > > POST Servlets 2.3.34
> > >
> > > I'm unsure how to fix this - the comment in the staging
> > > repository
> > > contains the correct jira release version; however this seems to
> > > be
> > > taken from the pom?
> >
> > Yes, I think this is due to a recent change that tries to map
> > artifacts
> > to Jira versions using the pom.xml name.
> >
> > I think at least we should make the error message more
> > straightforward.
> > Since you can't change the name in the staged pom.xml the committer
> > tools will only be usable for the next release, after we align the
> > pom.xml name and the Jira version.
> >
> > Can you reply with a stack trace or file a Jira issue with it? I'd
> > like
> > to make the error message self-explanatory.
> >
> > Thanks,
> > Robert
> >
Re: [tools] docker committer tools failed
Posted by Robert Munteanu <ro...@apache.org>.
On Wed, 2020-01-08 at 13:36 -0500, Daniel Klco wrote:
> Could the code pull the list of open releases and then offer
> suggestions
> sorted by the number of matching terms? Something like mvn
> archetype:generate? It would only work in interactive mode, but it
> would
> give you a recovery path if the release name didn't match.
Yes, it could. There is the extra complication of having to store the
mappings somewhere, as it needs to perform the mappings for multiple
operations (IIRC).
All in all, I'd prefer to gradually migrate the modules to have similar
names to Jira names, which is a good thing anyway IMO.
Thanks,
Robert
Re: [tools] docker committer tools failed
Posted by Daniel Klco <dk...@apache.org>.
Could the code pull the list of open releases and then offer suggestions
sorted by the number of matching terms? Something like mvn
archetype:generate? It would only work in interactive mode, but it would
give you a recovery path if the release name didn't match.
On Wed, Jan 8, 2020 at 10:41 AM Robert Munteanu <ro...@apache.org> wrote:
> On Wed, 2019-10-02 at 14:49 +0200, Carsten Ziegeler wrote:
> > Hmm, so the name in the pom.xml needs to be the same as the prefix
> > used
> > for the jira version?
>
> Yes, for the moment this is how we match them. I don't think it's
> perfect, but I don't have a better idea.
>
> I filed https://issues.apache.org/jira/browse/SLING-8972 to make this
> message clearer, but if anyone has ideas for other approaches I'm all
> ears.
>
> Thanks,
> Robert
>
> >
> > In any case here is the stacktrace:
> > java.lang.IllegalArgumentException: No version found with name
> > Default
> > POST Servlets 2.3.34
> > at
> > org.apache.sling.cli.impl.jira.VersionClient.lambda$find$1(VersionCli
> > ent.java:84)
> > at java.base/java.util.Optional.orElseThrow(Unknown Source)
> > at
> > org.apache.sling.cli.impl.jira.VersionClient.find(VersionClient.java:
> > 84)
> > at
> > org.apache.sling.cli.impl.release.PrepareVoteEmailCommand.lambda$run$
> > 0(PrepareVoteEmailCommand.java:116)
> > at
> > java.base/java.util.stream.ReferencePipeline$3$1.accept(Unknown
> > Source)
> > at java.base/java.util.Iterator.forEachRemaining(Unknown
> > Source)
> > at
> > java.base/java.util.Spliterators$IteratorSpliterator.forEachRemaining
> > (Unknown
> > Source)
> > at
> > java.base/java.util.stream.AbstractPipeline.copyInto(Unknown
> > Source)
> > at
> > java.base/java.util.stream.AbstractPipeline.wrapAndCopyInto(Unknown
> > Source)
> > at
> > java.base/java.util.stream.ReduceOps$ReduceOp.evaluateSequential(Unkn
> > own
> > Source)
> > at
> > java.base/java.util.stream.AbstractPipeline.evaluate(Unknown
> > Source)
> > at
> > java.base/java.util.stream.ReferencePipeline.collect(Unknown
> > Source)
> > at
> > org.apache.sling.cli.impl.release.PrepareVoteEmailCommand.run(Prepare
> > VoteEmailCommand.java:117)
> > at
> > picocli.CommandLine.executeUserObject(CommandLine.java:1687)
> > at picocli.CommandLine.access$900(CommandLine.java:146)
> > at picocli.CommandLine$RunLast.handle(CommandLine.java:2059)
> > at picocli.CommandLine$RunLast.handle(CommandLine.java:2026)
> > at
> > picocli.CommandLine$AbstractParseResultHandler.execute(CommandLine.ja
> > va:1893)
> > at picocli.CommandLine.execute(CommandLine.java:1822)
> > at
> > org.apache.sling.cli.impl.CommandProcessor.runCommand(CommandProcesso
> > r.java:110)
> > at
> > org.apache.sling.cli.impl.ExecutionTrigger.lambda$activate$0(Executio
> > nTrigger.java:33)
> > at java.base/java.lang.Thread.run(Unknown Source)
> >
> > Carsten
> >
> > Am 02.10.2019 um 11:57 schrieb Robert Munteanu:
> > > Hi Carsten,
> > >
> > > On Wed, 2019-10-02 at 07:52 +0200, Carsten Ziegeler wrote:
> > > > Hi
> > > >
> > > > I tried the new docker based committer tools for the servlets
> > > > post
> > > > release, but didn't get very far.
> > > > The error I got is :
> > > > java.lang.IllegalArgumentException: No version found with name
> > > > Default
> > > > POST Servlets 2.3.34
> > > >
> > > > I'm unsure how to fix this - the comment in the staging
> > > > repository
> > > > contains the correct jira release version; however this seems to
> > > > be
> > > > taken from the pom?
> > >
> > > Yes, I think this is due to a recent change that tries to map
> > > artifacts
> > > to Jira versions using the pom.xml name.
> > >
> > > I think at least we should make the error message more
> > > straightforward.
> > > Since you can't change the name in the staged pom.xml the committer
> > > tools will only be usable for the next release, after we align the
> > > pom.xml name and the Jira version.
> > >
> > > Can you reply with a stack trace or file a Jira issue with it? I'd
> > > like
> > > to make the error message self-explanatory.
> > >
> > > Thanks,
> > > Robert
> > >
>
>