You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@activemq.apache.org by gtully <gi...@git.apache.org> on 2017/08/08 14:40:12 UTC
[GitHub] activemq-artemis pull request #1449: [ARTEMIS-1310] SASL GSSAPI support
GitHub user gtully opened a pull request:
https://github.com/apache/activemq-artemis/pull/1449
[ARTEMIS-1310] SASL GSSAPI support
update to proton-j 0.20.0 and qpid-jms 0.24.0
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/gtully/activemq-artemis sasl-gssapi
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/activemq-artemis/pull/1449.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1449
----
commit d4a281ed049acfa11b489ed43a06ba57669d7588
Author: gtully <ga...@gmail.com>
Date: 2017-07-28T15:02:32Z
[ARTEMIS-1310] add amqp sasl gssapi mechanism support
delegate to the jdk saslServer. Allow acceptor configuration of supported mechanismis; saslMechanisms=<a,b>
and allow login config scope for krb5 to be configured via saslLoginConfigScope=x
commit 1496b8c463eec9fbe385a8c9e4be7e9141018454
Author: gtully <ga...@gmail.com>
Date: 2017-08-02T11:19:07Z
[ARTEMIS-1310] [ARTEMIS-1264] consolidate configuration to require login configuration scope
commit b551f9ea978eaf0607cd7b8c1567cc13d06031c8
Author: gtully <ga...@gmail.com>
Date: 2017-08-02T14:05:50Z
[ARTEMIS-1310] require mechanism to be explicitly enabled
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis pull request #1449: [ARTEMIS-1310] SASL GSSAPI support
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/activemq-artemis/pull/1449
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis issue #1449: [ARTEMIS-1310] SASL GSSAPI support
Posted by michaelandrepearce <gi...@git.apache.org>.
Github user michaelandrepearce commented on the issue:
https://github.com/apache/activemq-artemis/pull/1449
Hi Guys again,
As @clebertsuconic noted on his PR it seem it was environmental , since the big restart of jenkins that occured this morning, it seems to have cleared out.
ignore, sorry.
Mike
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis issue #1449: [ARTEMIS-1310] SASL GSSAPI support
Posted by clebertsuconic <gi...@git.apache.org>.
Github user clebertsuconic commented on the issue:
https://github.com/apache/activemq-artemis/pull/1449
@gtully I will update proton and qpid-jms on a different commit
and rebase this one.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis issue #1449: [ARTEMIS-1310] SASL GSSAPI support
Posted by tabish121 <gi...@git.apache.org>.
Github user tabish121 commented on the issue:
https://github.com/apache/activemq-artemis/pull/1449
It looks to me like the third commit updates to the released bits. Maybe squash the commits?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis issue #1449: [ARTEMIS-1310] SASL GSSAPI support
Posted by clebertsuconic <gi...@git.apache.org>.
Github user clebertsuconic commented on the issue:
https://github.com/apache/activemq-artemis/pull/1449
@gtully Impressive work here! 👍 🥇
just a question... qpid-jms has been already issued a vote.. it should be passed by tomorrow. wouldn't be worth to merge this tomorrow after it's released?
I had already issued a heads-up on the dev list, we could release this as soon as that is released.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis issue #1449: [ARTEMIS-1310] SASL GSSAPI support
Posted by michaelandrepearce <gi...@git.apache.org>.
Github user michaelandrepearce commented on the issue:
https://github.com/apache/activemq-artemis/pull/1449
Hi Guys, this seems to have caused a bunch of test failures, which now merged means all subsequent PR's are failing.
```
org.apache.activemq.artemis.utils.TimeUnitsTest.testWaitOnBoolean
org.apache.activemq.artemis.core.config.impl.ConfigurationImplTest.testAbsolutePath
org.apache.activemq.artemis.core.config.impl.DefaultsFileConfigurationTest.testAbsolutePath
org.apache.activemq.artemis.core.config.impl.FileConfigurationTest.testContextClassLoaderUsage
org.apache.activemq.artemis.core.config.impl.FileConfigurationTest.testAbsolutePath
org.apache.activemq.artemis.core.security.jaas.JAASSecurityManagerTest.testLoginClassloading[newLoader=(true)]
org.apache.activemq.artemis.core.security.jaas.JAASSecurityManagerTest.testLoginClassloading[newLoader=(false)]
org.apache.activemq.artemis.core.security.jaas.LDAPLoginModuleTest.org.apache.activemq.artemis.core.security.jaas.LDAPLoginModuleTest
org.apache.activemq.artemis.core.security.jaas.LDAPModuleRoleExpansionTest.org.apache.activemq.artemis.core.security.jaas.LDAPModuleRoleExpansionTest
org.apache.activemq.artemis.core.security.jaas.PropertiesLoginModuleRaceConditionTest.raceConditionInUsersAndGroupsLoading
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis issue #1449: [ARTEMIS-1310] SASL GSSAPI support
Posted by clebertsuconic <gi...@git.apache.org>.
Github user clebertsuconic commented on the issue:
https://github.com/apache/activemq-artemis/pull/1449
@gtully if they are in maven central, can't we just use the released bits then?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis issue #1449: [ARTEMIS-1310] SASL GSSAPI support
Posted by clebertsuconic <gi...@git.apache.org>.
Github user clebertsuconic commented on the issue:
https://github.com/apache/activemq-artemis/pull/1449
@tabish121 Oh.. I see
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis issue #1449: [ARTEMIS-1310] SASL GSSAPI support
Posted by gtully <gi...@git.apache.org>.
Github user gtully commented on the issue:
https://github.com/apache/activemq-artemis/pull/1449
The new proton-j and qpid-jms deps are in maven central.
W.r.t to the tests check failing, some unrelated permissions issue with temp dir creation seems to be the root cause of them all.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---