You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@atlas.apache.org by Madhan Neethiraj <ma...@apache.org> on 2017/01/18 05:08:02 UTC
Review Request 55662: ATLAS-1471: avoid unnecessary overhead in debug
log calls
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55662/
-----------------------------------------------------------
Review request for atlas.
Bugs: ATLAS-1471
https://issues.apache.org/jira/browse/ATLAS-1471
Repository: atlas
Description
-------
Surronding calls to LOG.debug() with "if (LOG.isDebugEnabled())", to avoid unnecessary overhead in debug log calls.
Diffs
-----
repository/src/main/java/org/apache/atlas/repository/graph/DeleteHandler.java 74a9cd1
repository/src/main/java/org/apache/atlas/repository/graph/FullTextMapper.java 7c4bdc1
repository/src/main/java/org/apache/atlas/repository/graph/GraphBackedMetadataRepository.java d20e913
repository/src/main/java/org/apache/atlas/repository/graph/GraphBackedSearchIndexer.java 42a22a8
repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java bcdf344
repository/src/main/java/org/apache/atlas/repository/graph/GraphToTypedInstanceMapper.java f7b1ff0
repository/src/main/java/org/apache/atlas/repository/graph/TypedInstanceToGraphMapper.java 3d35f36
Diff: https://reviews.apache.org/r/55662/diff/
Testing
-------
Verified that all unit tests pass.
Thanks,
Madhan Neethiraj
Re: Review Request 55662: ATLAS-1471: avoid unnecessary overhead in
debug log calls
Posted by Madhan Neethiraj <ma...@apache.org>.
> On Jan. 18, 2017, 8:34 a.m., Vimal Sharma wrote:
> > This patch handles the files only in module repository. It might be good to make similar changes in all modules
Given that this would require updating a large number of files, it will be helpful to do one module at a time - to minimize potential merge issues for other developers who might be updating the same file.
> On Jan. 18, 2017, 8:34 a.m., Vimal Sharma wrote:
> > repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java, line 827
> > <https://reviews.apache.org/r/55662/diff/1/?file=1607322#file1607322line827>
> >
> > Any specific reason for removing @Monitored annotation from these methods
Many of the low-level and heavily used methods, like getProperty()/setProperty(), are annotated with "@Montiored". This adds unnecessary overhead; hence removed the annotation.
Also I think use of such annotation for performance tracing may not be the right approach - due to overheads and ease of enable/disable perf data collection in a production deployment. We should revisit this.
- Madhan
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55662/#review162043
-----------------------------------------------------------
On Jan. 18, 2017, 5:08 a.m., Madhan Neethiraj wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55662/
> -----------------------------------------------------------
>
> (Updated Jan. 18, 2017, 5:08 a.m.)
>
>
> Review request for atlas.
>
>
> Bugs: ATLAS-1471
> https://issues.apache.org/jira/browse/ATLAS-1471
>
>
> Repository: atlas
>
>
> Description
> -------
>
> Surronding calls to LOG.debug() with "if (LOG.isDebugEnabled())", to avoid unnecessary overhead in debug log calls.
>
>
> Diffs
> -----
>
> repository/src/main/java/org/apache/atlas/repository/graph/DeleteHandler.java 74a9cd1
> repository/src/main/java/org/apache/atlas/repository/graph/FullTextMapper.java 7c4bdc1
> repository/src/main/java/org/apache/atlas/repository/graph/GraphBackedMetadataRepository.java d20e913
> repository/src/main/java/org/apache/atlas/repository/graph/GraphBackedSearchIndexer.java 42a22a8
> repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java bcdf344
> repository/src/main/java/org/apache/atlas/repository/graph/GraphToTypedInstanceMapper.java f7b1ff0
> repository/src/main/java/org/apache/atlas/repository/graph/TypedInstanceToGraphMapper.java 3d35f36
>
> Diff: https://reviews.apache.org/r/55662/diff/
>
>
> Testing
> -------
>
> Verified that all unit tests pass.
>
>
> Thanks,
>
> Madhan Neethiraj
>
>
Re: Review Request 55662: ATLAS-1471: avoid unnecessary overhead in
debug log calls
Posted by Vimal Sharma <vi...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55662/#review162043
-----------------------------------------------------------
Fix it, then Ship it!
This patch handles the files only in module repository. It might be good to make similar changes in all modules
repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java
<https://reviews.apache.org/r/55662/#comment233295>
Any specific reason for removing @Monitored annotation from these methods
- Vimal Sharma
On Jan. 18, 2017, 5:08 a.m., Madhan Neethiraj wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55662/
> -----------------------------------------------------------
>
> (Updated Jan. 18, 2017, 5:08 a.m.)
>
>
> Review request for atlas.
>
>
> Bugs: ATLAS-1471
> https://issues.apache.org/jira/browse/ATLAS-1471
>
>
> Repository: atlas
>
>
> Description
> -------
>
> Surronding calls to LOG.debug() with "if (LOG.isDebugEnabled())", to avoid unnecessary overhead in debug log calls.
>
>
> Diffs
> -----
>
> repository/src/main/java/org/apache/atlas/repository/graph/DeleteHandler.java 74a9cd1
> repository/src/main/java/org/apache/atlas/repository/graph/FullTextMapper.java 7c4bdc1
> repository/src/main/java/org/apache/atlas/repository/graph/GraphBackedMetadataRepository.java d20e913
> repository/src/main/java/org/apache/atlas/repository/graph/GraphBackedSearchIndexer.java 42a22a8
> repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java bcdf344
> repository/src/main/java/org/apache/atlas/repository/graph/GraphToTypedInstanceMapper.java f7b1ff0
> repository/src/main/java/org/apache/atlas/repository/graph/TypedInstanceToGraphMapper.java 3d35f36
>
> Diff: https://reviews.apache.org/r/55662/diff/
>
>
> Testing
> -------
>
> Verified that all unit tests pass.
>
>
> Thanks,
>
> Madhan Neethiraj
>
>