You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by gg...@apache.org on 2020/01/25 16:55:31 UTC

[commons-compress] 01/06: Reuse own CloseShieldFilterInputStream instead of creating an anonymous inner class.

This is an automated email from the ASF dual-hosted git repository.

ggregory pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-compress.git

commit 9ede8aec5fd9a6a856bedd5246810d3a82b5a17c
Author: Gary Gregory <ga...@gmail.com>
AuthorDate: Sat Jan 25 11:23:56 2020 -0500

    Reuse own CloseShieldFilterInputStream instead of creating an anonymous
    inner class.
---
 .../compressors/pack200/Pack200CompressorInputStream.java    | 12 ++++--------
 1 file changed, 4 insertions(+), 8 deletions(-)

diff --git a/src/main/java/org/apache/commons/compress/compressors/pack200/Pack200CompressorInputStream.java b/src/main/java/org/apache/commons/compress/compressors/pack200/Pack200CompressorInputStream.java
index a669e6e..1d849a3 100644
--- a/src/main/java/org/apache/commons/compress/compressors/pack200/Pack200CompressorInputStream.java
+++ b/src/main/java/org/apache/commons/compress/compressors/pack200/Pack200CompressorInputStream.java
@@ -20,7 +20,6 @@
 package org.apache.commons.compress.compressors.pack200;
 
 import java.io.File;
-import java.io.FilterInputStream;
 import java.io.IOException;
 import java.io.InputStream;
 import java.util.Map;
@@ -28,6 +27,7 @@ import java.util.jar.JarOutputStream;
 import java.util.jar.Pack200;
 
 import org.apache.commons.compress.compressors.CompressorInputStream;
+import org.apache.commons.compress.utils.CloseShieldFilterInputStream;
 import org.apache.commons.compress.utils.IOUtils;
 
 /**
@@ -178,13 +178,9 @@ public class Pack200CompressorInputStream extends CompressorInputStream {
                 u.properties().putAll(props);
             }
             if (f == null) {
-                u.unpack(new FilterInputStream(in) {
-                    @Override
-                    public void close() {
-                        // unpack would close this stream but we
-                        // want to give the user code more control
-                    }
-                }, jarOut);
+                // unpack would close this stream but we
+                // want to give the user code more control
+                u.unpack(new CloseShieldFilterInputStream(in), jarOut);
             } else {
                 u.unpack(f, jarOut);
             }