[jira] [Commented] (RATIS-816) Use peerId in error log / exception of GrpcServerProtocolClient

["Mukul Kumar Singh (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/RATIS-816?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17057008#comment-17057008 ] 

Mukul Kumar Singh commented on RATIS-816:
-----------------------------------------

Thanks for working on this [~elek]. Can we use parametrized logging.

> Use peerId in error log / exception of GrpcServerProtocolClient
> ---------------------------------------------------------------
>
>                 Key: RATIS-816
>                 URL: https://issues.apache.org/jira/browse/RATIS-816
>             Project: Ratis
>          Issue Type: Improvement
>            Reporter: Marton Elek
>            Assignee: Marton Elek
>            Priority: Major
>         Attachments: RATIS-816.001.patch
>
>
> GrpcServerProtocolClient is used to send out requestVote and appendLogEntry requests.
> I propose to persist raftPeerId in the constructor and use it in the error / exception message.
> This is not just getting more meaningful message (it's a nice to have) but in HDDS-3023 I am modifying the byte code to mock the leader->follower communication. It's way more easier to do if the required raftPeerId is available in the class.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)