[GitHub] [superset] zephyring commented on a diff in pull request #20549: feat: using sqla session to set perm so that proper sqla callback can…

[GitBox <gi...@apache.org>]

zephyring commented on code in PR #20549:
URL: https://github.com/apache/superset/pull/20549#discussion_r910239471


##########
superset/connectors/sqla/utils.py:
##########
@@ -213,7 +213,7 @@ def find_cached_objects_in_session(
         return iter([])
     uuids = uuids or []
     try:
-        items = set(session)
+        items = list(session)

Review Comment:
   This is to avoid serialization issue for some objects inside session. By default there should not be any duplicate



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org