[GitHub] [superset] eschutho commented on a diff in pull request #22693: fix(explore): Restore missing dataset states

[GitBox <gi...@apache.org>]

eschutho commented on code in PR #22693:
URL: https://github.com/apache/superset/pull/22693#discussion_r1067590207


##########
superset-frontend/src/explore/components/controls/DatasourceControl/index.jsx:
##########
@@ -267,11 +267,12 @@ class DatasourceControl extends React.PureComponent {
       showSaveDatasetModal,
     } = this.state;
     const { datasource, onChange, theme } = this.props;
-    const isMissingDatasource = datasource?.id == null;
+    const isMissingDatasource = !datasource || datasource.id === 0;

Review Comment:
   Would this also work? 
   ```suggestion
       const isMissingDatasource = !!datasource?.id
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org