You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucenenet.apache.org by "Corey Trager (JIRA)" <ji...@apache.org> on 2009/10/31 02:16:59 UTC
[jira] Created: (LUCENENET-202) Compile warnings trying to build
source code, svn revision 829945
Compile warnings trying to build source code, svn revision 829945
-----------------------------------------------------------------
Key: LUCENENET-202
URL: https://issues.apache.org/jira/browse/LUCENENET-202
Project: Lucene.Net
Issue Type: Bug
Environment: VS C# Express 2008. A
Reporter: Corey Trager
C:\cit\lucene\C#\src\Lucene.Net\Search\ComplexExplanation.cs(69,12): warning CS0472: The result of the expression is always 'true' since a value of type 'bool' is never equal to 'null' of type 'bool?'
C:\cit\lucene\C#\src\Lucene.Net\Search\ComplexExplanation.cs(69,24): warning CS0429: Unreachable expression code detected
C:\cit\lucene\C#\src\Lucene.Net\Index\FormatPostingsDocsWriter.cs(42,17): warning CS0649: Field 'Lucene.Net.Index.FormatPostingsDocsWriter.freqStart' is never assigned to, and will always have its default value 0
C:\cit\lucene\C#\src\Lucene.Net\Analysis\Standard\StandardTokenizerImpl.cs(230,15): warning CS0414: The field 'Lucene.Net.Analysis.Standard.StandardTokenizerImpl.yycolumn' is assigned but its value is never used
C:\cit\lucene\C#\src\Lucene.Net\Analysis\Standard\StandardTokenizerImpl.cs(233,16): warning CS0414: The field 'Lucene.Net.Analysis.Standard.StandardTokenizerImpl.zzAtBOL' is assigned but its value is never used
C:\cit\lucene\C#\src\Lucene.Net\Index\DocFieldProcessorPerThread.cs(42,18): warning CS0649: Field 'Lucene.Net.Index.DocFieldProcessorPerThread.docBoost' is never assigned to, and will always have its default value 0
C:\cit\lucene\C#\src\Lucene.Net\Index\CharBlockPool.cs(31,16): warning CS0649: Field 'Lucene.Net.Index.CharBlockPool.numBuffer' is never assigned to, and will always have its default value 0
C:\cit\lucene\C#\src\Lucene.Net\Store\NIOFSDirectory.cs(87,35): warning CS0649: Field 'Lucene.Net.Store.NIOFSDirectory.NIOFSIndexInput.byteBuf' is never assigned to, and will always have its default value null
C:\cit\lucene\C#\src\Lucene.Net\Store\NIOFSDirectory.cs(90,35): warning CS0649: Field 'Lucene.Net.Store.NIOFSDirectory.NIOFSIndexInput.otherByteBuf' is never assigned to, and will always have its default value null
C:\cit\lucene\C#\src\Lucene.Net\Analysis\CharReader.cs(32,35): warning CS0649: Field 'Lucene.Net.Analysis.CharReader.input' is never assigned to, and will always have its default value null
C:\cit\lucene\C#\src\Lucene.Net\Index\DocumentsWriter.cs(181,37): warning CS0649: Field 'Lucene.Net.Index.DocumentsWriter.newFiles' is never assigned to, and will always have its default value null
C:\cit\lucene\C#\src\Lucene.Net\Index\TermVectorsTermsWriter.cs(35,30): warning CS0649: Field 'Lucene.Net.Index.TermVectorsTermsWriter.termVectorsWriter' is never assigned to, and will always have its default value null
C:\cit\lucene\C#\src\Lucene.Net\Index\TermsHash.cs(43,21): warning CS0169: The field 'Lucene.Net.Index.TermsHash.primaryTermsHash' is never used
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (LUCENENET-202) Compile warnings trying to build
source code, svn revision 829945
Posted by "Digy (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENENET-202?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Digy updated LUCENENET-202:
---------------------------
Attachment: (was: LUCENENET-202.patch)
> Compile warnings trying to build source code, svn revision 829945
> -----------------------------------------------------------------
>
> Key: LUCENENET-202
> URL: https://issues.apache.org/jira/browse/LUCENENET-202
> Project: Lucene.Net
> Issue Type: Bug
> Environment: VS C# Express 2008. A
> Reporter: Corey Trager
> Attachments: csproj.patch, LUCENENET-202.patch
>
>
> C:\cit\lucene\C#\src\Lucene.Net\Search\ComplexExplanation.cs(69,12): warning CS0472: The result of the expression is always 'true' since a value of type 'bool' is never equal to 'null' of type 'bool?'
> C:\cit\lucene\C#\src\Lucene.Net\Search\ComplexExplanation.cs(69,24): warning CS0429: Unreachable expression code detected
> C:\cit\lucene\C#\src\Lucene.Net\Index\FormatPostingsDocsWriter.cs(42,17): warning CS0649: Field 'Lucene.Net.Index.FormatPostingsDocsWriter.freqStart' is never assigned to, and will always have its default value 0
> C:\cit\lucene\C#\src\Lucene.Net\Analysis\Standard\StandardTokenizerImpl.cs(230,15): warning CS0414: The field 'Lucene.Net.Analysis.Standard.StandardTokenizerImpl.yycolumn' is assigned but its value is never used
> C:\cit\lucene\C#\src\Lucene.Net\Analysis\Standard\StandardTokenizerImpl.cs(233,16): warning CS0414: The field 'Lucene.Net.Analysis.Standard.StandardTokenizerImpl.zzAtBOL' is assigned but its value is never used
> C:\cit\lucene\C#\src\Lucene.Net\Index\DocFieldProcessorPerThread.cs(42,18): warning CS0649: Field 'Lucene.Net.Index.DocFieldProcessorPerThread.docBoost' is never assigned to, and will always have its default value 0
> C:\cit\lucene\C#\src\Lucene.Net\Index\CharBlockPool.cs(31,16): warning CS0649: Field 'Lucene.Net.Index.CharBlockPool.numBuffer' is never assigned to, and will always have its default value 0
> C:\cit\lucene\C#\src\Lucene.Net\Store\NIOFSDirectory.cs(87,35): warning CS0649: Field 'Lucene.Net.Store.NIOFSDirectory.NIOFSIndexInput.byteBuf' is never assigned to, and will always have its default value null
> C:\cit\lucene\C#\src\Lucene.Net\Store\NIOFSDirectory.cs(90,35): warning CS0649: Field 'Lucene.Net.Store.NIOFSDirectory.NIOFSIndexInput.otherByteBuf' is never assigned to, and will always have its default value null
> C:\cit\lucene\C#\src\Lucene.Net\Analysis\CharReader.cs(32,35): warning CS0649: Field 'Lucene.Net.Analysis.CharReader.input' is never assigned to, and will always have its default value null
> C:\cit\lucene\C#\src\Lucene.Net\Index\DocumentsWriter.cs(181,37): warning CS0649: Field 'Lucene.Net.Index.DocumentsWriter.newFiles' is never assigned to, and will always have its default value null
> C:\cit\lucene\C#\src\Lucene.Net\Index\TermVectorsTermsWriter.cs(35,30): warning CS0649: Field 'Lucene.Net.Index.TermVectorsTermsWriter.termVectorsWriter' is never assigned to, and will always have its default value null
> C:\cit\lucene\C#\src\Lucene.Net\Index\TermsHash.cs(43,21): warning CS0169: The field 'Lucene.Net.Index.TermsHash.primaryTermsHash' is never used
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (LUCENENET-202) Compile warnings trying to build
source code, svn revision 829945
Posted by "Digy (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENENET-202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12784124#action_12784124 ]
Digy commented on LUCENENET-202:
--------------------------------
The warning
{code}
System.Boolean m = GetMatch();
return (null != m?m:base.IsMatch());
{code}
is lost withing the tons of other warnings. (Since m can not be null, this expression always evaluates to true).
It is stated in the comments that "mach may be null if match status is unknown". So a patch is really needed.
To catch such bugs , filtering some warnings -until some cleanup is done- can be very useful.
DIGY
> Compile warnings trying to build source code, svn revision 829945
> -----------------------------------------------------------------
>
> Key: LUCENENET-202
> URL: https://issues.apache.org/jira/browse/LUCENENET-202
> Project: Lucene.Net
> Issue Type: Bug
> Environment: VS C# Express 2008. A
> Reporter: Corey Trager
> Attachments: csproj.patch, LUCENENET-202.patch
>
>
> C:\cit\lucene\C#\src\Lucene.Net\Search\ComplexExplanation.cs(69,12): warning CS0472: The result of the expression is always 'true' since a value of type 'bool' is never equal to 'null' of type 'bool?'
> C:\cit\lucene\C#\src\Lucene.Net\Search\ComplexExplanation.cs(69,24): warning CS0429: Unreachable expression code detected
> C:\cit\lucene\C#\src\Lucene.Net\Index\FormatPostingsDocsWriter.cs(42,17): warning CS0649: Field 'Lucene.Net.Index.FormatPostingsDocsWriter.freqStart' is never assigned to, and will always have its default value 0
> C:\cit\lucene\C#\src\Lucene.Net\Analysis\Standard\StandardTokenizerImpl.cs(230,15): warning CS0414: The field 'Lucene.Net.Analysis.Standard.StandardTokenizerImpl.yycolumn' is assigned but its value is never used
> C:\cit\lucene\C#\src\Lucene.Net\Analysis\Standard\StandardTokenizerImpl.cs(233,16): warning CS0414: The field 'Lucene.Net.Analysis.Standard.StandardTokenizerImpl.zzAtBOL' is assigned but its value is never used
> C:\cit\lucene\C#\src\Lucene.Net\Index\DocFieldProcessorPerThread.cs(42,18): warning CS0649: Field 'Lucene.Net.Index.DocFieldProcessorPerThread.docBoost' is never assigned to, and will always have its default value 0
> C:\cit\lucene\C#\src\Lucene.Net\Index\CharBlockPool.cs(31,16): warning CS0649: Field 'Lucene.Net.Index.CharBlockPool.numBuffer' is never assigned to, and will always have its default value 0
> C:\cit\lucene\C#\src\Lucene.Net\Store\NIOFSDirectory.cs(87,35): warning CS0649: Field 'Lucene.Net.Store.NIOFSDirectory.NIOFSIndexInput.byteBuf' is never assigned to, and will always have its default value null
> C:\cit\lucene\C#\src\Lucene.Net\Store\NIOFSDirectory.cs(90,35): warning CS0649: Field 'Lucene.Net.Store.NIOFSDirectory.NIOFSIndexInput.otherByteBuf' is never assigned to, and will always have its default value null
> C:\cit\lucene\C#\src\Lucene.Net\Analysis\CharReader.cs(32,35): warning CS0649: Field 'Lucene.Net.Analysis.CharReader.input' is never assigned to, and will always have its default value null
> C:\cit\lucene\C#\src\Lucene.Net\Index\DocumentsWriter.cs(181,37): warning CS0649: Field 'Lucene.Net.Index.DocumentsWriter.newFiles' is never assigned to, and will always have its default value null
> C:\cit\lucene\C#\src\Lucene.Net\Index\TermVectorsTermsWriter.cs(35,30): warning CS0649: Field 'Lucene.Net.Index.TermVectorsTermsWriter.termVectorsWriter' is never assigned to, and will always have its default value null
> C:\cit\lucene\C#\src\Lucene.Net\Index\TermsHash.cs(43,21): warning CS0169: The field 'Lucene.Net.Index.TermsHash.primaryTermsHash' is never used
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Issue Comment Edited: (LUCENENET-202) Compile warnings
trying to build source code, svn revision 829945
Posted by "Corey Trager (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENENET-202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12772203#action_12772203 ]
Corey Trager edited comment on LUCENENET-202 at 11/10/09 3:03 PM:
------------------------------------------------------------------
There are many warnings that aren't important at all. Here are the warnings I suppressed:
1591 1574 1580 1570 1587 1572 1573 0168 1584 1658
The two warnings in ComplexExplanation are the ones I would be most concerned about.
was (Author: ctrager):
There are many warnings that aren't import at all. Here are the warnings I suppressed:
1591 1574 1580 1570 1587 1572 1573 0168 1584 1658
The two warnings in ComplexExplanation are the ones I would be most concerned about.
> Compile warnings trying to build source code, svn revision 829945
> -----------------------------------------------------------------
>
> Key: LUCENENET-202
> URL: https://issues.apache.org/jira/browse/LUCENENET-202
> Project: Lucene.Net
> Issue Type: Bug
> Environment: VS C# Express 2008. A
> Reporter: Corey Trager
>
> C:\cit\lucene\C#\src\Lucene.Net\Search\ComplexExplanation.cs(69,12): warning CS0472: The result of the expression is always 'true' since a value of type 'bool' is never equal to 'null' of type 'bool?'
> C:\cit\lucene\C#\src\Lucene.Net\Search\ComplexExplanation.cs(69,24): warning CS0429: Unreachable expression code detected
> C:\cit\lucene\C#\src\Lucene.Net\Index\FormatPostingsDocsWriter.cs(42,17): warning CS0649: Field 'Lucene.Net.Index.FormatPostingsDocsWriter.freqStart' is never assigned to, and will always have its default value 0
> C:\cit\lucene\C#\src\Lucene.Net\Analysis\Standard\StandardTokenizerImpl.cs(230,15): warning CS0414: The field 'Lucene.Net.Analysis.Standard.StandardTokenizerImpl.yycolumn' is assigned but its value is never used
> C:\cit\lucene\C#\src\Lucene.Net\Analysis\Standard\StandardTokenizerImpl.cs(233,16): warning CS0414: The field 'Lucene.Net.Analysis.Standard.StandardTokenizerImpl.zzAtBOL' is assigned but its value is never used
> C:\cit\lucene\C#\src\Lucene.Net\Index\DocFieldProcessorPerThread.cs(42,18): warning CS0649: Field 'Lucene.Net.Index.DocFieldProcessorPerThread.docBoost' is never assigned to, and will always have its default value 0
> C:\cit\lucene\C#\src\Lucene.Net\Index\CharBlockPool.cs(31,16): warning CS0649: Field 'Lucene.Net.Index.CharBlockPool.numBuffer' is never assigned to, and will always have its default value 0
> C:\cit\lucene\C#\src\Lucene.Net\Store\NIOFSDirectory.cs(87,35): warning CS0649: Field 'Lucene.Net.Store.NIOFSDirectory.NIOFSIndexInput.byteBuf' is never assigned to, and will always have its default value null
> C:\cit\lucene\C#\src\Lucene.Net\Store\NIOFSDirectory.cs(90,35): warning CS0649: Field 'Lucene.Net.Store.NIOFSDirectory.NIOFSIndexInput.otherByteBuf' is never assigned to, and will always have its default value null
> C:\cit\lucene\C#\src\Lucene.Net\Analysis\CharReader.cs(32,35): warning CS0649: Field 'Lucene.Net.Analysis.CharReader.input' is never assigned to, and will always have its default value null
> C:\cit\lucene\C#\src\Lucene.Net\Index\DocumentsWriter.cs(181,37): warning CS0649: Field 'Lucene.Net.Index.DocumentsWriter.newFiles' is never assigned to, and will always have its default value null
> C:\cit\lucene\C#\src\Lucene.Net\Index\TermVectorsTermsWriter.cs(35,30): warning CS0649: Field 'Lucene.Net.Index.TermVectorsTermsWriter.termVectorsWriter' is never assigned to, and will always have its default value null
> C:\cit\lucene\C#\src\Lucene.Net\Index\TermsHash.cs(43,21): warning CS0169: The field 'Lucene.Net.Index.TermsHash.primaryTermsHash' is never used
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (LUCENENET-202) Compile warnings trying to build
source code, svn revision 829945
Posted by "Digy (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENENET-202?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Digy updated LUCENENET-202:
---------------------------
Attachment: LUCENENET-202.patch
I changed the definition of "match" (ComplexExplanation) from "System.Boolean" to "System.Boolean?"
> Compile warnings trying to build source code, svn revision 829945
> -----------------------------------------------------------------
>
> Key: LUCENENET-202
> URL: https://issues.apache.org/jira/browse/LUCENENET-202
> Project: Lucene.Net
> Issue Type: Bug
> Environment: VS C# Express 2008. A
> Reporter: Corey Trager
> Attachments: LUCENENET-202.patch
>
>
> C:\cit\lucene\C#\src\Lucene.Net\Search\ComplexExplanation.cs(69,12): warning CS0472: The result of the expression is always 'true' since a value of type 'bool' is never equal to 'null' of type 'bool?'
> C:\cit\lucene\C#\src\Lucene.Net\Search\ComplexExplanation.cs(69,24): warning CS0429: Unreachable expression code detected
> C:\cit\lucene\C#\src\Lucene.Net\Index\FormatPostingsDocsWriter.cs(42,17): warning CS0649: Field 'Lucene.Net.Index.FormatPostingsDocsWriter.freqStart' is never assigned to, and will always have its default value 0
> C:\cit\lucene\C#\src\Lucene.Net\Analysis\Standard\StandardTokenizerImpl.cs(230,15): warning CS0414: The field 'Lucene.Net.Analysis.Standard.StandardTokenizerImpl.yycolumn' is assigned but its value is never used
> C:\cit\lucene\C#\src\Lucene.Net\Analysis\Standard\StandardTokenizerImpl.cs(233,16): warning CS0414: The field 'Lucene.Net.Analysis.Standard.StandardTokenizerImpl.zzAtBOL' is assigned but its value is never used
> C:\cit\lucene\C#\src\Lucene.Net\Index\DocFieldProcessorPerThread.cs(42,18): warning CS0649: Field 'Lucene.Net.Index.DocFieldProcessorPerThread.docBoost' is never assigned to, and will always have its default value 0
> C:\cit\lucene\C#\src\Lucene.Net\Index\CharBlockPool.cs(31,16): warning CS0649: Field 'Lucene.Net.Index.CharBlockPool.numBuffer' is never assigned to, and will always have its default value 0
> C:\cit\lucene\C#\src\Lucene.Net\Store\NIOFSDirectory.cs(87,35): warning CS0649: Field 'Lucene.Net.Store.NIOFSDirectory.NIOFSIndexInput.byteBuf' is never assigned to, and will always have its default value null
> C:\cit\lucene\C#\src\Lucene.Net\Store\NIOFSDirectory.cs(90,35): warning CS0649: Field 'Lucene.Net.Store.NIOFSDirectory.NIOFSIndexInput.otherByteBuf' is never assigned to, and will always have its default value null
> C:\cit\lucene\C#\src\Lucene.Net\Analysis\CharReader.cs(32,35): warning CS0649: Field 'Lucene.Net.Analysis.CharReader.input' is never assigned to, and will always have its default value null
> C:\cit\lucene\C#\src\Lucene.Net\Index\DocumentsWriter.cs(181,37): warning CS0649: Field 'Lucene.Net.Index.DocumentsWriter.newFiles' is never assigned to, and will always have its default value null
> C:\cit\lucene\C#\src\Lucene.Net\Index\TermVectorsTermsWriter.cs(35,30): warning CS0649: Field 'Lucene.Net.Index.TermVectorsTermsWriter.termVectorsWriter' is never assigned to, and will always have its default value null
> C:\cit\lucene\C#\src\Lucene.Net\Index\TermsHash.cs(43,21): warning CS0169: The field 'Lucene.Net.Index.TermsHash.primaryTermsHash' is never used
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (LUCENENET-202) Compile warnings trying to build
source code, svn revision 829945
Posted by "Michael Garski (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENENET-202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12784282#action_12784282 ]
Michael Garski commented on LUCENENET-202:
------------------------------------------
I don't think the suppression of warnings, even those as seemingly innocuous as XML documentation comments, should be done but rather correct the underlying issues that lead to the warnings.
> Compile warnings trying to build source code, svn revision 829945
> -----------------------------------------------------------------
>
> Key: LUCENENET-202
> URL: https://issues.apache.org/jira/browse/LUCENENET-202
> Project: Lucene.Net
> Issue Type: Bug
> Environment: VS C# Express 2008. A
> Reporter: Corey Trager
> Attachments: csproj.patch, LUCENENET-202.patch
>
>
> C:\cit\lucene\C#\src\Lucene.Net\Search\ComplexExplanation.cs(69,12): warning CS0472: The result of the expression is always 'true' since a value of type 'bool' is never equal to 'null' of type 'bool?'
> C:\cit\lucene\C#\src\Lucene.Net\Search\ComplexExplanation.cs(69,24): warning CS0429: Unreachable expression code detected
> C:\cit\lucene\C#\src\Lucene.Net\Index\FormatPostingsDocsWriter.cs(42,17): warning CS0649: Field 'Lucene.Net.Index.FormatPostingsDocsWriter.freqStart' is never assigned to, and will always have its default value 0
> C:\cit\lucene\C#\src\Lucene.Net\Analysis\Standard\StandardTokenizerImpl.cs(230,15): warning CS0414: The field 'Lucene.Net.Analysis.Standard.StandardTokenizerImpl.yycolumn' is assigned but its value is never used
> C:\cit\lucene\C#\src\Lucene.Net\Analysis\Standard\StandardTokenizerImpl.cs(233,16): warning CS0414: The field 'Lucene.Net.Analysis.Standard.StandardTokenizerImpl.zzAtBOL' is assigned but its value is never used
> C:\cit\lucene\C#\src\Lucene.Net\Index\DocFieldProcessorPerThread.cs(42,18): warning CS0649: Field 'Lucene.Net.Index.DocFieldProcessorPerThread.docBoost' is never assigned to, and will always have its default value 0
> C:\cit\lucene\C#\src\Lucene.Net\Index\CharBlockPool.cs(31,16): warning CS0649: Field 'Lucene.Net.Index.CharBlockPool.numBuffer' is never assigned to, and will always have its default value 0
> C:\cit\lucene\C#\src\Lucene.Net\Store\NIOFSDirectory.cs(87,35): warning CS0649: Field 'Lucene.Net.Store.NIOFSDirectory.NIOFSIndexInput.byteBuf' is never assigned to, and will always have its default value null
> C:\cit\lucene\C#\src\Lucene.Net\Store\NIOFSDirectory.cs(90,35): warning CS0649: Field 'Lucene.Net.Store.NIOFSDirectory.NIOFSIndexInput.otherByteBuf' is never assigned to, and will always have its default value null
> C:\cit\lucene\C#\src\Lucene.Net\Analysis\CharReader.cs(32,35): warning CS0649: Field 'Lucene.Net.Analysis.CharReader.input' is never assigned to, and will always have its default value null
> C:\cit\lucene\C#\src\Lucene.Net\Index\DocumentsWriter.cs(181,37): warning CS0649: Field 'Lucene.Net.Index.DocumentsWriter.newFiles' is never assigned to, and will always have its default value null
> C:\cit\lucene\C#\src\Lucene.Net\Index\TermVectorsTermsWriter.cs(35,30): warning CS0649: Field 'Lucene.Net.Index.TermVectorsTermsWriter.termVectorsWriter' is never assigned to, and will always have its default value null
> C:\cit\lucene\C#\src\Lucene.Net\Index\TermsHash.cs(43,21): warning CS0169: The field 'Lucene.Net.Index.TermsHash.primaryTermsHash' is never used
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (LUCENENET-202) Compile warnings trying to build
source code, svn revision 829945
Posted by "Corey Trager (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENENET-202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12775441#action_12775441 ]
Corey Trager commented on LUCENENET-202:
----------------------------------------
At least look at ComplexExplanation line 69.
> Compile warnings trying to build source code, svn revision 829945
> -----------------------------------------------------------------
>
> Key: LUCENENET-202
> URL: https://issues.apache.org/jira/browse/LUCENENET-202
> Project: Lucene.Net
> Issue Type: Bug
> Environment: VS C# Express 2008. A
> Reporter: Corey Trager
>
> C:\cit\lucene\C#\src\Lucene.Net\Search\ComplexExplanation.cs(69,12): warning CS0472: The result of the expression is always 'true' since a value of type 'bool' is never equal to 'null' of type 'bool?'
> C:\cit\lucene\C#\src\Lucene.Net\Search\ComplexExplanation.cs(69,24): warning CS0429: Unreachable expression code detected
> C:\cit\lucene\C#\src\Lucene.Net\Index\FormatPostingsDocsWriter.cs(42,17): warning CS0649: Field 'Lucene.Net.Index.FormatPostingsDocsWriter.freqStart' is never assigned to, and will always have its default value 0
> C:\cit\lucene\C#\src\Lucene.Net\Analysis\Standard\StandardTokenizerImpl.cs(230,15): warning CS0414: The field 'Lucene.Net.Analysis.Standard.StandardTokenizerImpl.yycolumn' is assigned but its value is never used
> C:\cit\lucene\C#\src\Lucene.Net\Analysis\Standard\StandardTokenizerImpl.cs(233,16): warning CS0414: The field 'Lucene.Net.Analysis.Standard.StandardTokenizerImpl.zzAtBOL' is assigned but its value is never used
> C:\cit\lucene\C#\src\Lucene.Net\Index\DocFieldProcessorPerThread.cs(42,18): warning CS0649: Field 'Lucene.Net.Index.DocFieldProcessorPerThread.docBoost' is never assigned to, and will always have its default value 0
> C:\cit\lucene\C#\src\Lucene.Net\Index\CharBlockPool.cs(31,16): warning CS0649: Field 'Lucene.Net.Index.CharBlockPool.numBuffer' is never assigned to, and will always have its default value 0
> C:\cit\lucene\C#\src\Lucene.Net\Store\NIOFSDirectory.cs(87,35): warning CS0649: Field 'Lucene.Net.Store.NIOFSDirectory.NIOFSIndexInput.byteBuf' is never assigned to, and will always have its default value null
> C:\cit\lucene\C#\src\Lucene.Net\Store\NIOFSDirectory.cs(90,35): warning CS0649: Field 'Lucene.Net.Store.NIOFSDirectory.NIOFSIndexInput.otherByteBuf' is never assigned to, and will always have its default value null
> C:\cit\lucene\C#\src\Lucene.Net\Analysis\CharReader.cs(32,35): warning CS0649: Field 'Lucene.Net.Analysis.CharReader.input' is never assigned to, and will always have its default value null
> C:\cit\lucene\C#\src\Lucene.Net\Index\DocumentsWriter.cs(181,37): warning CS0649: Field 'Lucene.Net.Index.DocumentsWriter.newFiles' is never assigned to, and will always have its default value null
> C:\cit\lucene\C#\src\Lucene.Net\Index\TermVectorsTermsWriter.cs(35,30): warning CS0649: Field 'Lucene.Net.Index.TermVectorsTermsWriter.termVectorsWriter' is never assigned to, and will always have its default value null
> C:\cit\lucene\C#\src\Lucene.Net\Index\TermsHash.cs(43,21): warning CS0169: The field 'Lucene.Net.Index.TermsHash.primaryTermsHash' is never used
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (LUCENENET-202) Compile warnings trying to build
source code, svn revision 829945
Posted by "Nicholas Paldino (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENENET-202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12784063#action_12784063 ]
Nicholas Paldino commented on LUCENENET-202:
--------------------------------------------
I'm voting down on this patch. There is no such thing as a "safe" warning.
There are some cases where the automated tools create absurd translations, such as:
if (true) return true;
return false;
That kind of code should really be weeded out.
The same with unecessary variables. I know I'm creating a lot of contention because of best practices/.NET/etc/etc, but can this kind of code really be justified in any context? I say no. This isn't even a specialized case, and if anything, makes the code MORE difficult to read and MORE difficult to maintain.
> Compile warnings trying to build source code, svn revision 829945
> -----------------------------------------------------------------
>
> Key: LUCENENET-202
> URL: https://issues.apache.org/jira/browse/LUCENENET-202
> Project: Lucene.Net
> Issue Type: Bug
> Environment: VS C# Express 2008. A
> Reporter: Corey Trager
> Attachments: csproj.patch, LUCENENET-202.patch
>
>
> C:\cit\lucene\C#\src\Lucene.Net\Search\ComplexExplanation.cs(69,12): warning CS0472: The result of the expression is always 'true' since a value of type 'bool' is never equal to 'null' of type 'bool?'
> C:\cit\lucene\C#\src\Lucene.Net\Search\ComplexExplanation.cs(69,24): warning CS0429: Unreachable expression code detected
> C:\cit\lucene\C#\src\Lucene.Net\Index\FormatPostingsDocsWriter.cs(42,17): warning CS0649: Field 'Lucene.Net.Index.FormatPostingsDocsWriter.freqStart' is never assigned to, and will always have its default value 0
> C:\cit\lucene\C#\src\Lucene.Net\Analysis\Standard\StandardTokenizerImpl.cs(230,15): warning CS0414: The field 'Lucene.Net.Analysis.Standard.StandardTokenizerImpl.yycolumn' is assigned but its value is never used
> C:\cit\lucene\C#\src\Lucene.Net\Analysis\Standard\StandardTokenizerImpl.cs(233,16): warning CS0414: The field 'Lucene.Net.Analysis.Standard.StandardTokenizerImpl.zzAtBOL' is assigned but its value is never used
> C:\cit\lucene\C#\src\Lucene.Net\Index\DocFieldProcessorPerThread.cs(42,18): warning CS0649: Field 'Lucene.Net.Index.DocFieldProcessorPerThread.docBoost' is never assigned to, and will always have its default value 0
> C:\cit\lucene\C#\src\Lucene.Net\Index\CharBlockPool.cs(31,16): warning CS0649: Field 'Lucene.Net.Index.CharBlockPool.numBuffer' is never assigned to, and will always have its default value 0
> C:\cit\lucene\C#\src\Lucene.Net\Store\NIOFSDirectory.cs(87,35): warning CS0649: Field 'Lucene.Net.Store.NIOFSDirectory.NIOFSIndexInput.byteBuf' is never assigned to, and will always have its default value null
> C:\cit\lucene\C#\src\Lucene.Net\Store\NIOFSDirectory.cs(90,35): warning CS0649: Field 'Lucene.Net.Store.NIOFSDirectory.NIOFSIndexInput.otherByteBuf' is never assigned to, and will always have its default value null
> C:\cit\lucene\C#\src\Lucene.Net\Analysis\CharReader.cs(32,35): warning CS0649: Field 'Lucene.Net.Analysis.CharReader.input' is never assigned to, and will always have its default value null
> C:\cit\lucene\C#\src\Lucene.Net\Index\DocumentsWriter.cs(181,37): warning CS0649: Field 'Lucene.Net.Index.DocumentsWriter.newFiles' is never assigned to, and will always have its default value null
> C:\cit\lucene\C#\src\Lucene.Net\Index\TermVectorsTermsWriter.cs(35,30): warning CS0649: Field 'Lucene.Net.Index.TermVectorsTermsWriter.termVectorsWriter' is never assigned to, and will always have its default value null
> C:\cit\lucene\C#\src\Lucene.Net\Index\TermsHash.cs(43,21): warning CS0169: The field 'Lucene.Net.Index.TermsHash.primaryTermsHash' is never used
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (LUCENENET-202) Compile warnings trying to build
source code, svn revision 829945
Posted by "Digy (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENENET-202?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Digy updated LUCENENET-202:
---------------------------
Attachment: csproj.patch
Patch for removing unnecessary warnings.
DIGY
> Compile warnings trying to build source code, svn revision 829945
> -----------------------------------------------------------------
>
> Key: LUCENENET-202
> URL: https://issues.apache.org/jira/browse/LUCENENET-202
> Project: Lucene.Net
> Issue Type: Bug
> Environment: VS C# Express 2008. A
> Reporter: Corey Trager
> Attachments: csproj.patch, LUCENENET-202.patch
>
>
> C:\cit\lucene\C#\src\Lucene.Net\Search\ComplexExplanation.cs(69,12): warning CS0472: The result of the expression is always 'true' since a value of type 'bool' is never equal to 'null' of type 'bool?'
> C:\cit\lucene\C#\src\Lucene.Net\Search\ComplexExplanation.cs(69,24): warning CS0429: Unreachable expression code detected
> C:\cit\lucene\C#\src\Lucene.Net\Index\FormatPostingsDocsWriter.cs(42,17): warning CS0649: Field 'Lucene.Net.Index.FormatPostingsDocsWriter.freqStart' is never assigned to, and will always have its default value 0
> C:\cit\lucene\C#\src\Lucene.Net\Analysis\Standard\StandardTokenizerImpl.cs(230,15): warning CS0414: The field 'Lucene.Net.Analysis.Standard.StandardTokenizerImpl.yycolumn' is assigned but its value is never used
> C:\cit\lucene\C#\src\Lucene.Net\Analysis\Standard\StandardTokenizerImpl.cs(233,16): warning CS0414: The field 'Lucene.Net.Analysis.Standard.StandardTokenizerImpl.zzAtBOL' is assigned but its value is never used
> C:\cit\lucene\C#\src\Lucene.Net\Index\DocFieldProcessorPerThread.cs(42,18): warning CS0649: Field 'Lucene.Net.Index.DocFieldProcessorPerThread.docBoost' is never assigned to, and will always have its default value 0
> C:\cit\lucene\C#\src\Lucene.Net\Index\CharBlockPool.cs(31,16): warning CS0649: Field 'Lucene.Net.Index.CharBlockPool.numBuffer' is never assigned to, and will always have its default value 0
> C:\cit\lucene\C#\src\Lucene.Net\Store\NIOFSDirectory.cs(87,35): warning CS0649: Field 'Lucene.Net.Store.NIOFSDirectory.NIOFSIndexInput.byteBuf' is never assigned to, and will always have its default value null
> C:\cit\lucene\C#\src\Lucene.Net\Store\NIOFSDirectory.cs(90,35): warning CS0649: Field 'Lucene.Net.Store.NIOFSDirectory.NIOFSIndexInput.otherByteBuf' is never assigned to, and will always have its default value null
> C:\cit\lucene\C#\src\Lucene.Net\Analysis\CharReader.cs(32,35): warning CS0649: Field 'Lucene.Net.Analysis.CharReader.input' is never assigned to, and will always have its default value null
> C:\cit\lucene\C#\src\Lucene.Net\Index\DocumentsWriter.cs(181,37): warning CS0649: Field 'Lucene.Net.Index.DocumentsWriter.newFiles' is never assigned to, and will always have its default value null
> C:\cit\lucene\C#\src\Lucene.Net\Index\TermVectorsTermsWriter.cs(35,30): warning CS0649: Field 'Lucene.Net.Index.TermVectorsTermsWriter.termVectorsWriter' is never assigned to, and will always have its default value null
> C:\cit\lucene\C#\src\Lucene.Net\Index\TermsHash.cs(43,21): warning CS0169: The field 'Lucene.Net.Index.TermsHash.primaryTermsHash' is never used
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (LUCENENET-202) Compile warnings trying to build
source code, svn revision 829945
Posted by "Corey Trager (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENENET-202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12778060#action_12778060 ]
Corey Trager commented on LUCENENET-202:
----------------------------------------
I'm using VS Express 2008, so I don't think you want my csproj file. But here's the line in it that hides the unimportant warnings that mask the more serious warnings:
<NoWarn>1591 1574 1580 1570 1587 1572 1573 0168 1584 1658</NoWarn>
> Compile warnings trying to build source code, svn revision 829945
> -----------------------------------------------------------------
>
> Key: LUCENENET-202
> URL: https://issues.apache.org/jira/browse/LUCENENET-202
> Project: Lucene.Net
> Issue Type: Bug
> Environment: VS C# Express 2008. A
> Reporter: Corey Trager
>
> C:\cit\lucene\C#\src\Lucene.Net\Search\ComplexExplanation.cs(69,12): warning CS0472: The result of the expression is always 'true' since a value of type 'bool' is never equal to 'null' of type 'bool?'
> C:\cit\lucene\C#\src\Lucene.Net\Search\ComplexExplanation.cs(69,24): warning CS0429: Unreachable expression code detected
> C:\cit\lucene\C#\src\Lucene.Net\Index\FormatPostingsDocsWriter.cs(42,17): warning CS0649: Field 'Lucene.Net.Index.FormatPostingsDocsWriter.freqStart' is never assigned to, and will always have its default value 0
> C:\cit\lucene\C#\src\Lucene.Net\Analysis\Standard\StandardTokenizerImpl.cs(230,15): warning CS0414: The field 'Lucene.Net.Analysis.Standard.StandardTokenizerImpl.yycolumn' is assigned but its value is never used
> C:\cit\lucene\C#\src\Lucene.Net\Analysis\Standard\StandardTokenizerImpl.cs(233,16): warning CS0414: The field 'Lucene.Net.Analysis.Standard.StandardTokenizerImpl.zzAtBOL' is assigned but its value is never used
> C:\cit\lucene\C#\src\Lucene.Net\Index\DocFieldProcessorPerThread.cs(42,18): warning CS0649: Field 'Lucene.Net.Index.DocFieldProcessorPerThread.docBoost' is never assigned to, and will always have its default value 0
> C:\cit\lucene\C#\src\Lucene.Net\Index\CharBlockPool.cs(31,16): warning CS0649: Field 'Lucene.Net.Index.CharBlockPool.numBuffer' is never assigned to, and will always have its default value 0
> C:\cit\lucene\C#\src\Lucene.Net\Store\NIOFSDirectory.cs(87,35): warning CS0649: Field 'Lucene.Net.Store.NIOFSDirectory.NIOFSIndexInput.byteBuf' is never assigned to, and will always have its default value null
> C:\cit\lucene\C#\src\Lucene.Net\Store\NIOFSDirectory.cs(90,35): warning CS0649: Field 'Lucene.Net.Store.NIOFSDirectory.NIOFSIndexInput.otherByteBuf' is never assigned to, and will always have its default value null
> C:\cit\lucene\C#\src\Lucene.Net\Analysis\CharReader.cs(32,35): warning CS0649: Field 'Lucene.Net.Analysis.CharReader.input' is never assigned to, and will always have its default value null
> C:\cit\lucene\C#\src\Lucene.Net\Index\DocumentsWriter.cs(181,37): warning CS0649: Field 'Lucene.Net.Index.DocumentsWriter.newFiles' is never assigned to, and will always have its default value null
> C:\cit\lucene\C#\src\Lucene.Net\Index\TermVectorsTermsWriter.cs(35,30): warning CS0649: Field 'Lucene.Net.Index.TermVectorsTermsWriter.termVectorsWriter' is never assigned to, and will always have its default value null
> C:\cit\lucene\C#\src\Lucene.Net\Index\TermsHash.cs(43,21): warning CS0169: The field 'Lucene.Net.Index.TermsHash.primaryTermsHash' is never used
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (LUCENENET-202) Compile warnings trying to build
source code, svn revision 829945
Posted by "Digy (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENENET-202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12784291#action_12784291 ]
Digy commented on LUCENENET-202:
--------------------------------
Any comments on LUCENENET-202.patch?
DIGY
> Compile warnings trying to build source code, svn revision 829945
> -----------------------------------------------------------------
>
> Key: LUCENENET-202
> URL: https://issues.apache.org/jira/browse/LUCENENET-202
> Project: Lucene.Net
> Issue Type: Bug
> Environment: VS C# Express 2008. A
> Reporter: Corey Trager
> Attachments: csproj.patch, LUCENENET-202.patch
>
>
> C:\cit\lucene\C#\src\Lucene.Net\Search\ComplexExplanation.cs(69,12): warning CS0472: The result of the expression is always 'true' since a value of type 'bool' is never equal to 'null' of type 'bool?'
> C:\cit\lucene\C#\src\Lucene.Net\Search\ComplexExplanation.cs(69,24): warning CS0429: Unreachable expression code detected
> C:\cit\lucene\C#\src\Lucene.Net\Index\FormatPostingsDocsWriter.cs(42,17): warning CS0649: Field 'Lucene.Net.Index.FormatPostingsDocsWriter.freqStart' is never assigned to, and will always have its default value 0
> C:\cit\lucene\C#\src\Lucene.Net\Analysis\Standard\StandardTokenizerImpl.cs(230,15): warning CS0414: The field 'Lucene.Net.Analysis.Standard.StandardTokenizerImpl.yycolumn' is assigned but its value is never used
> C:\cit\lucene\C#\src\Lucene.Net\Analysis\Standard\StandardTokenizerImpl.cs(233,16): warning CS0414: The field 'Lucene.Net.Analysis.Standard.StandardTokenizerImpl.zzAtBOL' is assigned but its value is never used
> C:\cit\lucene\C#\src\Lucene.Net\Index\DocFieldProcessorPerThread.cs(42,18): warning CS0649: Field 'Lucene.Net.Index.DocFieldProcessorPerThread.docBoost' is never assigned to, and will always have its default value 0
> C:\cit\lucene\C#\src\Lucene.Net\Index\CharBlockPool.cs(31,16): warning CS0649: Field 'Lucene.Net.Index.CharBlockPool.numBuffer' is never assigned to, and will always have its default value 0
> C:\cit\lucene\C#\src\Lucene.Net\Store\NIOFSDirectory.cs(87,35): warning CS0649: Field 'Lucene.Net.Store.NIOFSDirectory.NIOFSIndexInput.byteBuf' is never assigned to, and will always have its default value null
> C:\cit\lucene\C#\src\Lucene.Net\Store\NIOFSDirectory.cs(90,35): warning CS0649: Field 'Lucene.Net.Store.NIOFSDirectory.NIOFSIndexInput.otherByteBuf' is never assigned to, and will always have its default value null
> C:\cit\lucene\C#\src\Lucene.Net\Analysis\CharReader.cs(32,35): warning CS0649: Field 'Lucene.Net.Analysis.CharReader.input' is never assigned to, and will always have its default value null
> C:\cit\lucene\C#\src\Lucene.Net\Index\DocumentsWriter.cs(181,37): warning CS0649: Field 'Lucene.Net.Index.DocumentsWriter.newFiles' is never assigned to, and will always have its default value null
> C:\cit\lucene\C#\src\Lucene.Net\Index\TermVectorsTermsWriter.cs(35,30): warning CS0649: Field 'Lucene.Net.Index.TermVectorsTermsWriter.termVectorsWriter' is never assigned to, and will always have its default value null
> C:\cit\lucene\C#\src\Lucene.Net\Index\TermsHash.cs(43,21): warning CS0169: The field 'Lucene.Net.Index.TermsHash.primaryTermsHash' is never used
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (LUCENENET-202) Compile warnings trying to build
source code, svn revision 829945
Posted by "Nicholas Paldino (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENENET-202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12775440#action_12775440 ]
Nicholas Paldino commented on LUCENENET-202:
--------------------------------------------
It's not that much of a concern. While I agree, all warnings should be abolished, the concern is to get the current port of Lucene.NET to match the functionality of the current version of Lucene. It's been discuessed that when they move to .NET 3.5, they are going to branch off, and use .NET code constructs, best practices, etc, etc.
I will strongly suggest that this issue be addressed then, forcing "treat warnings as errors" to be introduced into the project.
> Compile warnings trying to build source code, svn revision 829945
> -----------------------------------------------------------------
>
> Key: LUCENENET-202
> URL: https://issues.apache.org/jira/browse/LUCENENET-202
> Project: Lucene.Net
> Issue Type: Bug
> Environment: VS C# Express 2008. A
> Reporter: Corey Trager
>
> C:\cit\lucene\C#\src\Lucene.Net\Search\ComplexExplanation.cs(69,12): warning CS0472: The result of the expression is always 'true' since a value of type 'bool' is never equal to 'null' of type 'bool?'
> C:\cit\lucene\C#\src\Lucene.Net\Search\ComplexExplanation.cs(69,24): warning CS0429: Unreachable expression code detected
> C:\cit\lucene\C#\src\Lucene.Net\Index\FormatPostingsDocsWriter.cs(42,17): warning CS0649: Field 'Lucene.Net.Index.FormatPostingsDocsWriter.freqStart' is never assigned to, and will always have its default value 0
> C:\cit\lucene\C#\src\Lucene.Net\Analysis\Standard\StandardTokenizerImpl.cs(230,15): warning CS0414: The field 'Lucene.Net.Analysis.Standard.StandardTokenizerImpl.yycolumn' is assigned but its value is never used
> C:\cit\lucene\C#\src\Lucene.Net\Analysis\Standard\StandardTokenizerImpl.cs(233,16): warning CS0414: The field 'Lucene.Net.Analysis.Standard.StandardTokenizerImpl.zzAtBOL' is assigned but its value is never used
> C:\cit\lucene\C#\src\Lucene.Net\Index\DocFieldProcessorPerThread.cs(42,18): warning CS0649: Field 'Lucene.Net.Index.DocFieldProcessorPerThread.docBoost' is never assigned to, and will always have its default value 0
> C:\cit\lucene\C#\src\Lucene.Net\Index\CharBlockPool.cs(31,16): warning CS0649: Field 'Lucene.Net.Index.CharBlockPool.numBuffer' is never assigned to, and will always have its default value 0
> C:\cit\lucene\C#\src\Lucene.Net\Store\NIOFSDirectory.cs(87,35): warning CS0649: Field 'Lucene.Net.Store.NIOFSDirectory.NIOFSIndexInput.byteBuf' is never assigned to, and will always have its default value null
> C:\cit\lucene\C#\src\Lucene.Net\Store\NIOFSDirectory.cs(90,35): warning CS0649: Field 'Lucene.Net.Store.NIOFSDirectory.NIOFSIndexInput.otherByteBuf' is never assigned to, and will always have its default value null
> C:\cit\lucene\C#\src\Lucene.Net\Analysis\CharReader.cs(32,35): warning CS0649: Field 'Lucene.Net.Analysis.CharReader.input' is never assigned to, and will always have its default value null
> C:\cit\lucene\C#\src\Lucene.Net\Index\DocumentsWriter.cs(181,37): warning CS0649: Field 'Lucene.Net.Index.DocumentsWriter.newFiles' is never assigned to, and will always have its default value null
> C:\cit\lucene\C#\src\Lucene.Net\Index\TermVectorsTermsWriter.cs(35,30): warning CS0649: Field 'Lucene.Net.Index.TermVectorsTermsWriter.termVectorsWriter' is never assigned to, and will always have its default value null
> C:\cit\lucene\C#\src\Lucene.Net\Index\TermsHash.cs(43,21): warning CS0169: The field 'Lucene.Net.Index.TermsHash.primaryTermsHash' is never used
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (LUCENENET-202) Compile warnings trying to build
source code, svn revision 829945
Posted by "George Aroush (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENENET-202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12778039#action_12778039 ]
George Aroush commented on LUCENENET-202:
-----------------------------------------
Corey is right. Those extra 'safe' warnings are hiding more serious warnings that need a fix.
Corey: would you like to provide a patch to suppress those 'safe' warnings? Thanks.
> Compile warnings trying to build source code, svn revision 829945
> -----------------------------------------------------------------
>
> Key: LUCENENET-202
> URL: https://issues.apache.org/jira/browse/LUCENENET-202
> Project: Lucene.Net
> Issue Type: Bug
> Environment: VS C# Express 2008. A
> Reporter: Corey Trager
>
> C:\cit\lucene\C#\src\Lucene.Net\Search\ComplexExplanation.cs(69,12): warning CS0472: The result of the expression is always 'true' since a value of type 'bool' is never equal to 'null' of type 'bool?'
> C:\cit\lucene\C#\src\Lucene.Net\Search\ComplexExplanation.cs(69,24): warning CS0429: Unreachable expression code detected
> C:\cit\lucene\C#\src\Lucene.Net\Index\FormatPostingsDocsWriter.cs(42,17): warning CS0649: Field 'Lucene.Net.Index.FormatPostingsDocsWriter.freqStart' is never assigned to, and will always have its default value 0
> C:\cit\lucene\C#\src\Lucene.Net\Analysis\Standard\StandardTokenizerImpl.cs(230,15): warning CS0414: The field 'Lucene.Net.Analysis.Standard.StandardTokenizerImpl.yycolumn' is assigned but its value is never used
> C:\cit\lucene\C#\src\Lucene.Net\Analysis\Standard\StandardTokenizerImpl.cs(233,16): warning CS0414: The field 'Lucene.Net.Analysis.Standard.StandardTokenizerImpl.zzAtBOL' is assigned but its value is never used
> C:\cit\lucene\C#\src\Lucene.Net\Index\DocFieldProcessorPerThread.cs(42,18): warning CS0649: Field 'Lucene.Net.Index.DocFieldProcessorPerThread.docBoost' is never assigned to, and will always have its default value 0
> C:\cit\lucene\C#\src\Lucene.Net\Index\CharBlockPool.cs(31,16): warning CS0649: Field 'Lucene.Net.Index.CharBlockPool.numBuffer' is never assigned to, and will always have its default value 0
> C:\cit\lucene\C#\src\Lucene.Net\Store\NIOFSDirectory.cs(87,35): warning CS0649: Field 'Lucene.Net.Store.NIOFSDirectory.NIOFSIndexInput.byteBuf' is never assigned to, and will always have its default value null
> C:\cit\lucene\C#\src\Lucene.Net\Store\NIOFSDirectory.cs(90,35): warning CS0649: Field 'Lucene.Net.Store.NIOFSDirectory.NIOFSIndexInput.otherByteBuf' is never assigned to, and will always have its default value null
> C:\cit\lucene\C#\src\Lucene.Net\Analysis\CharReader.cs(32,35): warning CS0649: Field 'Lucene.Net.Analysis.CharReader.input' is never assigned to, and will always have its default value null
> C:\cit\lucene\C#\src\Lucene.Net\Index\DocumentsWriter.cs(181,37): warning CS0649: Field 'Lucene.Net.Index.DocumentsWriter.newFiles' is never assigned to, and will always have its default value null
> C:\cit\lucene\C#\src\Lucene.Net\Index\TermVectorsTermsWriter.cs(35,30): warning CS0649: Field 'Lucene.Net.Index.TermVectorsTermsWriter.termVectorsWriter' is never assigned to, and will always have its default value null
> C:\cit\lucene\C#\src\Lucene.Net\Index\TermsHash.cs(43,21): warning CS0169: The field 'Lucene.Net.Index.TermsHash.primaryTermsHash' is never used
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (LUCENENET-202) Compile warnings trying to build
source code, svn revision 829945
Posted by "George Aroush (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENENET-202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12785315#action_12785315 ]
George Aroush commented on LUCENENET-202:
-----------------------------------------
If we can automate the XML documentation comments clean up, let's do that, otherwise I would like to wait on till when we start working on 3.0 to keep the delta low when doing the migration from 2.9.1 -> 3.0.
I will look into the XML doc clean up in a separate JIRA issue.
> Compile warnings trying to build source code, svn revision 829945
> -----------------------------------------------------------------
>
> Key: LUCENENET-202
> URL: https://issues.apache.org/jira/browse/LUCENENET-202
> Project: Lucene.Net
> Issue Type: Bug
> Environment: VS C# Express 2008. A
> Reporter: Corey Trager
> Attachments: csproj.patch, LUCENENET-202.patch
>
>
> C:\cit\lucene\C#\src\Lucene.Net\Search\ComplexExplanation.cs(69,12): warning CS0472: The result of the expression is always 'true' since a value of type 'bool' is never equal to 'null' of type 'bool?'
> C:\cit\lucene\C#\src\Lucene.Net\Search\ComplexExplanation.cs(69,24): warning CS0429: Unreachable expression code detected
> C:\cit\lucene\C#\src\Lucene.Net\Index\FormatPostingsDocsWriter.cs(42,17): warning CS0649: Field 'Lucene.Net.Index.FormatPostingsDocsWriter.freqStart' is never assigned to, and will always have its default value 0
> C:\cit\lucene\C#\src\Lucene.Net\Analysis\Standard\StandardTokenizerImpl.cs(230,15): warning CS0414: The field 'Lucene.Net.Analysis.Standard.StandardTokenizerImpl.yycolumn' is assigned but its value is never used
> C:\cit\lucene\C#\src\Lucene.Net\Analysis\Standard\StandardTokenizerImpl.cs(233,16): warning CS0414: The field 'Lucene.Net.Analysis.Standard.StandardTokenizerImpl.zzAtBOL' is assigned but its value is never used
> C:\cit\lucene\C#\src\Lucene.Net\Index\DocFieldProcessorPerThread.cs(42,18): warning CS0649: Field 'Lucene.Net.Index.DocFieldProcessorPerThread.docBoost' is never assigned to, and will always have its default value 0
> C:\cit\lucene\C#\src\Lucene.Net\Index\CharBlockPool.cs(31,16): warning CS0649: Field 'Lucene.Net.Index.CharBlockPool.numBuffer' is never assigned to, and will always have its default value 0
> C:\cit\lucene\C#\src\Lucene.Net\Store\NIOFSDirectory.cs(87,35): warning CS0649: Field 'Lucene.Net.Store.NIOFSDirectory.NIOFSIndexInput.byteBuf' is never assigned to, and will always have its default value null
> C:\cit\lucene\C#\src\Lucene.Net\Store\NIOFSDirectory.cs(90,35): warning CS0649: Field 'Lucene.Net.Store.NIOFSDirectory.NIOFSIndexInput.otherByteBuf' is never assigned to, and will always have its default value null
> C:\cit\lucene\C#\src\Lucene.Net\Analysis\CharReader.cs(32,35): warning CS0649: Field 'Lucene.Net.Analysis.CharReader.input' is never assigned to, and will always have its default value null
> C:\cit\lucene\C#\src\Lucene.Net\Index\DocumentsWriter.cs(181,37): warning CS0649: Field 'Lucene.Net.Index.DocumentsWriter.newFiles' is never assigned to, and will always have its default value null
> C:\cit\lucene\C#\src\Lucene.Net\Index\TermVectorsTermsWriter.cs(35,30): warning CS0649: Field 'Lucene.Net.Index.TermVectorsTermsWriter.termVectorsWriter' is never assigned to, and will always have its default value null
> C:\cit\lucene\C#\src\Lucene.Net\Index\TermsHash.cs(43,21): warning CS0169: The field 'Lucene.Net.Index.TermsHash.primaryTermsHash' is never used
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (LUCENENET-202) Compile warnings trying to build
source code, svn revision 829945
Posted by "Corey Trager (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENENET-202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12784225#action_12784225 ]
Corey Trager commented on LUCENENET-202:
----------------------------------------
I learned something new that might help folks agree. Just now I removed the suppression of the warnings so that I could see for myself what was being suppressed. Almost all the suppressed warnings had to do with XML documentation. Then I noticed in the project properties window a checkbox labeled "XML documentation file". When I unchecked that, the number of warnings went from 2308 to 131. Of the 131, the majority of them were:
warning CS0168: The variable 'e' is declared but never used
Nothing bad will happen if this warning is suppressed. In your codebase, it's almost always related to a catch (Exception e) where the e is not referenced in the catch block. You can make the warning go away by changing (Exception e) to (Exception).
Would I personally suppress 0168? No. I personally would spend the 10 minutes or so to change the (Exception e) to (Exception) to make the 0168 warnings go away.
> Compile warnings trying to build source code, svn revision 829945
> -----------------------------------------------------------------
>
> Key: LUCENENET-202
> URL: https://issues.apache.org/jira/browse/LUCENENET-202
> Project: Lucene.Net
> Issue Type: Bug
> Environment: VS C# Express 2008. A
> Reporter: Corey Trager
> Attachments: csproj.patch, LUCENENET-202.patch
>
>
> C:\cit\lucene\C#\src\Lucene.Net\Search\ComplexExplanation.cs(69,12): warning CS0472: The result of the expression is always 'true' since a value of type 'bool' is never equal to 'null' of type 'bool?'
> C:\cit\lucene\C#\src\Lucene.Net\Search\ComplexExplanation.cs(69,24): warning CS0429: Unreachable expression code detected
> C:\cit\lucene\C#\src\Lucene.Net\Index\FormatPostingsDocsWriter.cs(42,17): warning CS0649: Field 'Lucene.Net.Index.FormatPostingsDocsWriter.freqStart' is never assigned to, and will always have its default value 0
> C:\cit\lucene\C#\src\Lucene.Net\Analysis\Standard\StandardTokenizerImpl.cs(230,15): warning CS0414: The field 'Lucene.Net.Analysis.Standard.StandardTokenizerImpl.yycolumn' is assigned but its value is never used
> C:\cit\lucene\C#\src\Lucene.Net\Analysis\Standard\StandardTokenizerImpl.cs(233,16): warning CS0414: The field 'Lucene.Net.Analysis.Standard.StandardTokenizerImpl.zzAtBOL' is assigned but its value is never used
> C:\cit\lucene\C#\src\Lucene.Net\Index\DocFieldProcessorPerThread.cs(42,18): warning CS0649: Field 'Lucene.Net.Index.DocFieldProcessorPerThread.docBoost' is never assigned to, and will always have its default value 0
> C:\cit\lucene\C#\src\Lucene.Net\Index\CharBlockPool.cs(31,16): warning CS0649: Field 'Lucene.Net.Index.CharBlockPool.numBuffer' is never assigned to, and will always have its default value 0
> C:\cit\lucene\C#\src\Lucene.Net\Store\NIOFSDirectory.cs(87,35): warning CS0649: Field 'Lucene.Net.Store.NIOFSDirectory.NIOFSIndexInput.byteBuf' is never assigned to, and will always have its default value null
> C:\cit\lucene\C#\src\Lucene.Net\Store\NIOFSDirectory.cs(90,35): warning CS0649: Field 'Lucene.Net.Store.NIOFSDirectory.NIOFSIndexInput.otherByteBuf' is never assigned to, and will always have its default value null
> C:\cit\lucene\C#\src\Lucene.Net\Analysis\CharReader.cs(32,35): warning CS0649: Field 'Lucene.Net.Analysis.CharReader.input' is never assigned to, and will always have its default value null
> C:\cit\lucene\C#\src\Lucene.Net\Index\DocumentsWriter.cs(181,37): warning CS0649: Field 'Lucene.Net.Index.DocumentsWriter.newFiles' is never assigned to, and will always have its default value null
> C:\cit\lucene\C#\src\Lucene.Net\Index\TermVectorsTermsWriter.cs(35,30): warning CS0649: Field 'Lucene.Net.Index.TermVectorsTermsWriter.termVectorsWriter' is never assigned to, and will always have its default value null
> C:\cit\lucene\C#\src\Lucene.Net\Index\TermsHash.cs(43,21): warning CS0169: The field 'Lucene.Net.Index.TermsHash.primaryTermsHash' is never used
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (LUCENENET-202) Compile warnings trying to build
source code, svn revision 829945
Posted by "Digy (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENENET-202?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Digy resolved LUCENENET-202.
----------------------------
Resolution: Fixed
I committed LUCENENET-202.patch (no change in project files).
DIGY
> Compile warnings trying to build source code, svn revision 829945
> -----------------------------------------------------------------
>
> Key: LUCENENET-202
> URL: https://issues.apache.org/jira/browse/LUCENENET-202
> Project: Lucene.Net
> Issue Type: Bug
> Environment: VS C# Express 2008. A
> Reporter: Corey Trager
> Attachments: csproj.patch, LUCENENET-202.patch
>
>
> C:\cit\lucene\C#\src\Lucene.Net\Search\ComplexExplanation.cs(69,12): warning CS0472: The result of the expression is always 'true' since a value of type 'bool' is never equal to 'null' of type 'bool?'
> C:\cit\lucene\C#\src\Lucene.Net\Search\ComplexExplanation.cs(69,24): warning CS0429: Unreachable expression code detected
> C:\cit\lucene\C#\src\Lucene.Net\Index\FormatPostingsDocsWriter.cs(42,17): warning CS0649: Field 'Lucene.Net.Index.FormatPostingsDocsWriter.freqStart' is never assigned to, and will always have its default value 0
> C:\cit\lucene\C#\src\Lucene.Net\Analysis\Standard\StandardTokenizerImpl.cs(230,15): warning CS0414: The field 'Lucene.Net.Analysis.Standard.StandardTokenizerImpl.yycolumn' is assigned but its value is never used
> C:\cit\lucene\C#\src\Lucene.Net\Analysis\Standard\StandardTokenizerImpl.cs(233,16): warning CS0414: The field 'Lucene.Net.Analysis.Standard.StandardTokenizerImpl.zzAtBOL' is assigned but its value is never used
> C:\cit\lucene\C#\src\Lucene.Net\Index\DocFieldProcessorPerThread.cs(42,18): warning CS0649: Field 'Lucene.Net.Index.DocFieldProcessorPerThread.docBoost' is never assigned to, and will always have its default value 0
> C:\cit\lucene\C#\src\Lucene.Net\Index\CharBlockPool.cs(31,16): warning CS0649: Field 'Lucene.Net.Index.CharBlockPool.numBuffer' is never assigned to, and will always have its default value 0
> C:\cit\lucene\C#\src\Lucene.Net\Store\NIOFSDirectory.cs(87,35): warning CS0649: Field 'Lucene.Net.Store.NIOFSDirectory.NIOFSIndexInput.byteBuf' is never assigned to, and will always have its default value null
> C:\cit\lucene\C#\src\Lucene.Net\Store\NIOFSDirectory.cs(90,35): warning CS0649: Field 'Lucene.Net.Store.NIOFSDirectory.NIOFSIndexInput.otherByteBuf' is never assigned to, and will always have its default value null
> C:\cit\lucene\C#\src\Lucene.Net\Analysis\CharReader.cs(32,35): warning CS0649: Field 'Lucene.Net.Analysis.CharReader.input' is never assigned to, and will always have its default value null
> C:\cit\lucene\C#\src\Lucene.Net\Index\DocumentsWriter.cs(181,37): warning CS0649: Field 'Lucene.Net.Index.DocumentsWriter.newFiles' is never assigned to, and will always have its default value null
> C:\cit\lucene\C#\src\Lucene.Net\Index\TermVectorsTermsWriter.cs(35,30): warning CS0649: Field 'Lucene.Net.Index.TermVectorsTermsWriter.termVectorsWriter' is never assigned to, and will always have its default value null
> C:\cit\lucene\C#\src\Lucene.Net\Index\TermsHash.cs(43,21): warning CS0169: The field 'Lucene.Net.Index.TermsHash.primaryTermsHash' is never used
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (LUCENENET-202) Compile warnings trying to build
source code, svn revision 829945
Posted by "Digy (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENENET-202?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Digy updated LUCENENET-202:
---------------------------
Attachment: LUCENENET-202.patch
> Compile warnings trying to build source code, svn revision 829945
> -----------------------------------------------------------------
>
> Key: LUCENENET-202
> URL: https://issues.apache.org/jira/browse/LUCENENET-202
> Project: Lucene.Net
> Issue Type: Bug
> Environment: VS C# Express 2008. A
> Reporter: Corey Trager
> Attachments: csproj.patch, LUCENENET-202.patch
>
>
> C:\cit\lucene\C#\src\Lucene.Net\Search\ComplexExplanation.cs(69,12): warning CS0472: The result of the expression is always 'true' since a value of type 'bool' is never equal to 'null' of type 'bool?'
> C:\cit\lucene\C#\src\Lucene.Net\Search\ComplexExplanation.cs(69,24): warning CS0429: Unreachable expression code detected
> C:\cit\lucene\C#\src\Lucene.Net\Index\FormatPostingsDocsWriter.cs(42,17): warning CS0649: Field 'Lucene.Net.Index.FormatPostingsDocsWriter.freqStart' is never assigned to, and will always have its default value 0
> C:\cit\lucene\C#\src\Lucene.Net\Analysis\Standard\StandardTokenizerImpl.cs(230,15): warning CS0414: The field 'Lucene.Net.Analysis.Standard.StandardTokenizerImpl.yycolumn' is assigned but its value is never used
> C:\cit\lucene\C#\src\Lucene.Net\Analysis\Standard\StandardTokenizerImpl.cs(233,16): warning CS0414: The field 'Lucene.Net.Analysis.Standard.StandardTokenizerImpl.zzAtBOL' is assigned but its value is never used
> C:\cit\lucene\C#\src\Lucene.Net\Index\DocFieldProcessorPerThread.cs(42,18): warning CS0649: Field 'Lucene.Net.Index.DocFieldProcessorPerThread.docBoost' is never assigned to, and will always have its default value 0
> C:\cit\lucene\C#\src\Lucene.Net\Index\CharBlockPool.cs(31,16): warning CS0649: Field 'Lucene.Net.Index.CharBlockPool.numBuffer' is never assigned to, and will always have its default value 0
> C:\cit\lucene\C#\src\Lucene.Net\Store\NIOFSDirectory.cs(87,35): warning CS0649: Field 'Lucene.Net.Store.NIOFSDirectory.NIOFSIndexInput.byteBuf' is never assigned to, and will always have its default value null
> C:\cit\lucene\C#\src\Lucene.Net\Store\NIOFSDirectory.cs(90,35): warning CS0649: Field 'Lucene.Net.Store.NIOFSDirectory.NIOFSIndexInput.otherByteBuf' is never assigned to, and will always have its default value null
> C:\cit\lucene\C#\src\Lucene.Net\Analysis\CharReader.cs(32,35): warning CS0649: Field 'Lucene.Net.Analysis.CharReader.input' is never assigned to, and will always have its default value null
> C:\cit\lucene\C#\src\Lucene.Net\Index\DocumentsWriter.cs(181,37): warning CS0649: Field 'Lucene.Net.Index.DocumentsWriter.newFiles' is never assigned to, and will always have its default value null
> C:\cit\lucene\C#\src\Lucene.Net\Index\TermVectorsTermsWriter.cs(35,30): warning CS0649: Field 'Lucene.Net.Index.TermVectorsTermsWriter.termVectorsWriter' is never assigned to, and will always have its default value null
> C:\cit\lucene\C#\src\Lucene.Net\Index\TermsHash.cs(43,21): warning CS0169: The field 'Lucene.Net.Index.TermsHash.primaryTermsHash' is never used
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (LUCENENET-202) Compile warnings trying to build
source code, svn revision 829945
Posted by "George Aroush (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENENET-202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12785319#action_12785319 ]
George Aroush commented on LUCENENET-202:
-----------------------------------------
Go ahead and commit this patch, DIGY. I created LUCENENET-320 to keep track of cleaning up the XML documentation comments
> Compile warnings trying to build source code, svn revision 829945
> -----------------------------------------------------------------
>
> Key: LUCENENET-202
> URL: https://issues.apache.org/jira/browse/LUCENENET-202
> Project: Lucene.Net
> Issue Type: Bug
> Environment: VS C# Express 2008. A
> Reporter: Corey Trager
> Attachments: csproj.patch, LUCENENET-202.patch
>
>
> C:\cit\lucene\C#\src\Lucene.Net\Search\ComplexExplanation.cs(69,12): warning CS0472: The result of the expression is always 'true' since a value of type 'bool' is never equal to 'null' of type 'bool?'
> C:\cit\lucene\C#\src\Lucene.Net\Search\ComplexExplanation.cs(69,24): warning CS0429: Unreachable expression code detected
> C:\cit\lucene\C#\src\Lucene.Net\Index\FormatPostingsDocsWriter.cs(42,17): warning CS0649: Field 'Lucene.Net.Index.FormatPostingsDocsWriter.freqStart' is never assigned to, and will always have its default value 0
> C:\cit\lucene\C#\src\Lucene.Net\Analysis\Standard\StandardTokenizerImpl.cs(230,15): warning CS0414: The field 'Lucene.Net.Analysis.Standard.StandardTokenizerImpl.yycolumn' is assigned but its value is never used
> C:\cit\lucene\C#\src\Lucene.Net\Analysis\Standard\StandardTokenizerImpl.cs(233,16): warning CS0414: The field 'Lucene.Net.Analysis.Standard.StandardTokenizerImpl.zzAtBOL' is assigned but its value is never used
> C:\cit\lucene\C#\src\Lucene.Net\Index\DocFieldProcessorPerThread.cs(42,18): warning CS0649: Field 'Lucene.Net.Index.DocFieldProcessorPerThread.docBoost' is never assigned to, and will always have its default value 0
> C:\cit\lucene\C#\src\Lucene.Net\Index\CharBlockPool.cs(31,16): warning CS0649: Field 'Lucene.Net.Index.CharBlockPool.numBuffer' is never assigned to, and will always have its default value 0
> C:\cit\lucene\C#\src\Lucene.Net\Store\NIOFSDirectory.cs(87,35): warning CS0649: Field 'Lucene.Net.Store.NIOFSDirectory.NIOFSIndexInput.byteBuf' is never assigned to, and will always have its default value null
> C:\cit\lucene\C#\src\Lucene.Net\Store\NIOFSDirectory.cs(90,35): warning CS0649: Field 'Lucene.Net.Store.NIOFSDirectory.NIOFSIndexInput.otherByteBuf' is never assigned to, and will always have its default value null
> C:\cit\lucene\C#\src\Lucene.Net\Analysis\CharReader.cs(32,35): warning CS0649: Field 'Lucene.Net.Analysis.CharReader.input' is never assigned to, and will always have its default value null
> C:\cit\lucene\C#\src\Lucene.Net\Index\DocumentsWriter.cs(181,37): warning CS0649: Field 'Lucene.Net.Index.DocumentsWriter.newFiles' is never assigned to, and will always have its default value null
> C:\cit\lucene\C#\src\Lucene.Net\Index\TermVectorsTermsWriter.cs(35,30): warning CS0649: Field 'Lucene.Net.Index.TermVectorsTermsWriter.termVectorsWriter' is never assigned to, and will always have its default value null
> C:\cit\lucene\C#\src\Lucene.Net\Index\TermsHash.cs(43,21): warning CS0169: The field 'Lucene.Net.Index.TermsHash.primaryTermsHash' is never used
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (LUCENENET-202) Compile warnings trying to build
source code, svn revision 829945
Posted by "Corey Trager (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENENET-202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12772203#action_12772203 ]
Corey Trager commented on LUCENENET-202:
----------------------------------------
There are many warnings that aren't import at all. Here are the warnings I suppressed:
1591 1574 1580 1570 1587 1572 1573 0168 1584 1658
The two warnings in ComplexExplanation are the ones I would be most concerned about.
> Compile warnings trying to build source code, svn revision 829945
> -----------------------------------------------------------------
>
> Key: LUCENENET-202
> URL: https://issues.apache.org/jira/browse/LUCENENET-202
> Project: Lucene.Net
> Issue Type: Bug
> Environment: VS C# Express 2008. A
> Reporter: Corey Trager
>
> C:\cit\lucene\C#\src\Lucene.Net\Search\ComplexExplanation.cs(69,12): warning CS0472: The result of the expression is always 'true' since a value of type 'bool' is never equal to 'null' of type 'bool?'
> C:\cit\lucene\C#\src\Lucene.Net\Search\ComplexExplanation.cs(69,24): warning CS0429: Unreachable expression code detected
> C:\cit\lucene\C#\src\Lucene.Net\Index\FormatPostingsDocsWriter.cs(42,17): warning CS0649: Field 'Lucene.Net.Index.FormatPostingsDocsWriter.freqStart' is never assigned to, and will always have its default value 0
> C:\cit\lucene\C#\src\Lucene.Net\Analysis\Standard\StandardTokenizerImpl.cs(230,15): warning CS0414: The field 'Lucene.Net.Analysis.Standard.StandardTokenizerImpl.yycolumn' is assigned but its value is never used
> C:\cit\lucene\C#\src\Lucene.Net\Analysis\Standard\StandardTokenizerImpl.cs(233,16): warning CS0414: The field 'Lucene.Net.Analysis.Standard.StandardTokenizerImpl.zzAtBOL' is assigned but its value is never used
> C:\cit\lucene\C#\src\Lucene.Net\Index\DocFieldProcessorPerThread.cs(42,18): warning CS0649: Field 'Lucene.Net.Index.DocFieldProcessorPerThread.docBoost' is never assigned to, and will always have its default value 0
> C:\cit\lucene\C#\src\Lucene.Net\Index\CharBlockPool.cs(31,16): warning CS0649: Field 'Lucene.Net.Index.CharBlockPool.numBuffer' is never assigned to, and will always have its default value 0
> C:\cit\lucene\C#\src\Lucene.Net\Store\NIOFSDirectory.cs(87,35): warning CS0649: Field 'Lucene.Net.Store.NIOFSDirectory.NIOFSIndexInput.byteBuf' is never assigned to, and will always have its default value null
> C:\cit\lucene\C#\src\Lucene.Net\Store\NIOFSDirectory.cs(90,35): warning CS0649: Field 'Lucene.Net.Store.NIOFSDirectory.NIOFSIndexInput.otherByteBuf' is never assigned to, and will always have its default value null
> C:\cit\lucene\C#\src\Lucene.Net\Analysis\CharReader.cs(32,35): warning CS0649: Field 'Lucene.Net.Analysis.CharReader.input' is never assigned to, and will always have its default value null
> C:\cit\lucene\C#\src\Lucene.Net\Index\DocumentsWriter.cs(181,37): warning CS0649: Field 'Lucene.Net.Index.DocumentsWriter.newFiles' is never assigned to, and will always have its default value null
> C:\cit\lucene\C#\src\Lucene.Net\Index\TermVectorsTermsWriter.cs(35,30): warning CS0649: Field 'Lucene.Net.Index.TermVectorsTermsWriter.termVectorsWriter' is never assigned to, and will always have its default value null
> C:\cit\lucene\C#\src\Lucene.Net\Index\TermsHash.cs(43,21): warning CS0169: The field 'Lucene.Net.Index.TermsHash.primaryTermsHash' is never used
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.