You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Alex Clemmer <cl...@gmail.com> on 2016/11/28 18:46:39 UTC

Re: Review Request 53327: CMake: Added build variables for Mesos tests.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53327/#review157093
-----------------------------------------------------------


Ship it!




Ship It!

- Alex Clemmer


On Nov. 21, 2016, 10:08 p.m., Joseph Wu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53327/
> -----------------------------------------------------------
> 
> (Updated Nov. 21, 2016, 10:08 p.m.)
> 
> 
> Review request for mesos, Alex Clemmer and Joris Van Remoortere.
> 
> 
> Bugs: MESOS-5792
>     https://issues.apache.org/jira/browse/MESOS-5792
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> The patch simply adds the mesos-tests target and renames the
> existing `TEST_HELPER_*` definitions to `MESOS_TEST_*`.
> The dependencies for the `test-helper` and the actual tests will
> be identical.
> 
> This review replaces: https://reviews.apache.org/r/49688/
> 
> 
> Diffs
> -----
> 
>   src/tests/CMakeLists.txt cf583ea3f10482b510459fb11a7ecaf76e498391 
>   src/tests/cmake/MesosTestsConfigure.cmake 3f543c010ae87ff04e6b45745bc49ef65b6590ff 
> 
> Diff: https://reviews.apache.org/r/53327/diff/
> 
> 
> Testing
> -------
> 
> cmake ..
> make
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>