You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@helix.apache.org by GitBox <gi...@apache.org> on 2019/10/22 23:33:04 UTC
[GitHub] [helix] narendly commented on a change in pull request #517: Add
typoed name DataPropagationLatencyGuage as deprecated
narendly commented on a change in pull request #517: Add typoed name DataPropagationLatencyGuage as deprecated
URL: https://github.com/apache/helix/pull/517#discussion_r337793669
##########
File path: helix-core/src/main/java/org/apache/helix/monitoring/mbeans/ZkClientPathMonitor.java
##########
@@ -96,6 +102,7 @@ public boolean match(String path) {
private HistogramDynamicMetric _readBytesGauge;
private HistogramDynamicMetric _writeBytesGauge;
private HistogramDynamicMetric _dataPropagationLatencyGauge;
+ private HistogramDynamicMetric _dataPropagationLatencyGuage;
Review comment:
Could you add a deprecated decorator here as well?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org