[GitHub] [superset] betodealmeida edited a comment on pull request #13216: fix: add missing columns

[GitBox <gi...@apache.org>]

betodealmeida edited a comment on pull request #13216:
URL: https://github.com/apache/superset/pull/13216#issuecomment-781593465


   > LGTM. Was this user-reported? If so, do you mind linking the GitHub issue if it exists?
   
   Good call. I saw the reports on Slack and Stackoverflow, but there's also a ticket which I just added.
   
   > I think another way to do this is do the column check in `add_uuid_column_to_import_mixin.py`, then simply re-run the same `upgrade` again in `add_missing_uuid_column.py`. This way you avoid the maximum amount of duplicate code, but I guess current approach works, too.
   
   The problem of modifying the original script is that it forces people to downgrade and upgrade again to fix their database, while adding a new script they just need to upgrade.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org