You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hbase.apache.org by "Clint Morgan (JIRA)" <ji...@apache.org> on 2009/06/24 22:00:07 UTC
[jira] Created: (HBASE-1580) Store scanner does not consult
filter.filterRow at end of scan
Store scanner does not consult filter.filterRow at end of scan
--------------------------------------------------------------
Key: HBASE-1580
URL: https://issues.apache.org/jira/browse/HBASE-1580
Project: Hadoop HBase
Issue Type: Bug
Components: regionserver
Affects Versions: 0.20.0
Reporter: Clint Morgan
I have impelemented a columnValueFilter (with new interface) that should filter out the last of two rows in a table. However, I notice that filterRow is only being called on the first row, and the second row is returned.
This patch fixes it, but needs review. My first attempt at adding the call in the DONE_SCAN case did not fix it, but still seems right. The second addition at the end of the method fixed it.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HBASE-1580) Store scanner does not consult
filter.filterRow at end of scan
Posted by "Clint Morgan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-1580?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Clint Morgan updated HBASE-1580:
--------------------------------
Attachment: 1580.patch
> Store scanner does not consult filter.filterRow at end of scan
> --------------------------------------------------------------
>
> Key: HBASE-1580
> URL: https://issues.apache.org/jira/browse/HBASE-1580
> Project: Hadoop HBase
> Issue Type: Bug
> Components: regionserver
> Affects Versions: 0.20.0
> Reporter: Clint Morgan
> Attachments: 1580.patch
>
>
> I have impelemented a columnValueFilter (with new interface) that should filter out the last of two rows in a table. However, I notice that filterRow is only being called on the first row, and the second row is returned.
> This patch fixes it, but needs review. My first attempt at adding the call in the DONE_SCAN case did not fix it, but still seems right. The second addition at the end of the method fixed it.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (HBASE-1580) Store scanner does not consult
filter.filterRow at end of scan
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-1580?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
stack resolved HBASE-1580.
--------------------------
Resolution: Fixed
Hadoop Flags: [Reviewed]
Thanks for patch Clint. I'll work on 1582 since you're busy for a while.
> Store scanner does not consult filter.filterRow at end of scan
> --------------------------------------------------------------
>
> Key: HBASE-1580
> URL: https://issues.apache.org/jira/browse/HBASE-1580
> Project: Hadoop HBase
> Issue Type: Bug
> Components: regionserver
> Affects Versions: 0.20.0
> Reporter: Clint Morgan
> Fix For: 0.20.0
>
> Attachments: 1580.patch
>
>
> I have impelemented a columnValueFilter (with new interface) that should filter out the last of two rows in a table. However, I notice that filterRow is only being called on the first row, and the second row is returned.
> This patch fixes it, but needs review. My first attempt at adding the call in the DONE_SCAN case did not fix it, but still seems right. The second addition at the end of the method fixed it.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HBASE-1580) Store scanner does not consult
filter.filterRow at end of scan
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-1580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12724384#action_12724384 ]
stack commented on HBASE-1580:
------------------------------
This is kinda hard to test with out a filter that exploits it. Let me add a test over in hbase-1582. Meantime I'll commit this cos two +1s.
> Store scanner does not consult filter.filterRow at end of scan
> --------------------------------------------------------------
>
> Key: HBASE-1580
> URL: https://issues.apache.org/jira/browse/HBASE-1580
> Project: Hadoop HBase
> Issue Type: Bug
> Components: regionserver
> Affects Versions: 0.20.0
> Reporter: Clint Morgan
> Fix For: 0.20.0
>
> Attachments: 1580.patch
>
>
> I have impelemented a columnValueFilter (with new interface) that should filter out the last of two rows in a table. However, I notice that filterRow is only being called on the first row, and the second row is returned.
> This patch fixes it, but needs review. My first attempt at adding the call in the DONE_SCAN case did not fix it, but still seems right. The second addition at the end of the method fixed it.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HBASE-1580) Store scanner does not consult
filter.filterRow at end of scan
Posted by "Jonathan Gray (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-1580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12724367#action_12724367 ]
Jonathan Gray commented on HBASE-1580:
--------------------------------------
Agreed. Patch looks good, but let's get a test in.
> Store scanner does not consult filter.filterRow at end of scan
> --------------------------------------------------------------
>
> Key: HBASE-1580
> URL: https://issues.apache.org/jira/browse/HBASE-1580
> Project: Hadoop HBase
> Issue Type: Bug
> Components: regionserver
> Affects Versions: 0.20.0
> Reporter: Clint Morgan
> Fix For: 0.20.0
>
> Attachments: 1580.patch
>
>
> I have impelemented a columnValueFilter (with new interface) that should filter out the last of two rows in a table. However, I notice that filterRow is only being called on the first row, and the second row is returned.
> This patch fixes it, but needs review. My first attempt at adding the call in the DONE_SCAN case did not fix it, but still seems right. The second addition at the end of the method fixed it.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HBASE-1580) Store scanner does not consult
filter.filterRow at end of scan
Posted by "Clint Morgan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-1580?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Clint Morgan updated HBASE-1580:
--------------------------------
Fix Version/s: 0.20.0
> Store scanner does not consult filter.filterRow at end of scan
> --------------------------------------------------------------
>
> Key: HBASE-1580
> URL: https://issues.apache.org/jira/browse/HBASE-1580
> Project: Hadoop HBase
> Issue Type: Bug
> Components: regionserver
> Affects Versions: 0.20.0
> Reporter: Clint Morgan
> Fix For: 0.20.0
>
> Attachments: 1580.patch
>
>
> I have impelemented a columnValueFilter (with new interface) that should filter out the last of two rows in a table. However, I notice that filterRow is only being called on the first row, and the second row is returned.
> This patch fixes it, but needs review. My first attempt at adding the call in the DONE_SCAN case did not fix it, but still seems right. The second addition at the end of the method fixed it.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HBASE-1580) Store scanner does not consult
filter.filterRow at end of scan
Posted by "ryan rawson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-1580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12724260#action_12724260 ]
ryan rawson commented on HBASE-1580:
------------------------------------
+1 looks good.
It would be nice to add a test so we don't get any regressions in the future.
> Store scanner does not consult filter.filterRow at end of scan
> --------------------------------------------------------------
>
> Key: HBASE-1580
> URL: https://issues.apache.org/jira/browse/HBASE-1580
> Project: Hadoop HBase
> Issue Type: Bug
> Components: regionserver
> Affects Versions: 0.20.0
> Reporter: Clint Morgan
> Fix For: 0.20.0
>
> Attachments: 1580.patch
>
>
> I have impelemented a columnValueFilter (with new interface) that should filter out the last of two rows in a table. However, I notice that filterRow is only being called on the first row, and the second row is returned.
> This patch fixes it, but needs review. My first attempt at adding the call in the DONE_SCAN case did not fix it, but still seems right. The second addition at the end of the method fixed it.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.