[jira] [Comment Edited] (SOLR-13263) Facet Heat Map should support GeoJSON

["Bar Rotstein (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SOLR-13263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16831948#comment-16831948 ] 

Bar Rotstein edited comment on SOLR-13263 at 5/2/19 8:50 PM:
-------------------------------------------------------------

{quote}Another point: with spatialContextFactory="Geo3D" we support polygons today. It's easy to forget this.
{quote}
I tried using the geo3d context to no avail. 
[^SOLR-13263-nocommit-geo3d-failure.patch] 
 I uploaded a new no commit patch, with a few tweak and two additional unit tests:
 # SpatialHeatmapFacetsTest#testGeoJsonFacets -> This test uses a GeoJSON polygon for a facet, and is heavily based upon SpatialHeatmapFacetsTest#testJsonFacets. I suspect this test currently fails because of an odd parsing bug.
 # SpatialHeatmapFacetsTest#testGeoJsonBounds -> This test shows the odd behavior showcased by Geo3D parsing context. When a Polygon is parsed in GeoJson form, its bounding box seems to default to GeoWorld, as can be seen in SpatialHeatmapFacetsTest#testGeoJsonBounds:341.

I will now give JTS geo context a go.
 Any way,
 I felt like this should be reported.

[~dsmiley],
 do you have any idea what might have caused this?


was (Author: brot):
{quote}Another point: with spatialContextFactory="Geo3D" we support polygons today. It's easy to forget this.
{quote}
I tried using the geo3d context to no avail. [^SOLR-13263-nocommit-geo3d-failure.patch] 
 I added two unit tests:
 # SpatialHeatmapFacetsTest#testGeoJsonFacets -> This test uses a GeoJSON polygon for a facet, and is heavily based upon SpatialHeatmapFacetsTest#testJsonFacets. I suspect this test currently fails because of an odd parsing bug.
 # SpatialHeatmapFacetsTest#testGeoJsonBounds -> This test shows the odd behavior showcased by Geo3D parsing context. When a Polygon is parsed in GeoJson form, its bounding box seems to default to GeoWorld, as can be seen in SpatialHeatmapFacetsTest#testGeoJsonBounds:341.

I will now give JTS geo context a go.
Any way,
I felt like this should be reported.

[~dsmiley],
 do you have any idea what might have caused this?

> Facet Heat Map should support GeoJSON
> -------------------------------------
>
>                 Key: SOLR-13263
>                 URL: https://issues.apache.org/jira/browse/SOLR-13263
>             Project: Solr
>          Issue Type: Bug
>      Security Level: Public(Default Security Level. Issues are Public) 
>          Components: Facet Module, faceting
>    Affects Versions: 8.0, 8.1, master (9.0)
>            Reporter: Bar Rotstein
>            Priority: Major
>              Labels: Facets, Geolocation, facet, faceting, geo
>         Attachments: SOLR-13263-nocommit-geo3d-failure.patch, SOLR-13263-nocommit.patch
>
>
> Currently Facet Heatmap(Geographical facets) do not support any other subjects other than WKT or '[ ]'. This seems to be caused since FacetHeatmap.Parser#parse uses SpatialUtils#parseGeomSolrException, which in turn uses a deprecated JTS method (SpatialContext#readShapeFromWkt) to parse the string input.
> The newer method of parsing a String to a Shape object should be used, makes the code a lot cleaner and should support more formats (including GeoJSON).



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org