You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/02/20 07:35:38 UTC

[GitHub] [spark] yuchenhuo opened a new pull request #31599: [SPARK-34481] Refactor dataframe reader/writer optionsWithPath logic

yuchenhuo opened a new pull request #31599:
URL: https://github.com/apache/spark/pull/31599


   ### What changes were proposed in this pull request?
   
   Extract optionsWithPath logic into their own function.
   
   ### Why are the changes needed?
   
   Reduce the code duplication and improve modularity.
   
   
   ### Does this PR introduce _any_ user-facing change?
   No
   
   
   ### How was this patch tested?
   Just some refactoring. Existing tests.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on pull request #31599: [SPARK-34481] Refactor dataframe reader/writer optionsWithPath logic

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31599:
URL: https://github.com/apache/spark/pull/31599#issuecomment-782619791


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/135301/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #31599: [SPARK-34481] Refactor dataframe reader/writer optionsWithPath logic

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31599:
URL: https://github.com/apache/spark/pull/31599#issuecomment-782591787


   Kubernetes integration test starting
   URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/39881/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] dongjoon-hyun closed pull request #31599: [SPARK-34481][SQL] Refactor dataframe reader/writer optionsWithPath logic

Posted by GitBox <gi...@apache.org>.
dongjoon-hyun closed pull request #31599:
URL: https://github.com/apache/spark/pull/31599


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #31599: [SPARK-34481] Refactor dataframe reader/writer optionsWithPath logic

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31599:
URL: https://github.com/apache/spark/pull/31599#issuecomment-782595225


   Kubernetes integration test status success
   URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/39881/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on pull request #31599: [SPARK-34481] Refactor dataframe reader/writer optionsWithPath logic

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31599:
URL: https://github.com/apache/spark/pull/31599#issuecomment-782599591


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/39881/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on pull request #31599: [SPARK-34481] Refactor dataframe reader/writer optionsWithPath logic

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31599:
URL: https://github.com/apache/spark/pull/31599#issuecomment-782599591


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/39881/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] dongjoon-hyun commented on pull request #31599: [SPARK-34481][SQL] Refactor dataframe reader/writer optionsWithPath logic

Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #31599:
URL: https://github.com/apache/spark/pull/31599#issuecomment-782781019


   Merged to master. Thanks, @yuchenhuo .


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #31599: [SPARK-34481] Refactor dataframe reader/writer optionsWithPath logic

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31599:
URL: https://github.com/apache/spark/pull/31599#issuecomment-782583818


   **[Test build #135301 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/135301/testReport)** for PR 31599 at commit [`c95f5aa`](https://github.com/apache/spark/commit/c95f5aa5451f3f145794f18310e5df53595df634).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #31599: [SPARK-34481] Refactor dataframe reader/writer optionsWithPath logic

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31599:
URL: https://github.com/apache/spark/pull/31599#issuecomment-782619483


   **[Test build #135301 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/135301/testReport)** for PR 31599 at commit [`c95f5aa`](https://github.com/apache/spark/commit/c95f5aa5451f3f145794f18310e5df53595df634).
    * This patch passes all tests.
    * This patch merges cleanly.
    * This patch adds no public classes.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA removed a comment on pull request #31599: [SPARK-34481] Refactor dataframe reader/writer optionsWithPath logic

Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #31599:
URL: https://github.com/apache/spark/pull/31599#issuecomment-782583818


   **[Test build #135301 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/135301/testReport)** for PR 31599 at commit [`c95f5aa`](https://github.com/apache/spark/commit/c95f5aa5451f3f145794f18310e5df53595df634).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org