You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Jaakko Laine (JIRA)" <ji...@apache.org> on 2009/11/13 08:44:39 UTC

[jira] Created: (CASSANDRA-548) Make sure application states are delivered in correct order

Make sure application states are delivered in correct order
-----------------------------------------------------------

                 Key: CASSANDRA-548
                 URL: https://issues.apache.org/jira/browse/CASSANDRA-548
             Project: Cassandra
          Issue Type: Bug
          Components: Core
    Affects Versions: 0.5
            Reporter: Jaakko Laine
             Fix For: 0.5


Application states must be delivered to subscribers in the same logical order they were added.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (CASSANDRA-548) Make sure application states are delivered in correct order

Posted by "Jaakko Laine (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CASSANDRA-548?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jaakko Laine updated CASSANDRA-548:
-----------------------------------

    Attachment:     (was: 548-deliver-ap-states-in-correct-order.patch)

> Make sure application states are delivered in correct order
> -----------------------------------------------------------
>
>                 Key: CASSANDRA-548
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-548
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Core
>    Affects Versions: 0.5
>            Reporter: Jaakko Laine
>             Fix For: 0.5
>
>         Attachments: 548-deliver-ap-states-in-correct-order.patch
>
>
> Application states must be delivered to subscribers in the same logical order they were added.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (CASSANDRA-548) Make sure application states are delivered in correct order

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CASSANDRA-548?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12778844#action_12778844 ] 

Hudson commented on CASSANDRA-548:
----------------------------------

Integrated in Cassandra #261 (See [http://hudson.zones.apache.org/hudson/job/Cassandra/261/])
    add getSortedApplicationStates to preserve state ordering when re-gossiping to other nodes.  patch by Jaakko Laine; reviewed by jbellis for 


> Make sure application states are delivered in correct order
> -----------------------------------------------------------
>
>                 Key: CASSANDRA-548
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-548
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Core
>    Affects Versions: 0.5
>            Reporter: Jaakko Laine
>            Assignee: Jaakko Laine
>             Fix For: 0.5
>
>         Attachments: 548-deliver-ap-states-in-correct-order.patch
>
>
> Application states must be delivered to subscribers in the same logical order they were added.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (CASSANDRA-548) Make sure application states are delivered in correct order

Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CASSANDRA-548?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12777660#action_12777660 ] 

Jonathan Ellis commented on CASSANDRA-548:
------------------------------------------

looks good overall; some improvements:

implement Comparable<AppState>, to avoid having to cast so much

sorting with ArrayList and Collections.sort is going to be much faster than TreeSet and LinkedList

prefer inlining used-only-once variables like List<String> stateNames

> Make sure application states are delivered in correct order
> -----------------------------------------------------------
>
>                 Key: CASSANDRA-548
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-548
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Core
>    Affects Versions: 0.5
>            Reporter: Jaakko Laine
>             Fix For: 0.5
>
>         Attachments: 548-deliver-ap-states-in-correct-order.patch
>
>
> Application states must be delivered to subscribers in the same logical order they were added.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (CASSANDRA-548) Make sure application states are delivered in correct order

Posted by "Jaakko Laine (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CASSANDRA-548?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jaakko Laine updated CASSANDRA-548:
-----------------------------------

    Attachment: 548-deliver-ap-states-in-correct-order.patch

New version. The list of application states still gets copied twice, but since we're returing list of 'keys' ordered by 'value' criteria, there does not seem to be any data structure that would support that directly. We could of course return the list of map entries after it has been ordered, but that would make it slightly awkward to use. Another option would be to keep application states always in order.


> Make sure application states are delivered in correct order
> -----------------------------------------------------------
>
>                 Key: CASSANDRA-548
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-548
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Core
>    Affects Versions: 0.5
>            Reporter: Jaakko Laine
>             Fix For: 0.5
>
>         Attachments: 548-deliver-ap-states-in-correct-order.patch
>
>
> Application states must be delivered to subscribers in the same logical order they were added.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (CASSANDRA-548) Make sure application states are delivered in correct order

Posted by "Jaakko Laine (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CASSANDRA-548?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jaakko Laine updated CASSANDRA-548:
-----------------------------------

    Attachment: 548-deliver-ap-states-in-correct-order.patch

> Make sure application states are delivered in correct order
> -----------------------------------------------------------
>
>                 Key: CASSANDRA-548
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-548
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Core
>    Affects Versions: 0.5
>            Reporter: Jaakko Laine
>             Fix For: 0.5
>
>         Attachments: 548-deliver-ap-states-in-correct-order.patch
>
>
> Application states must be delivered to subscribers in the same logical order they were added.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.