[GitHub] brodybits commented on a change in pull request #577: Other target-dir remapping fixes

[GitBox <gi...@apache.org>]

brodybits commented on a change in pull request #577: Other target-dir remapping fixes
URL: https://github.com/apache/cordova-android/pull/577#discussion_r235987062
 
 

 ##########
 File path: bin/templates/cordova/lib/pluginHandlers.js
 ##########
 @@ -303,13 +303,13 @@ function getInstallDestination (obj) {
         return path.join(APP_MAIN_PREFIX, 'java', obj.targetDir.substring(4), path.basename(obj.src));
     } else if (obj.src.endsWith('.aidl')) {
         return path.join(APP_MAIN_PREFIX, 'aidl', obj.targetDir.substring(4), path.basename(obj.src));
-    } else if (obj.targetDir.includes('libs')) {
+    } else if (obj.targetDir.startsWith('libs')) {
 
 Review comment:
   From PR #576: What if there is a character other than `/` after `libs`?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org