You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2020/04/06 20:55:30 UTC
[GitHub] [incubator-iceberg] rdblue commented on a change in pull request
#896: Avro: Support partition values using a constants map
rdblue commented on a change in pull request #896: Avro: Support partition values using a constants map
URL: https://github.com/apache/incubator-iceberg/pull/896#discussion_r404382236
##########
File path: core/src/main/java/org/apache/iceberg/util/ByteBuffers.java
##########
@@ -41,7 +41,7 @@
}
} else {
byte[] bytes = new byte[buffer.remaining()];
- buffer.get(bytes);
+ buffer.asReadOnlyBuffer().get(bytes);
Review comment:
I did a quick check on this method to make sure the incoming buffer is not modified and found that it is for off-heap buffers. This fixes the problem, but isn't really related. If anyone prefers, I can move this to a separate PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org