[GitHub] [incubator-pinot] mcvsubbu commented on pull request #6613: Basic Auth for pinot-controller

[GitBox <gi...@apache.org>]

mcvsubbu commented on pull request #6613:
URL: https://github.com/apache/incubator-pinot/pull/6613#issuecomment-799867494


   > > Do you need to change LLCSegmentCompletionHandlers to pay attention to the auth token?
   > 
   > Probably. I'd appreciate your input on where this actually talks to controller APIs. I just noticed that this whole set of endpoints was excluded from my checklist (via swagger)
   
   These endpoints should not appear in Swagger because they are used by pinot-server to commit realtime segments using the segment commit protocol. They are not meant for administrative or user actions. These are completely pinot internal operations.
   The client side of this call is in ServerSegmentProtocolCompletionHandler.
   
   If you can make these changes in another PR, that will help reviewing a bit. If I miss something and it causes realtime segments not to complete segments, that will be really bad. 
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org