You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/07/02 09:41:02 UTC

[GitHub] [airflow] Swalloow opened a new issue #9627: MySQL support in Helm airflow database config

Swalloow opened a new issue #9627:
URL: https://github.com/apache/airflow/issues/9627


   <!--
   
   Welcome to Apache Airflow!  For a smooth issue process, try to answer the following questions.
   Don't worry if they're not all applicable; just try to include what you can :-)
   
   If you need to include code snippets or logs, please put them in fenced code
   blocks.  If they're super-long, please use the details tag like
   <details><summary>super-long log</summary> lots of stuff </details>
   
   Please delete these comment blocks before submitting the issue.
   
   -->
   
   <!--
   
   IMPORTANT!!!
   
   PLEASE CHECK "SIMILAR TO X EXISTING ISSUES" OPTION IF VISIBLE
   NEXT TO "SUBMIT NEW ISSUE" BUTTON!!!
   
   PLEASE CHECK IF THIS ISSUE HAS BEEN REPORTED PREVIOUSLY USING SEARCH!!!
   
   Please complete the next sections or the issue will be closed.
   This questions are the first thing we need to know to understand the context.
   
   -->
   
   **Apache Airflow version**: 1.10.10
   
   **Kubernetes version (if you are using kubernetes)** (use `kubectl version`): 1.16
   
   **Environment**:
   
   - **Cloud provider or hardware configuration**: AWS EKS
   - **OS** (e.g. from /etc/os-release): AWS EKS default AMI
   - **Kernel** (e.g. `uname -a`):
   - **Install tools**:
   - **Others**: airflow metadata db as AWS Aurora 5.6.4+
   
   **What happened**: 
   
   Deploy official helm chart from master branch and update `values.yaml` file as below.
   I use AWS Aurora as database.
   
   ```
   # Airflow database config
   data:
     # If secret names are provided, use those secrets
     metadataSecretName: ~
     resultBackendSecretName: ~
   
     # Otherwise pass connection values in
     # FIXME:
     metadataConnection:
       user: MYAURORA_USER
       pass: MYAURORA_PASSWORD
       host: MYAURORA_URL
       port: 3306
       db: airflow
       sslmode: disable
     resultBackendConnection:
       user: MYAURORA_USER
       pass: MYAURORA_PASSWORD
       host: MYAURORA_URL
       port: 3306
       db: airflow
       sslmode: disable
   ```
   
   After install helm chart, an error occurred in scheduler initContainer phase.
   
   ```
   $ kubectl get po -n airflow
   NAME                                     READY   STATUS       RESTARTS   AGE
   airflow-dev-create-user-v84lr            0/1     Error        1          18s
   airflow-dev-scheduler-695894dbc7-jz9qx   0/2     Init:Error   1          18s
   airflow-dev-statsd-7f5fbdc8c4-49487      1/1     Running      0          18s
   airflow-dev-webserver-547664465f-hqh54   0/1     Init:0/1     0          18s
   
   $ kubectl describe po -n airflow airflow-dev-scheduler-695894dbc7-jz9qx
   ...
   Init Containers:
     run-airflow-migrations:
       Container ID:  docker://9b431e2584a68afdcdacd7f7043e6facd46c38ab577dd427f14a3a79782a934d
       Image:         apache/airflow:1.10.10.1-alpha2-python3.6
       Image ID:      docker-pullable://apache/airflow@sha256:f44d93b67f58a761aab9c4ed5804b4df2fd15050a9c561413d722eb619c064d5
       Port:          <none>
       Host Port:     <none>
       Args:
         bash
         -c
         airflow upgradedb || airflow db upgrade
       State:          Terminated
         Reason:       Error
         Exit Code:    2
         Started:      Thu, 02 Jul 2020 18:18:09 +0900
         Finished:     Thu, 02 Jul 2020 18:18:15 +0900
       Last State:     Terminated
         Reason:       Error
         Exit Code:    2
         Started:      Thu, 02 Jul 2020 18:17:23 +0900
         Finished:     Thu, 02 Jul 2020 18:17:29 +0900
       Ready:          False
       Restart Count:  4
       Environment:
         AIRFLOW__CORE__FERNET_KEY:        <set to the key 'fernet-key' in secret 'airflow-dev-fernet-key'>        Optional: false
         AIRFLOW__CORE__SQL_ALCHEMY_CONN:  <set to the key 'connection' in secret 'airflow-dev-airflow-metadata'>  Optional: false
         AIRFLOW_CONN_AIRFLOW_DB:          <set to the key 'connection' in secret 'airflow-dev-airflow-metadata'>  Optional: false
       Mounts:
         /var/run/secrets/kubernetes.io/serviceaccount from airflow-dev-scheduler-serviceaccount-token-vh5td (ro)
   ```
   
   <!-- (please include exact error messages if you can) -->
   
   **What you expected to happen**:
   
   I expected to support mysql addresses as well.
   However, if you look at the secret yaml file, it is fixed at db+postgresql:// address.
   (`chart/templates/secrets/result-backend-connection-secret.yaml`)
   
   <!-- What do you think went wrong? -->
   
   **How to reproduce it**:
   
   helm install . --name airflow --namespace airflow
   
   <!---
   
   As minimally and precisely as possible. Keep in mind we do not have access to your cluster or dags.
   
   If you are using kubernetes, please attempt to recreate the issue using minikube or kind.
   
   ## Install minikube/kind
   
   - Minikube https://minikube.sigs.k8s.io/docs/start/
   - Kind https://kind.sigs.k8s.io/docs/user/quick-start/
   
   If this is a UI bug, please provide a screenshot of the bug or a link to a youtube video of the bug in action
   
   You can include images using the .md sytle of
   ![alt text](http://url/to/img.png)
   
   To record a screencast, mac users can use QuickTime and then create an unlisted youtube video with the resulting .mov file.
   
   --->
   
   
   **Anything else we need to know**:
   
   <!--
   
   How often does this problem occur? Once? Every time etc?
   
   Any relevant logs to include? Put them here in side a detail tag:
   <details><summary>x.log</summary> lots of stuff </details>
   
   -->
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] potiuk commented on issue #9627: MySQL support in Helm airflow database config

Posted by GitBox <gi...@apache.org>.
potiuk commented on issue #9627:
URL: https://github.com/apache/airflow/issues/9627#issuecomment-706034434


   Yeah. Woudl be great !


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] gstein commented on issue #9627: MySQL support in Helm airflow database config

Posted by GitBox <gi...@apache.org>.
gstein commented on issue #9627:
URL: https://github.com/apache/airflow/issues/9627#issuecomment-652933545


   Not sure why I was cc'd. ??


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] mik-laj edited a comment on issue #9627: MySQL support in Helm airflow database config

Posted by GitBox <gi...@apache.org>.
mik-laj edited a comment on issue #9627:
URL: https://github.com/apache/airflow/issues/9627#issuecomment-706032144


   @thesuperzapper  Wouldn't you like to contribute MySQL support?  I am happy to help with the reviews.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] potiuk commented on issue #9627: MySQL support in Helm airflow database config

Posted by GitBox <gi...@apache.org>.
potiuk commented on issue #9627:
URL: https://github.com/apache/airflow/issues/9627#issuecomment-652913931


   It's not a bug, it's a feature. The current helm chart does not support MySQL but I agree it should.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] boring-cyborg[bot] commented on issue #9627: MySQL support in Helm airflow database config

Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on issue #9627:
URL: https://github.com/apache/airflow/issues/9627#issuecomment-652903692


   Thanks for opening your first issue here! Be sure to follow the issue template!
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] mik-laj commented on issue #9627: MySQL support in Helm airflow database config

Posted by GitBox <gi...@apache.org>.
mik-laj commented on issue #9627:
URL: https://github.com/apache/airflow/issues/9627#issuecomment-706032144


   @thesuperzapper  Wouldn't you like to contribute MySQL support?  


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] potiuk edited a comment on issue #9627: MySQL support in Helm airflow database config

Posted by GitBox <gi...@apache.org>.
potiuk edited a comment on issue #9627:
URL: https://github.com/apache/airflow/issues/9627#issuecomment-706034434


   Yeah. Would be great !


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] jedcunningham closed issue #9627: MySQL support in Helm airflow database config

Posted by GitBox <gi...@apache.org>.
jedcunningham closed issue #9627:
URL: https://github.com/apache/airflow/issues/9627


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] potiuk commented on issue #9627: MySQL support in Helm airflow database config

Posted by GitBox <gi...@apache.org>.
potiuk commented on issue #9627:
URL: https://github.com/apache/airflow/issues/9627#issuecomment-652966722


   Ach sorry. CC: @schnie  (you are both just one line apart when typing "Greg" ).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] potiuk commented on issue #9627: MySQL support in Helm airflow database config

Posted by GitBox <gi...@apache.org>.
potiuk commented on issue #9627:
URL: https://github.com/apache/airflow/issues/9627#issuecomment-652914104


   cc: @dimberman @gstein 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] mik-laj commented on issue #9627: MySQL support in Helm airflow database config

Posted by GitBox <gi...@apache.org>.
mik-laj commented on issue #9627:
URL: https://github.com/apache/airflow/issues/9627#issuecomment-706032144


   @thesuperzapper  Wouldn't you like to contribute MySQL support?  


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] potiuk edited a comment on issue #9627: MySQL support in Helm airflow database config

Posted by GitBox <gi...@apache.org>.
potiuk edited a comment on issue #9627:
URL: https://github.com/apache/airflow/issues/9627#issuecomment-706034434


   Yeah. Would be great !


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] mik-laj edited a comment on issue #9627: MySQL support in Helm airflow database config

Posted by GitBox <gi...@apache.org>.
mik-laj edited a comment on issue #9627:
URL: https://github.com/apache/airflow/issues/9627#issuecomment-706032144


   @thesuperzapper  Wouldn't you like to contribute MySQL support?  I am happy to help with the reviews.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] potiuk commented on issue #9627: MySQL support in Helm airflow database config

Posted by GitBox <gi...@apache.org>.
potiuk commented on issue #9627:
URL: https://github.com/apache/airflow/issues/9627#issuecomment-706034434


   Yeah. Woudl be great !


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] jedcunningham commented on issue #9627: MySQL support in Helm airflow database config

Posted by GitBox <gi...@apache.org>.
jedcunningham commented on issue #9627:
URL: https://github.com/apache/airflow/issues/9627#issuecomment-832043409


   This was done in #15616.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org