[jira] [Commented] (AVRO-965) Enhance the IDL parser to allow properties for protocols and messages

["George Fletcher (Commented) (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/AVRO-965?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13162844#comment-13162844 ] 

George Fletcher commented on AVRO-965:
--------------------------------------

So I've been working on a patch for this enhancement and have it working for Protocols and mostly working for Messages. However, I've run into an issue with the IDL parser. Basically, the IDL parser assumes that any properties (@...) only apply to named schemas. Any help here greatly appreciated.

Here is the design I've been working from for this patch...

# Add the private Property class from Schema.java to Protocol.java
# Add getProp, addProp, and props methods to both Protocol and Message classes
# Add the hashcode of the Props set when comparing for equality
# Parse the json format
#* Protocol: find all "textual", "value" child nodes that are not reserved and add them as properties
#* Message: find all "textual, "value" child nodes that are not reserved and add them as properties. Required changing the constructor to accept a Map<String,String> of properties.
# Parse the IDL format
#* Protocol: Add all properties other than namespace to the Protocol property set
#* Message: NOT WORKING
# Update tests to work with the above changes

                
> Enhance the IDL parser to allow properties for protocols and messages
> ---------------------------------------------------------------------
>
>                 Key: AVRO-965
>                 URL: https://issues.apache.org/jira/browse/AVRO-965
>             Project: Avro
>          Issue Type: Improvement
>            Reporter: George Fletcher
>            Priority: Minor
>
> Enhance the IDL parser to support arbitrary properties for protocol and message types. This will allow for attaching metadata to a protocol or message and can be used for versioning and in some cases language annotations.
> This was partly discussed as part of JIRA ticket 886
> https://issues.apache.org/jira/browse/AVRO-886

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira