You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@myfaces.apache.org by we...@apache.org on 2010/05/03 15:26:56 UTC

svn commit: r940449 - /myfaces/core/trunk/api/src/main/javascript/META-INF/resources/myfaces/_impl/_util/_Utils.js

Author: werpu
Date: Mon May  3 13:26:56 2010
New Revision: 940449

URL: http://svn.apache.org/viewvc?rev=940449&view=rev
Log:
http://issues.apache.org/jira/browse/MYFACES-2640

After talking to the EG and rereading the spec it is clear now that the original behavior was the one you
should expect, the fixes were invalid, and no cherry picking of decorated identifiers should happen!


Modified:
    myfaces/core/trunk/api/src/main/javascript/META-INF/resources/myfaces/_impl/_util/_Utils.js

Modified: myfaces/core/trunk/api/src/main/javascript/META-INF/resources/myfaces/_impl/_util/_Utils.js
URL: http://svn.apache.org/viewvc/myfaces/core/trunk/api/src/main/javascript/META-INF/resources/myfaces/_impl/_util/_Utils.js?rev=940449&r1=940448&r2=940449&view=diff
==============================================================================
--- myfaces/core/trunk/api/src/main/javascript/META-INF/resources/myfaces/_impl/_util/_Utils.js (original)
+++ myfaces/core/trunk/api/src/main/javascript/META-INF/resources/myfaces/_impl/_util/_Utils.js Mon May  3 13:26:56 2010
@@ -258,9 +258,12 @@ if (!myfaces._impl._util._LangUtils.exis
                         evalNode = parentNode;
                     } else {
                         //normal dom node case we replace only the client id fragment!
-                        var replaceItem = myfaces._impl._util._Utils.findHtmlItemFromFragment(fragment, item.id);
-                        if(replaceItem == null)replaceItem = fragment;
-                        evalNode = item.parentNode.replaceChild(replaceItem, item);
+                        //TODO this code is heavily under discussion, probably invalid in the long run
+                        //I am reverting the findHtmlItemFromFragment back to fragment
+                        //var replaceItem = myfaces._impl._util._Utils.findHtmlItemFromFragment(fragment, item.id);
+                        //if(replaceItem == null)replaceItem = fragment;
+                        // replaceItem = fragment;
+                        evalNode = item.parentNode.replaceChild(fragment, item);
                     }
                 } else {
                     item.insertAdjacentHTML('beforeBegin', newTag);