You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@drill.apache.org by Daniel Barclay <db...@maprtech.com> on 2015/04/19 05:46:46 UTC

Review Request 33336: DRILL-2822: Changed timeout 90 s -> 120 s for Drill2128GetColumnsDataTypeNotTypeCodeIntBugsTest.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33336/
-----------------------------------------------------------

Review request for drill, Mehant Baid and Parth Chandra.


Bugs: DRILL_2822
    https://issues.apache.org/jira/browse/DRILL_2822


Repository: drill-git


Description
-------

Changed timeout on Drill2128GetColumnsDataTypeNotTypeCodeIntBugsTest.
Also fixed comment error in DatabaseMetaGetColumnsDataTest.


Diffs
-----

  exec/jdbc/src/test/java/org/apache/drill/jdbc/DatabaseMetaDataGetColumnsTest.java 42e343f 
  exec/jdbc/src/test/java/org/apache/drill/jdbc/test/Drill2128GetColumnsDataTypeNotTypeCodeIntBugsTest.java 3dd3421 
  exec/jdbc/src/test/java/org/apache/drill/jdbc/test/TestJdbcMetadata.java 8c6604a 

Diff: https://reviews.apache.org/r/33336/diff/


Testing
-------

Ran tests.


Thanks,

Daniel Barclay


Re: Review Request 33336: DRILL-2822: Changed timeout 90 s -> 120 s for Drill2128GetColumnsDataTypeNotTypeCodeIntBugsTest.

Posted by Parth Chandra <pc...@maprtech.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33336/#review80909
-----------------------------------------------------------

Ship it!


Ship It!

- Parth Chandra


On April 20, 2015, 3:05 a.m., Daniel Barclay wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33336/
> -----------------------------------------------------------
> 
> (Updated April 20, 2015, 3:05 a.m.)
> 
> 
> Review request for drill, Mehant Baid and Parth Chandra.
> 
> 
> Bugs: DRILL-2822
>     https://issues.apache.org/jira/browse/DRILL-2822
> 
> 
> Repository: drill-git
> 
> 
> Description
> -------
> 
> Changed timeout on Drill2128GetColumnsDataTypeNotTypeCodeIntBugsTest.
> Also fixed comment error in DatabaseMetaGetColumnsDataTest.
> 
> 
> Diffs
> -----
> 
>   exec/jdbc/src/test/java/org/apache/drill/jdbc/DatabaseMetaDataGetColumnsTest.java 42e343f 
>   exec/jdbc/src/test/java/org/apache/drill/jdbc/test/Drill2128GetColumnsDataTypeNotTypeCodeIntBugsTest.java 3dd3421 
>   exec/jdbc/src/test/java/org/apache/drill/jdbc/test/TestJdbcMetadata.java 8c6604a 
> 
> Diff: https://reviews.apache.org/r/33336/diff/
> 
> 
> Testing
> -------
> 
> Ran tests.
> 
> 
> Thanks,
> 
> Daniel Barclay
> 
>


Re: Review Request 33336: DRILL-2822: Changed timeout 90 s -> 120 s for Drill2128GetColumnsDataTypeNotTypeCodeIntBugsTest.

Posted by Daniel Barclay <db...@maprtech.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33336/
-----------------------------------------------------------

(Updated April 20, 2015, 3:05 a.m.)


Review request for drill, Mehant Baid and Parth Chandra.


Changes
-------

Just removed a space from Git commit comment.


Bugs: DRILL-2822
    https://issues.apache.org/jira/browse/DRILL-2822


Repository: drill-git


Description
-------

Changed timeout on Drill2128GetColumnsDataTypeNotTypeCodeIntBugsTest.
Also fixed comment error in DatabaseMetaGetColumnsDataTest.


Diffs (updated)
-----

  exec/jdbc/src/test/java/org/apache/drill/jdbc/DatabaseMetaDataGetColumnsTest.java 42e343f 
  exec/jdbc/src/test/java/org/apache/drill/jdbc/test/Drill2128GetColumnsDataTypeNotTypeCodeIntBugsTest.java 3dd3421 
  exec/jdbc/src/test/java/org/apache/drill/jdbc/test/TestJdbcMetadata.java 8c6604a 

Diff: https://reviews.apache.org/r/33336/diff/


Testing
-------

Ran tests.


Thanks,

Daniel Barclay