[GitHub] [fineract] avikganguly01 commented on a change in pull request #1330: Interop KYC and Interop Loan Disbursement

[GitBox <gi...@apache.org>]

avikganguly01 commented on a change in pull request #1330:
URL: https://github.com/apache/fineract/pull/1330#discussion_r490098735



##########
File path: fineract-provider/src/main/java/org/apache/fineract/interoperation/api/InteropApiResource.java
##########
@@ -373,4 +374,29 @@ public String performTransfer(@QueryParam("action") @Parameter(description = "ac
 
         return jsonSerializer.serialize(settings, result);
     }
+
+    @GET
+    @Consumes({ MediaType.APPLICATION_JSON })
+    @Produces({ MediaType.APPLICATION_JSON })
+    @Path("accounts/{accountId}/kyc")
+    @Operation(summary = "Query KYC by Account Id", description = "")
+    @ApiResponses({
+            @ApiResponse(responseCode = "200", description = "OK", content = @Content(schema = @Schema(implementation = InteropKycResponseData.class))) })
+    public String getClientKyc(@PathParam("accountId") @Parameter(description = "accountId") String accountId, @Context UriInfo uriInfo) {
+        InteropKycResponseData result = interopService.getKyc(accountId);
+        ApiRequestJsonSerializationSettings settings = this.apiRequestParameterHelper.process(uriInfo.getQueryParameters());

Review comment:
       Check permission for this action and entity (READ - CLIENTIDENTIFIER) ...context.authenticatedUser().validateHasReadPermission(ENTITY_NAME);
   

##########
File path: fineract-provider/src/main/java/org/apache/fineract/interoperation/service/InteropServiceImpl.java
##########
@@ -437,6 +550,19 @@ private SavingsAccount validateAndGetSavingAccount(@NotNull InteropRequestData r
         return savingsAccount;
     }
 
+    // private Loan validateAndGetLoan(@NotNull InteropRequestData request) {

Review comment:
       Remove this if you're not planning to use it.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org