You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by kant2002 <gi...@git.apache.org> on 2014/07/07 12:16:04 UTC
[GitHub] cordova-ios pull request: Created strongly typed configuration cla...
GitHub user kant2002 opened a pull request:
https://github.com/apache/cordova-ios/pull/98
Created strongly typed configuration class
Created strongly typed configuration for the following purposes:
- Remove configuration parsing logic and defaults handling from the
CDVViewController.m
- Improved testability of the Cordova configuration and other parts of
code which related on configuration could be much clearly mocked.
- Reduction for code duplication during configuration parsing.
- Ability to verify configuration issues during parsing, For example
passing not a number to the value which expected to be a number should
result to warning, so application developer could easily find error on
their side.
- Single place for storing configuration defaults.
Drawbacks in current implementation
- Not sure about memory leaks during such approach. Not very familiar
with iOS. This is need review
- No tests so far, could be added later if whole idea get traction.
- Currently no support for settings with limited set of values allowed.
Like «PaginationMode». Again could be added if whole idea would be
supported.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/kant2002/cordova-ios master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-ios/pull/98.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #98
----
commit 7e4bd83d55920c11272ed3e48a809a3017cdde7c
Author: Andrey Kurdyumov <ka...@gmailc.om>
Date: 2014-07-07T10:13:30Z
Created strongly typed configuration class
Created strongly typed configuration for the following purposes:
- Remove configuration parsing logic and defaults handling from the
CDVViewController.m
- Improved testability of the Cordova configuration and other parts of
code which related on configuration could be much clearly mocked.
- Reduction for code duplication during configuration parsing.
- Ability to verify configuration issues during parsing, For example
passing not a number to the value which expected to be a number should
result to warning, so application developer could easily find error on
their side.
- Single place for storing configuration defaults.
Drawbacks in current implementation
- Not sure about memory leaks during such approach. Not very familiar
with iOS. This is need review
- No tests so far, could be added later if whole idea get traction.
- Currently no support for settings with limited set of values allowed.
Like «PaginationMode». Again could be added if whole idea would be
supported.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cordova-ios pull request: Created strongly typed configuration cla...
Posted by shazron <gi...@git.apache.org>.
Github user shazron commented on the pull request:
https://github.com/apache/cordova-ios/pull/98#issuecomment-112975445
Thanks but due to the pluggable webview feature, each WebView plugin has its own configuration now (4.0.x branch). This PR will be auto-closed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-ios pull request: Created strongly typed configuration cla...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-ios/pull/98
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org