You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by "R-JunmingChen (via GitHub)" <gi...@apache.org> on 2023/08/02 00:55:49 UTC

[GitHub] [arrow] R-JunmingChen commented on a diff in pull request #36977: GH-36240: [Python] Refactor CumulativeSumOptions to a separate class for independent deprecation

R-JunmingChen commented on code in PR #36977:
URL: https://github.com/apache/arrow/pull/36977#discussion_r1281276135


##########
python/pyarrow/_compute.pyx:
##########
@@ -1933,6 +1933,34 @@ class PartitionNthOptions(_PartitionNthOptions):
         self._set_options(pivot, null_placement)
 
 
+cdef class _CumulativeSumOptions(FunctionOptions):

Review Comment:
   Sure, Have deleted. 
   But if we do that, the error message will report  `"`start` type for CumulativeOptions"` for CumulativeSumOptions.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org